Commit Graph
10129 Commits
Author SHA1 Message Date
David Mann 6d1ea6aaf7 Merge pull request #12924 from rmsff/fix/delete-anchor-options-bar-text-12827
Delete Anchor Point: options bar says the tool has no options
2026-11-10 16:19:21 +01:00
rmsff 67f865695e Object Selection: refuse Indexed Color and Bitmap documents
select.object (rectangle and point) returns the reference application's
alert text in these two modes and leaves the selection and History alone;
a click or drag with the tool opens that alert with OK instead of running.
2026-11-10 18:19:15 +03:00
David Mann bd79596bb3 Merge pull request #12911 from hectorviov/fix/ruler-escape
Ruler: Escape during a drag ends it and keeps the ruler (#11986)
2026-11-10 16:19:11 +01:00
rmsff 9106acf5d2 Test the Art History Brush colour mode refusal at 8 and 16 bits 2026-11-10 18:17:25 +03:00
rmsff 5989757980 Art History Brush: refuse a source of another colour mode
After Image > Mode the source state from before the change was converted
and painted; Photoshop refuses it. Compare the document modes, not the
pixel formats, which read Indexed and Multichannel as RGB. A bit depth
change still converts. The History Brush keeps its behaviour (#12842).
2026-11-10 18:17:25 +03:00
RickiNano 3af373a82f test(ui): time the Liquify Alt-twirl strokes explicitly (#12697) (#12712)
alt_with_twirl_clockwise_twirls_counterclockwise sent both strokes
through pointer(), which reads the wall clock. A held twirl's strength
is the elapsed time, so the plain and Alt runs could differ by more than
the 5 % the test allows on a slow runner. Both now go through pointer_at
at the same fixed times.
2026-11-10 16:11:00 +01:00
Dan 94c4eba813 docs: explain Freeform history contracts and regression fixtures 2026-11-10 14:59:11 +00:00
David Mann 7a866ff797 Merge pull request #12903 from rmsff/fix/type-mask-placeholder-12072
Start Type Mask text with the placeholder, as the Type tool does
2026-11-10 15:51:49 +01:00
David Mann 9b7a9aabe3 Merge pull request #11490 from Raghav2012Code/feat/crop-options-bar-details
Crop: Straighten gets its label and a spirit-level glyph (#10888)
2026-11-10 15:51:29 +01:00
David Mann 4651f92874 Merge pull request #11711 from yoriswind/codex/move-selection-11102
Fix Move Auto-Select toggling and locked-layer clicks (#11102)
2026-11-10 15:51:07 +01:00
Trevor BrownandClaude Opus 5.5 f123782f4c Confirmed and fixed in $H. With the Work Path selected in the Paths panel, \hit_active\ now searches only the Work Path, as it does for a selected saved path and as Path Selection does. A miss no longer falls through to the active shape.
New test \`with_the_work_path_selected_a_click_on_the_active_shape_does_nothing\`: the shape is active and the Work Path selected, and a Delete Anchor Point click on the shape's corner (650,250) leaves it unchanged with no history step. It fails on the previous head, where the corner knot was deleted. Anchor and direct_select tests: 107 passed; clippy \`-D warnings\` and fmt clean.
EOF2
cd C:/Users/thetr/.claude-personal-2/jobs/5c930f10/tmp && python cr_reply_resolve.py storytold/photocraft 12815 4525641135 $S/reply-12815-work-path.md 2>&1 | tail -2
Anchor tools: a selected Work Path is the only target too (#12762, #12705)

Review item on #12815: with the Work Path selected in the Paths panel, a miss on it fell through to the active shape.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and wrote (review fix, no brief)
2026-11-10 09:48:23 -05:00
David Mann 16d091c522 Merge pull request #12894 from rmsff/fix/warp-handles-always-visible-12497
Warp: show the Default grid's handles and split-grid anchors without hovering
2026-11-10 15:45:41 +01:00
David Mann 0e256a90fa Merge pull request #12873 from rmsff/fix/remove-cursor-centre-cross-12550
Remove tool: show the centre + in its brush cursor by default
2026-11-10 15:45:26 +01:00
Trevor BrownandClaude Opus 5.5 acc2c880ed Tests: the Add Anchor Point tests use the Delete Anchor Point tests' setup (#12705)
The two files had the same setup and steps; SonarCloud flagged them as duplicated new code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove and wrote (CI fix)
2026-11-10 09:32:41 -05:00
rmsff 19ed458045 Test the Delete Anchor Point options bar 2026-11-10 17:18:26 +03:00
rmsff fdf1daa4b3 Delete Anchor Point: options bar says the tool has no options
The test that pinned the old Delete hint goes.
2026-11-10 17:18:10 +03:00
Hector Villarreal 657b089aba Merge main into fix/ruler-escape (conflict in crates/ui-egui/src/tools/analysis_ui.rs)
Both sides added test-module lines at the end of analysis_ui.rs (main:
analysis_ruler_shift_tests from #11985 and note_clear_all_tests); kept all
three.
2026-11-10 08:13:12 -06:00
rmsff 587fd85295 Tests: cover splits of the Default warp grid (#12495) 2026-11-10 16:57:59 +03:00
rmsff 6279086a50 Warp: a one-way split on the Default grid keeps only the thirds across it
A horizontal split now turns the vertical thirds into anchor columns and drops the horizontal ones (3 x 2), a vertical split the mirror (2 x 3). Crosswise and splits of an already split grid are unchanged. The two tests that expected every third to stay now expect the cut in place of the dropped thirds.
2026-11-10 16:57:59 +03:00
terminalgateandClaude Sonnet 5.5 fb3b6a4b70 Eraser: add Erase to History (Brush, Pencil and Block modes) (#10692)
* Eraser: add Erase to History (Brush, Pencil and Block modes)

Photoshop's Eraser has an Erase to History option; PhotoCraft had only the History Brush.
With it ticked, the Eraser paints the History panel's source state back instead of
erasing, through paint.historyBrush with eraseToHistory. Pencil and Block modes paint back
through their hard tips. A layer that did not exist in the source state paints that
state's visible image; the History Brush itself still refuses such a layer, as Photoshop's
does.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* Keep tool_event within clippy's complexity limit

* Test Erase to History at every depth and tip

* Update the History Brush params comment for Erase to History

* Erase to History paints a layer made since only from a single-layer state

Compared with Photoshop 27.11.0: on a layer the source state does not hold, Erase to History paints
when that state holds a single layer, Background or not, and gives an error when it holds a second
layer, even an empty one. The composite of a multi-layer state is gone; those states now refuse
the layer with the History Brush's error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History paints a single source layer's own pixels

Photoshop 27.11.0 paints a layer made since with the source layer's pixels: a 50% opacity layer
gives a solid stroke, where the composite gave a faded one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: Pencil mode paints at full flow; test a group-only source state

Pencil mode has no Flow control, so a lower Flow set in Brush mode must not carry over. A source
state holding only a group has no pixels of its own and refuses a layer made since.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History keeps its options if a tool key is pressed mid-stroke

The stroke read the current tool and brush when it was committed, so pressing a tool's letter
during the drag dropped eraseToHistory and the stroke failed on a layer made since. The options
and the Eraser's tip are now captured at the press.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: a single solid shape paints its colour; name the History row

Photoshop 27.11.0 paints a shape layer's solid colour along the whole stroke, past its path, and
calls the stroke History Eraser in the History panel.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: a single shape without a solid fill paints white

Observed in Photoshop 27.11.0: a gradient, pattern or no fill paints plain white along the whole stroke, past the path and whatever the outline, in RGB, CMYK, Grayscale and Lab.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Eraser: Alt at the press reverses Erase to History for that stroke

As in Photoshop 27.11.0: with the option off Alt restores, with it on Alt erases. Alt pressed or released during the stroke changes nothing, and the option itself is left as it was.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: name the Photoshop version compared

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: review fixes for the error and the History Brush tip

A layer without pixels now gets the error that the target did not exist
in that history state, not "no active document". The History Brush keeps
its size, hardness and spacing from the press, as the Eraser does, if a
tool key is pressed mid-stroke.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Brush parity: add the Eraser's Erase to History

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Erase to History: document the functions this change touches

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* History Brush and Erase to History keep their whole brush from the press

Only mode, opacity, flow, size, hardness and spacing were kept from the press; the rest of the brush (tip shape, sampled tip, angle, dynamics, smoothing) came from the session brush at release. A tool key mid-stroke changed that brush, the commit rejected the live preview, and the fallback repainted the whole stroke with the new tool's brush. The stroke's params now carry the press-time brush as "brush" (stored tips as references, as each tool's remembered brush), and paint.historyBrush deep-merges it onto the session brush, so the live preview, the commit, its fallback and a replayed action all paint with it. Tests: a tool switch mid-stroke paints exactly what the same stroke paints without it, for the History Brush and Erase to History in Brush, Pencil and Block mode, across tip shape, sampled tips, dynamics and smoothing; a "brush" param paints as the session brush would; a malformed one is refused.

* History Brush docs: say "outside its shape", not "past its path"

The automation crate flags any command whose params text mentions a path as a possible filesystem path (registry_filesystem_path_params_are_classified); the eraseToHistory description meant a shape's vector outline. Also a test that a state whose one root item is a group of several layers is refused like the one-layer group: a group has no pixels to paint back.

* Test that a Shift-click Erase to History line commits its live pixels unsmoothed

Main's Shift-click fix (#11887) and this branch's press-time History
Brush params meet in finish_stroke_with; check the commit sends
smoothing 0 beside the brush param in all three Eraser modes.

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 14:51:20 +01:00
Dan 5545067928 test: cover Freeform strokes starting at a selected path endpoint 2026-11-10 13:47:55 +00:00
David Mann bf08f0834c Merge pull request #12862 from rmsff/fix/clone-stamp-reset-tip-12601
Reset Tool gives the Clone Stamp a 21 px soft tip at 25 % spacing
2026-11-10 14:45:08 +01:00
Trevor BrownandClaude Sonnet 5.5 bb35b99464 Anchor tools: a selected saved path is the only target; the Pen draft is edited again (#12762, #12705)
hit_active now searches only the saved path selected in the Paths panel when there is one, instead of falling through to the active shape or work path. Without a selected saved path it puts the Pen draft first, as direct_select::candidates does. The draft's destination is private to vector_ui, so it is not filtered here.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium
2026-11-10 08:44:01 -05:00
rmsff 6cebcf4e61 Test the Type Mask placeholder (#12072) 2026-11-10 16:40:58 +03:00
rmsff 76d055a7ee Start Type Mask text with the placeholder, as the Type tool does (#12072)
A click or a drag with the Horizontal Type Mask tool now starts with the same selected placeholder text as the Type tool, so typing replaces it and committing it untouched selects its outline. With "Fill new type layers with placeholder text" off, masks start empty, as type does.

The Vertical Type Mask keeps starting empty: its placeholder is not measured yet.
2026-11-10 16:40:58 +03:00
Dan 9fd70a78be Merge remote-tracking branch 'origin/main' into codex/12829-freeform-history 2026-11-10 13:40:18 +00:00
David Mann f222dd77e9 Merge pull request #12859 from rmsff/fix/blur-strength-range-alert-12650
Blur Strength: alert when a typed value is out of range
2026-11-10 14:36:07 +01:00
Raghav Krishna 72ed4e8303 Crop: the Fill help keeps the crop's keys, and a cleared ratio side commits zero (#10888)
Three findings from the review of #11490.

- A cleared ratio field with blank_when_zero now parses as zero instead of falling into the arithmetic hold, so deleting a side unsets it rather than restoring the old value.
- The Fill help's info button remembers its rect, so Esc and Enter in the frame the help opens go to the help: the shortcut pass runs before the options bar draws, and Esc used to cancel the pending crop first.
- Hiding the options bar (F twice, or Home) closes the Fill help, so its flag no longer keeps Enter and Esc away from the crop underneath.

Tests in tests/it/crop_options_bar_chrome.rs; all three fail without the fixes.
2026-11-10 19:02:10 +05:30
ec97a146f5 Support ordered automation read roots with safe save provenance (#3023)
* fix(cli): reject repeated automation read roots

* feat(automation): add ordered read roots with isolated saves

Stage source and regression tests for GGEO-AI02 validation before updating PR #3023. Repeated reads accumulate; writes remain single-root and implicit saves retain their selected capability provenance.

* style: format multi-root automation extension

* test: use fixed pixel chunks in read-root regression

* docs: reconcile control protocol with upstream TGA options

* docs: state multi-root capabilities directly in API summaries

* test: construct regression actions through upstream defaults

* Clarify headless and desktop directory automation reads

* Format the shared root parser and relocated service regressions

* test: adapt automation import callback to ImportOptions

* test: expect read-root diagnostic for denied smart-object input

* test: reject repeated write roots while allowing ordered read roots

* test: assert explicit empty-root parser diagnostic

* test: exercise leaf-link save using a supported image filename

---------

Co-authored-by: FredApps <FredApps@users.noreply.github.com>
Co-authored-by: Codex <codex@openai.com>
2026-11-10 14:28:12 +01:00
rmsff 5fda8ab32a Tests: Warp's points show without hovering (#12497) 2026-11-10 16:28:01 +03:00
rmsff 95c4bd91ea Warp: show the Default grid's handles and split-grid anchors without hovering (#12497)
Default's 4 corners and 8 edge handles are always drawn as round points,
and a split grid's anchors as hollow circles. A split or preset grid's
handles still show only near the pointer; the presets keep square anchors.

Fixes #12497
2026-11-10 16:28:01 +03:00
David Mann 4d5f8f116b Merge pull request #12851 from rmsff/fix/fill-rasterize-prompt-text-12538
Rasterize prompt: the fill wording as in the reference
2026-11-10 14:21:49 +01:00
David Mann 5705d4c9fa Merge pull request #12843 from rmsff/fix/red-eye-history-state-12573
Red Eye: name the step Red Eye Removal Tool and record a click that changes nothing
2026-11-10 14:21:39 +01:00
David Mann 9ec6a65aa7 Merge pull request #12819 from rmsff/fix/remove-new-layer-name-12542
Remove Tool: name the new layer "Remove tool edits"
2026-11-10 14:21:29 +01:00
David Mann 5dc18fa87b Merge pull request #12812 from rmsff/fix/dodge-refuses-indexed-12686
Dodge: refuse Indexed Color and Bitmap documents
2026-11-10 14:21:19 +01:00
David Mann 7f64c24195 Merge pull request #12811 from rmsff/fix/delete-last-anchor-12764
Delete Anchor Point: deleting a saved path's last anchor leaves it empty
2026-11-10 14:21:08 +01:00
David Mann 3466609441 Merge pull request #12809 from rmsff/fix/art-history-noop-state-12636
Art History Brush: a click held back by the tolerance adds its state
2026-11-10 14:20:58 +01:00
David Mann b6c4a7fc8b Merge pull request #12808 from rmsff/fix/add-anchor-options-bar-text-12731
Add Anchor Point: options bar says the tool has no options
2026-11-10 14:20:48 +01:00
David Mann bd2d87f64d Merge pull request #12813 from rmsff/fix/convert-point-history-names-12736
Convert Point: name History steps Change Anchor Point and Corner Drag
2026-11-10 14:20:39 +01:00
David Mann 60fef64a7a Merge pull request #12295 from hectorviov/fix/mixer-load-solid-colors
Mixer Brush: Load Solid Colors Only in the load menu (#11952)
2026-11-10 14:20:02 +01:00
David Mann 331aa99d50 Merge pull request #12232 from hectorviov/fix/perspective-crop-click-preview
Perspective Crop: the quad follows the pointer while corners are clicked
2026-11-10 14:11:08 +01:00
Dan ca8bc3cb9b test: cover Freeform history through the control pointer 2026-11-10 12:51:21 +00:00
rmsff be83ed2182 Test the Blur Strength range alert 2026-11-10 15:50:05 +03:00
rmsff 22fe3deba8 Tests: Remove tool cursor centre + and Show Crosshair for other brushes (#12550) 2026-11-10 15:49:59 +03:00
Dan 70c8cdcac9 fix: name Freeform Pen stroke history after the tool 2026-11-10 12:47:46 +00:00
rmsff 1f5ae5b7d3 Tests: the Clone Stamp's reset and first-use tip 2026-11-10 15:44:39 +03:00
David Mann 2a950d64dd Merge pull request #7377 from smyrgeorge/fuji-compressed-raf
Fujifilm compressed RAF: decode lossless and lossy files instead of the embedded preview
2026-11-10 13:36:29 +01:00
Raghav Krishna 851423af56 Crop: follow the new Straighten label in the task-bar test and CI formatting (#10888) 2026-11-10 17:48:54 +05:30
Raghav Krishna d936b583c3 Crop: follow the Reset tooltip in its options-bar test (#10888) 2026-11-10 17:48:54 +05:30
Raghav Krishna 3ecc3a0fdf Crop options bar: translate the new strings into every catalog (#10888) 2026-11-10 17:48:54 +05:30