Commit Graph
129 Commits
Author SHA1 Message Date
Khawar Zamman Wani c616c77002 Speed up adjustment previews for unstyled clipped raster layers (#12356)
* Preview adjustments on clipped raster layers in isolation

* Measure clipped adjustment previews and fix test lint

* Match styled preview benchmark to canvas proxy eligibility

* Keep styled clipped previews off the UI thread

* Address preview benchmark reporting and regression coverage review

* Document benchmark reporting regressions

* Document benchmark setup and isolated fixture execution
2026-11-10 16:26:38 +01:00
David Mann 9b7a9aabe3 Merge pull request #11490 from Raghav2012Code/feat/crop-options-bar-details
Crop: Straighten gets its label and a spirit-level glyph (#10888)
2026-11-10 15:51:29 +01:00
Raghav Krishna 72ed4e8303 Crop: the Fill help keeps the crop's keys, and a cleared ratio side commits zero (#10888)
Three findings from the review of #11490.

- A cleared ratio field with blank_when_zero now parses as zero instead of falling into the arithmetic hold, so deleting a side unsets it rather than restoring the old value.
- The Fill help's info button remembers its rect, so Esc and Enter in the frame the help opens go to the help: the shortcut pass runs before the options bar draws, and Esc used to cancel the pending crop first.
- Hiding the options bar (F twice, or Home) closes the Fill help, so its flag no longer keeps Enter and Esc away from the crop underneath.

Tests in tests/it/crop_options_bar_chrome.rs; all three fail without the fixes.
2026-11-10 19:02:10 +05:30
Raghav Krishna 851423af56 Crop: follow the new Straighten label in the task-bar test and CI formatting (#10888) 2026-11-10 17:48:54 +05:30
Raghav Krishna 1de14304f1 Crop: reference tooltips, Fill help modal, live-only Cancel/Commit, blank ratio sides (#10888) 2026-11-10 17:47:31 +05:30
Raghav Krishna aa12046847 Crop: Straighten gets its label and a spirit-level glyph (#10888) 2026-11-10 17:47:27 +05:30
rmsff c7407f50e5 Reset Tool gives the Clone Stamp a 21 px soft tip at 25 % spacing
The Clone Stamp now starts, and comes back after Reset Tool and Reset All Tools, with the reference's 21 px soft round at 25 % spacing and no smoothing (#12601).
2026-11-10 14:29:38 +03:00
Serikov Roman bbfa1758f6 fix(ui): Reset Tool gives the Healing Brush a 19 px hard tip at 25 % spacing (#12099) 2026-11-08 20:32:54 +03:00
Hector VillarrealandClaude Opus 5.5 fe210916f9 Check Size control is off after Reset All Tools (CodeRabbit review on crates/ui-egui/tests/it/background_eraser_reset_tip.rs:76)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 21:30:58 -06:00
Hector Villarreal fdbb79e46f Background Eraser: a 13 px hard tip at 25 % spacing after Reset Tool (#11911)
fresh_brush gives the Background Eraser the reference application's
reset tip, a 13 px hard round at 25 % spacing with Size control off, as
it gives the Brush its own (#11810). Reset Tool, Reset All Tools and the
tool's first use all start from it; other tools and strokes without a
brush keep their tips.
2026-11-07 19:50:53 -06:00
David Mann d438e97467 Merge pull request #10766 from yoriswind/codex/atn-menu-intent
Add five Classic Actions panel commands
2026-11-07 23:59:31 +01:00
David Mann 8b1e614e7b Merge pull request #11856 from RickiNano/fix/11810-brush-reset-default-tip
Reset Tool gives the Brush a 13 px soft tip (#11810)
2026-11-07 23:45:04 +01:00
89f5946829 Merge main into #5238: keep main's live Mixer Brush, port the same-frame paint order
Main gained its own live Mixer Brush in #3627 (engine `cmd/brush_cmds/mixer_live.rs`, the
release path in `canvas/gesture.rs`), so this merge takes main's side for the engine, paint,
docs and scorecard files and drops this PR's parallel `LiveMixer` API and its engine test.

What stays from #5238 is the paint order: while a live painting tool is selected (and no dialog
owns the canvas), the image is prepared after this frame's pointer and navigation input, so a
dab or a wheel pan/pinch zoom shows in the frame it happens instead of one frame later. Ported
onto main's split `canvas.rs`, with its tests in `canvas/live_frame_tests.rs` and
`tests/it/live_stroke_canvas.rs`, adjusted for main (the removed `interface.enableAnimations`
preference, the new wheel event `source`, and the Mixer release that commits its preview pixels).

Co-Authored-By: bommerts <44821497+bommerts@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-07 19:26:17 +01:00
yoriswind 99653a4626 fix(actions): preserve the Equalize dialog on recorded playback 2026-11-07 10:24:40 -08:00
David Mann 3c000ea238 Merge pull request #8307 from midasdf/jp/print-paper-sizes
Print: Japanese paper sizes (はがき・往復はがき・JIS B5/B4・L判)
2026-11-07 14:11:19 +01:00
David Mann 7f7badcdc4 Merge pull request #11692 from RickiNano/fix/magnetic-lasso-right-click-11689
Magnetic Lasso: a right-click while drawing opens no menu (#11689)
2026-11-07 11:57:00 +01:00
RickiNano 9d21d6c640 Reset All Tools gives each painting tool its own starting brush (#11810)
Reset All Tools cleared every tool's remembered brush, and a tool
without one takes the live brush when it is picked. With the Brush's
starting tip now differing from the other tools', that leaked: Reset All
from the Brush left the Pencil and Eraser on a 13 px soft tip, and from
another tool it left the Brush on a 20 px hard one. Reset All now gives
each painting tool other than the live one its own starting brush.

Also names the Brush tool's reset tip and updates tool_reset's docs.
2026-11-07 08:41:17 +01:00
RickiNano 4fa29f657d Reset Tool gives the Brush a 13 px soft tip (#11810)
Reset Tool and Reset All Tools gave the Brush tool the default 20 px
hard tip at 10 % spacing. The reference resets it to a 13 px soft round
(hardness 0 %, spacing 25 %). `fresh_brush` now takes the tool and
gives the Brush that tip; the other painting tools and
`BrushSettings::default()` keep today's tip.
2026-11-07 08:25:49 +01:00
David Mann 927c63d394 Merge pull request #11022 from Hamza0101/fix/crop-overlay-and-fill-defaults
Crop: Always Show Overlay by default, Fill resets on another open document, and an untouched frame shows only itself (#10894, #10930)
2026-11-07 01:11:21 +01:00
yoriswind 3f37e56a86 Merge landed main into the Actions review fix 2026-11-06 13:55:27 -08:00
David Mann 6b0f7762e1 Merge pull request #11671 from davidmann4/integration-batch-20
Integration batch 20: 7 i18n PRs (Thai, Hebrew, Urdu, Tamil, Azerbaijani, Romanian, Korean)
2026-11-06 22:49:42 +01:00
RickiNano 9d16699d45 Magnetic Lasso right-click: an ⌥-drag's freehand segment keeps its menu (#11689)
The issue leaves a right-click during an ⌥-drag unmeasured, so it keeps
today's behaviour. `magnetic_drawing` held that menu back too; it now
skips a freehand segment.
2026-11-06 22:21:45 +01:00
David MannandClaude Opus 5.5 46d6307cba Crop task bar: Done fits the cropped document
The bar draws inside the canvas pass, whose write-back of its own camera
dropped the fit that commit_crop asks for, so Done kept the old zoom. The
stored view now wins when the bar changed it, as a view menu row's does.
done_fits_the_cropped_document starts at 50 % and fails without the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 21:17:51 +01:00
RickiNano 8519977bc1 Magnetic Lasso: a border on another document holds back no menu (#11689)
The right-click check asked only whether a border existed. Over the
control channel no frame runs between events, so a border left on one
document stayed in place after a switch and kept the selection menu
from opening on the next. The check, now magnetic_lasso_ui::drawing,
also asks that the border belongs to the document in front, the same
test frame() uses to drop a stale border. The canvas, the control
channel and frame() share it.

agent_right_click_on_another_document_still_opens_the_selection_menu
fails without this change. The context-menu parity doc records the
behaviour.
2026-11-06 21:06:45 +01:00
RickiNano 14a27b360f Magnetic Lasso: a right-click while drawing opens no menu (#11689)
With a Magnetic Lasso border in progress, a right-click on the canvas
opened the selection tools' menu over the live border, in the window and
over the control channel. As in Photoshop, it now opens nothing and the
border stays live: Enter or Esc still close or cancel it. With no border
in progress the menu opens as before. Cmd/Ctrl+right-click (the layer
list) is unchanged, since it was not measured.

Tests in crates/ui-egui/tests/it/magnetic_lasso_right_click.rs drive
both paths; the two "while drawing" tests fail without the fix.
2026-11-06 20:18:16 +01:00
David MannandClaude Opus 5.5 e078c560ec Address CodeRabbit review: task bar tile, inspect and ui.set merge
- Draw the Crop task bar only on the active document's tile: a click into
  another tile activates its document mid-pass, and the tile drawn after it
  put the new frame's bar on itself for that frame.
- ui.inspect reports the bar hidden (and no rect) as soon as it can't show,
  not only after the next draw.
- ui.set merges panels.task_bar field by field: {"at": [x, y]} keeps a pin,
  {"pinned": true} keeps a dragged place; unknown nested fields are refused.
- Tests for each (each fails with its fix reverted), plus the task bar's
  preset dropdown picking 1 : 1 in sync with the options bar.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 19:41:21 +01:00
David MannandClaude Opus 5.5 da7690e937 Camera Raw localization test: allow tofu only for Tamil until craft-fonts ships it
The pinned central font manifest has no Tamil face (storytold/craft-fonts#63 adds one) and the
Linux runner has none installed, so the strict missing-glyph policy panicked on the Tamil
labels. Tamil keeps every label and state check; a guard fails once the manifest ships Taml.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 19:27:10 +01:00
yoriswind 5f480238d0 Reconcile five Classic Actions commands with current main 2026-11-06 09:29:48 -08:00
David Mann 7919429708 Merge remote-tracking branch 'origin/main' into feat/crop-task-bar-10890 2026-11-06 17:50:28 +01:00
David MannandClaude Opus 5.5 c7b5373ba8 Crop: Contextual Task Bar under the crop frame, as a reusable task-bar widget (#10890)
The Crop tool gets the reference application's contextual task bar: a small floating
bar centred 11 pt under the crop frame with a grip, the preset dropdown (the options
bar's own, so both stay in sync), Straighten, a ⋯ menu (Hide bar, Reset bar position,
Pin bar position) and, while a crop is pending, Cancel and Done. It follows the frame,
stays inside the canvas, and stays put once dragged or pinned. Window › Contextual Task
Bar (after Tools, as in the reference) shows and hides it.

The bar itself is a reusable widget (widgets/task_bar.rs): position rule, grip, ⋯ menu
and the hide/pin/place state in Panels (kept with the panel layout across restarts,
read by ui.inspect › taskBar, set by ui.set {panels}). A context supplies only its
controls and where ⋯ goes; the Crop contents are tools/crop_task_bar.rs. Generative
Expand stays out until #41.

Also: Lucide pin and rotate-ccw icons, six new strings in all 27 catalogues, parity
661/661 (FLOOR raised), control-protocol docs. Three tests about the options bar's
Ratio dropdown now hide the task bar, which shows the same dropdown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:50:20 +01:00
David Mann 8df0c8ba54 Merge origin/main into fix/crop-overlay-and-fill-defaults
# Conflicts:
#	crates/ui-egui/src/tools/crop_ui.rs
2026-11-06 16:25:10 +01:00
yoriswind 145747962a Keep Actions control playback headless and preserve ATN imports 2026-11-05 22:14:49 -08:00
yoriswind 994443c310 Preserve Actions menu ownership controls 2026-11-05 18:23:19 -08:00
yoriswind 84c41c5f10 Limit Actions panel changes to the five reviewed commands 2026-11-05 17:13:15 -08:00
David Mann dabf3bab97 Merge commit '9bef3b2dc8b84c1b6cefc8ce0dc2b01d089cd9e8' into HEAD
# Conflicts:
#	docs/scorecard.md
2026-11-06 01:54:36 +01:00
David Mann 0f15223e18 Merge pull request #7739 from davidmann4/fix/crop-swap-button-turns-frame
Crop: the options-bar swap button turns the frame instead of shrinking it (#7738)
2026-11-06 01:07:36 +01:00
Hamza 20d13e5205 Crop: a drawn, moved or resized frame has changed when the gesture changed it
From review: release compared the frame with where it started, so a click on a handle of the untouched frame counted as a change (a Resize that resized nothing), and an Alt-drag from the centre that drew the same frame again counted as none. It now asks whether the gesture changed the frame at some point (drag_moved, including the release's own position); turns and image moves keep their checks.
2026-11-05 16:28:16 +05:00
Hamza 91fec0df9c Merge remote-tracking branch 'origin/main' into fix/crop-overlay-and-fill-defaults
main added the turning grid and draws the guides for the visible part of the frame (current_guides_for_frame). Kept from both: the canvas calls main's guides with this PR's frame look, and this PR's FrameLook functions sit beside main's visible_frame and turn_grid. The overlay still waits for the crop's first change, except while a turn or a straighten line is in progress, whose guides show from the start as main's tests expect.
2026-11-05 16:12:28 +05:00
midasdf b60b58af6c Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	docs/target-app-parity.md
2026-11-05 18:00:44 +09:00
Hamza b2661918ed Crop: a click inside the untouched frame that draws nothing keeps its untouched look
A press inside the untouched default frame starts a Draw, and release counted every Draw as the first change, so an unmoved click showed the shield, the overlay and the started outline around the same frame. A Draw that leaves the frame it was pressed on is no change, as a click outside it already wasn't.
2026-11-05 12:07:46 +05:00
David MannandClaude Opus 5.5 524826e9fc Fix-up #10396: Esc in crop_beyond_canvas hides the frame
Since #10396 Esc hides the crop frame until the next press (#10370), so the
test expects no frame after Esc instead of a new default one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-04 15:45:35 +01:00
Hamza d45face8ef Crop look tests: a commit now hides the frame until the next press (main's 75a6828f5) 2026-11-04 12:42:11 +05:00
Hamza a78664046c Merge remote-tracking branch 'origin/main' into fix/crop-overlay-and-fill-defaults
# Conflicts:
#	crates/ui-egui/tests/it/main.rs
2026-11-04 12:42:11 +05:00
Hamza a4ff5aa673 Crop: a drag keeps the started look once it has changed the frame, and the untouched dashes stay anchored to the corners 2026-11-04 12:32:34 +05:00
yoriswind fdf1f48a1c test(crop): dispose unused CPU texture updates 2026-11-03 21:10:29 -08:00
yoriswind 814c2baf93 test(crop): cover turning grid through canvas paint 2026-11-03 20:31:43 -08:00
yoriswind 85ecb52b2b Use the painted crop frame for visible guide geometry 2026-11-03 20:01:11 -08:00
yoriswind d68c29b74a Generate crop turning guides for the visible frame extent 2026-11-03 19:40:31 -08:00
yoriswind aafe62fa91 Show a centred crop grid while turning 2026-11-03 19:22:53 -08:00
David MannandClaude Opus 5.5 37c84c18e5 Batch: Ctrl-held Straighten test expects transparent corners with Delete Cropped Pixels off
Main's #10905 (#10867) turns the Background into Layer 0 when a crop keeps
the cropped pixels, so the corners a turn uncovers stay transparent instead
of taking the background colour. The #10950 test now expects that for its
Delete Cropped Pixels off cases; with it on the corners are still the
background colour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 23:39:48 +01:00