Commit Graph
12 Commits
Author SHA1 Message Date
David MannandClaude Opus 5.5 42e92cb512 Address review: Batch stops, rename targets, Shape Blur memory, sampler releases
- A direct Batch in a script or a CLI command list stops it when it is cancelled,
  cannot write its error log, or ran out of script steps; per-file errors alone
  still continue (CodeRabbit, outside-diff findings on automate_cmds.rs and
  photocraft-cli document.rs).
- Recorded Save steps count against the script's step budget, and a Batch whose
  files failed with the budget spent carries scriptLimitError, so Browse reports
  the failure instead of ok: true (yoriswind).
- actions.rename rewrites a named Batch, nested Play or Conditional call only if
  it resolved to the renamed action before the rename; a Batch with explicit
  steps is left alone (yoriswind: two same-named actions in different sets).
- Shape Blur's run admission counts each worker's f64 prefix sums and, for a
  custom shape, the kernel mask kept for the run plus its worst-case coverage
  runs (yoriswind).
- Every sampler that takes the primary release (Color Picker, Curves/Levels and
  Properties eyedroppers, Curves Cmd-click, Color Range) ends a transform handle
  drag and a Move drag begun before it, not only the Color Picker (#11210 review).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 13:20:01 +01:00
David MannandClaude Opus 5.5 16000b01ef Address CodeRabbit review: batch 17 findings
Engine: droplet dependency capture skips disabled steps; a nested Batch
that was cancelled or could not write its error log fails the caller;
runDroplet forwards overrideOpen; actions.rename follows named Batch
steps; Batch steps inside a script count against MAX_SCRIPT_STEPS;
output claims compare destination identity; Save and Close never
replaces a read-only source. ATN: Md must be a BlnM enumeration,
adjustment-layer names must round-trip, Calculations exports a missing
blending as Multiply, Apply Image refuses unnamed-layer transparency.
Filters: Shape Blur records its resolved geometry, reserves its kernel
memory first, and reports a preparation failure as an error, not a
cancel; Crop keeps an artboard preset when the size is unchanged and
fits the board on a turned crop.

Codecs/cms/algo: zero-axis FITS image HDUs are empty; a GIF walk that
breaks off before the trailer fails closed; two-value .3dl shaper rows
are applied; fragmented custom kernels are refused and their work polls
cancellation.

UI: Conditional branches play through panel playback; paused actions
refuse to resume after being replaced; Playback Options OK validates
its fields; transform double-click ignores a hidden pivot; path boxes
snap to a stationary selection; modal blocking uses the effective tool;
a picker-consumed release clears snap lines and ends a Move drag; the
Crop preset control shows Selection and checks only it; Crop box undo
restores frame_from_selection; Bosnian fill labels.

Tests: timing asserts moved to an ignored test, plus the review's
coverage nitpicks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-05 11:37:38 +01:00
yoriswind 5f575ddfe1 test(ui): cover Color Picker release during transform drag 2026-11-04 18:28:46 -08:00
yoriswind 49c99cec01 Let existing Move gestures finish across modal opening 2026-11-04 16:04:44 -08:00
yoriswind 363c7e3461 Keep embedded modal previews from forwarding Move gestures 2026-11-04 15:04:27 -08:00
yoriswind 9fd6a5c92c Keep dialog-owned pointer gestures out of ordinary Move 2026-11-04 14:16:03 -08:00
yoriswind 28d99ad867 Respect modal ownership before starting Move transforms 2026-11-04 12:42:43 -08:00
yoriswind 29534d08c0 Document atomic Move control dispatch and behavioral controls 2026-11-03 22:11:16 -08:00
yoriswind 280ddd2a7d Match each committed layer to the rotation preview 2026-11-03 20:02:32 -08:00
yoriswind 9b3febb11c Keep control-channel transform activation inside the canvas 2026-11-03 19:25:04 -08:00
yoriswind 5f48c9c371 Handle egui texture deltas in transform control tests 2026-11-03 17:52:09 -08:00
yoriswind 336f95cd7d Expose Move transform controls through the control channel 2026-11-03 17:17:05 -08:00