Commit Graph
3891 Commits
Author SHA1 Message Date
Trevor BrownandClaude Fable 5.1 d8bce6b97d Move gear: the marker getter names the direct-write exception too (#11381)
Doc only: the getter's comment now says, as the field's does, that a direct write to DocState::active_layer through active_mut() bypasses the change marker.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 14:40:19 -05:00
Triwarr adbe906eaf PDF: fix CI packaging and CodeRabbit findings
- Stage pdfium.dll for the MSI fixtures (install-policy payload) and for the real package
  stage/portable zip; the package script downloads it before cargo.
- Regenerate docs/scorecard.md for the new Preferences fields.
- Text y positions convert the page height to pixels; invisible PDF text stays hidden.
- Page ranges that start past the PDF are refused; zero first/last bounds are independent.
2026-11-06 20:11:03 +01:00
Cristi RaduandClaude Opus 5.5 a1bb9f003f Saves take maximizeCompatibility for a PSD/PSB's merged image (#8064)
Photoshop's Maximize Compatibility checkbox, for one save: `maximizeCompatibility`
(true or false) on Save, Save As, Save a Copy, `app.save`, serve `doc.save`, MCP
`doc_save`/`doc_export`, Batch, Image Processor and Layers to Files decides the
merged image over Preferences > File Handling > Maximize PSD and PSB File
Compatibility; unset, the preference decides. Anything but a boolean is refused
before anything is written. The CLI takes `--no-maximize-compatibility`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 21:07:10 +02:00
Trevor BrownandClaude Fable 5.1 2e4ced2469 Move gear: active_layer_changes is a change marker, not an exact count (#11381)
Session::active_layer_changes now documents its contract: it advances at least once whenever the active document or layer changes, so callers compare two readings for equality. A file.new or a document close may advance it twice (add_document and execute both note it); removing that is not a one-liner, so the wording covers it. Adds a test that file.new advances the marker and a same-layer select_layer does not.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 13:45:24 -05:00
Cristi RaduandClaude Opus 5.5 53917dc175 Preferences: Skip Transform when Placing (#8492)
Preferences > General > Skip Transform when Placing (off by default), as in
Photoshop: a placed or dropped file lands without Free Transform. It is
checked in begin_placed, which every interactive place reaches, so drops
still go through main's background place job (#10147) and queue; with the
preference on, the next queued file starts as soon as one lands.
Scripted file.placeEmbedded/placeLinked never open Free Transform, so the
preference doesn't affect them. Label translated in every catalog that
translates the neighbouring place preferences (all but hi).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 20:38:19 +02:00
Triwarr 84644de102 PDF: expose the page range as two Preferences numbers 2026-11-06 19:36:49 +01:00
Hartmut Nörenberg e5d597f6e7 Merge remote-tracking branch 'upstream/main' into feat/reset-transform-smart-object-11662
# Conflicts:
#	docs/ui-parity.md
2026-11-06 19:36:36 +01:00
Firstbober 7f96ce5343 Preserve Indexed profiles and preview current tool colors 2026-11-06 19:26:52 +01:00
David Mann d1d913e7e6 Merge remote-tracking branch 'origin/main' into feat/crop-task-bar-10890 2026-11-06 19:24:17 +01:00
Triwarr 244a6287ab PDF: import options (page range, DPI, editable text/vector) and DLL packaging
- ImportOptions gains pdf_pages (1-based inclusive), pdf_text and pdf_vectors;
  the importer maps PDF text objects to editable text layers and vector paths to
  shape layers through the effective DPI.
- photocraft-cli convert gains --pdf-dpi and --pdf-pages.
- Preferences gain pdf_dpi/pdf_pages, wired through jobs::import_options.
- apps/photocraft/build.rs copies PDFIUM_DLL beside the exe; the MSI installs it.
2026-11-06 19:15:09 +01:00
Triwarr 94a4998208 PDF: address CodeRabbit review (cancellation, budgets, labels, export edges)
- Cancellation: the importer and the PDF writer take the Interrupt and check between pages.
- Physical size: the effective DPI keeps each page print size when budgets cap the raster.
- Oversized pages: final dimensions are checked before rendering.
- Memory: pages go straight into layer surfaces; the aggregate pixel estimate is admitted.
- Labels: /PageLabels (UTF-16BE) carry artboard names; no label is drawn outside the media box.
- Metadata: the artboard export warns when free-form text metadata is dropped.
- Export: hidden groups report their children; non-string modes are rejected; case-insensitive
  filename collisions are suffixed.
- Dispatch: a recognised raster renamed .pdf goes to the flat importer; .ai keeps its path.
- Platform: the PDFium recovery message names the actual library.
2026-11-06 19:15:08 +01:00
Triwarr 3a1b41f0c6 PDF: bound the import canvas
The importer budgets the per-page raster (100 M px) and the artboard strip (200 M px): an
oversized page is scaled down, and pages that would exceed the strip budget are skipped with
a warning, instead of allocating a multi-gigabyte union canvas. The page-count cap stays 16.

Also applies cargo fmt to the new PDF code and the export-recursion test.
2026-11-06 19:15:08 +01:00
Triwarr c1662d4911 Export: split nested groups into separate layers/files
file.export.layersToFiles gains groups: layers (walk every visible leaf at any depth, not only top-level layers) and naming: layer (bare <layer>.png names; duplicates get -2). This is the recursive folder export from the local Program Files build, brought in as the second fix on this branch.

Tested: layers_to_files_exports_group_children_as_loose_files (nested subgroup + sibling).
2026-11-06 19:15:08 +01:00
Firstbober 2fbec8b533 fix: preserve document colours for indexed mattes 2026-11-06 19:14:59 +01:00
Firstbober 3a7a0aaa1e feat: add Indexed Color matte control 2026-11-06 19:14:58 +01:00
Trevor BrownandClaude Fable 5.1 402b59bcde Move gear: every active-layer change counts, not only the ones through execute (#11381)
Session::note_layer_change(before) now backs the change count and is called by execute, start, finished jobs, select_layer, restore_layer_selection, layer_multi_cmds::set_selection, undo, redo, rollback and a new Session::set_active_layer; document switches (note_active_change) count too. The Pen tool's direct write of the active layer goes through set_active_layer.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 12:52:14 -05:00
f23d173933 Add an opt-in WinTab backend for pen pressure on Windows (#11331)
* Add an opt-in WinTab backend for pen pressure on Windows

Windows Ink stays the default. Preferences > Tools > Pen Tablet has a Tablet
input dropdown (Windows Ink (default) / WinTab). WinTab opens a WinTab 1.4
system context on PhotoCraft's window and polls pressure and the eraser end
(tilt on devices that report orientation axes; rotation only with a pen and
driver that report twist) into the stylus feed. The row says to turn Windows
Ink off in the tablet's software utility; the choice applies at next launch.

- crates/tablet: Windows-only wintab/wintab-sys backend. Devices with
  orientation axes use the orientation packet; pressure-only devices open a
  packet without it and report neutral tilt. Leaving is the driver's hardware
  proximity message (WT_PROXIMITY) and the packet's out-of-context status, with
  a long fallback for drivers that never report either. Overlap priority
  follows window focus, and the message hook requests a frame for each WinTab
  message so pressure-only strokes update without cursor movement.
- apps/photocraft: install the backend when the preference is on; poll it at
  the start of each frame; the installed wake repaints the UI.
- ui-egui: TabletPollFn service; the Windows-only Pen Tablet row with the
  Tablet input dropdown and the note.
- engine: tools.tabletInput (windowsInk/winTab), default windowsInk.
- docs: hardware-parity WinTab gap entry, qualifying tilt to orientation axes
  and rotation to twist-reporting pens.

Tested locally on a Wacom tablet with Windows Ink off: pressure, tilt and the
eraser end reach the brush (rotation where the pen reports twist); the default
path is unchanged.

* WinTab: a message that finds the state borrowed is skipped, not a panic in the hook

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* WinTab: rustfmt

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Scorecard: count the Tablet input setting

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:39:40 +01:00
FredApps d2ce418bb3 Merge pull request #11641 from wanikhawar/claude/agitated-jones-8e1a8e
A little free memory no longer refuses every PSD; the refusal says what to do
2026-11-06 18:36:17 +01:00
812b25fa10 Batch fix-up: CodeRabbit findings on #11249, #11541 and #9862
- #11249: a recorded Blend If Set that also carries real layer effects (a
  Lefx with more than the scale) stays the recorded step instead of playing
  and saving back without the effects.
- #11541: the toolbar "..." flyout owns Escape, so Escape with it open no
  longer deselects or leaves full screen; a failed Edit Toolbar from a left
  click on "..." reports its error in the status bar like the flyout row.
- #9862: the click-on-another-layer check uses the commit's targets (the
  link group as it is now), so a layer linked after the box opened is not
  "another layer".

Each has a test that fails without the fix.

Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: TrevorBrown-dev <TrevorBrown-dev@users.noreply.github.com>
Co-Authored-By: Higgs32584 <Higgs32584@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 18:35:38 +01:00
yoriswind 5f480238d0 Reconcile five Classic Actions commands with current main 2026-11-06 09:29:48 -08:00
Nikolai Nyegaard d4240b630d Labels: match Photoshop's menu, tooltip and spelling conventions
Edit > Preferences > General…, Select > Inverse, Filter > Other without the
ellipsis, Layer > Rename Layer… with one, Proof Setup's color-blindness names
with a hyphen, the Layers panel's Quick Export as PNG, the toolbar's Default
Foreground and Background Colors (D) and Switch Foreground and Background
Colors (X), and the remaining British spellings in the English source. Keys
renamed in every catalog; rows dropped where the new key was already translated.
2026-11-06 18:19:19 +01:00
FredApps ce97bde34b Merge pull request #11628 from wanikhawar/claude/brave-wu-261567
Network scratch folders report their own free space, or say they can't
2026-11-06 18:15:40 +01:00
Hartmut Nörenberg e24efcf762 feat(engine): reset a smart object's transform
Layer > Smart Objects > Reset Transform (#11662): the placement goes back to
100 % of the current contents' own box, with rotation, skew, Distort and
Perspective cleared and the object left centred where it sits, in one history
step. Photoshop resets the transform and not the warp, so the smart object's
Warp (kept in source space) and its smart filter stack stay as they are.

The map is applied through the Free Transform path, so a linked layer or
vector mask and the Smart Filter mask follow the placement back and the object
re-renders losslessly from its source. transform_by_map is the projective
sibling of transform_by: the step from a Distorted placement to an axis-aligned
one is not affine. The exact reset map is pinned onto the placement afterwards,
because new * old^-1 * old only lands on it to float noise and would otherwise
keep a nearly affine perspective in the document.
2026-11-06 18:13:51 +01:00
Saloouu 3ed01375e5 Merge main 2026-11-06 18:13:34 +01:00
FredApps 71aa3eef9a Merge pull request #10164 from wanikhawar/fix/10031-web-place-steps
Web build: Place runs a slice per frame, so a large PNG no longer freezes the page
2026-11-06 18:12:11 +01:00
FredApps a81d9f9220 Merge pull request #11609 from wanikhawar/fix/smart-filter-stale-adjust-params
Stop stale settings overriding edits to adjustment smart filters
2026-11-06 18:09:27 +01:00
Trevor BrownandClaude Fable 5.1 7fc8ec621c Move gear: the pick marker lasts until the next active-layer change, not a frame (#11381)
The counter lives in the engine: Session::active_layer_changes(), bumped by Session::execute whenever a command leaves a different active document or layer (selection commands, Action playback, undo, canvas picks). note_move_pick stores it with the picked id; layer_reveal::track accepts the marker only if the active layer is that id and the count is unchanged, so it survives a hidden panel for any number of frames and any later non-pick change (even back to the same id) invalidates it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 11:55:37 -05:00
FredApps c49c1fd6fc Describe scratch settings without promising memory admission
Present the live scratch state as current configuration rather than the cause of a file's refusal. Explain that configured scratch capacity cannot override caller/build limits or replace non-spillable memory. Keep the typed error and admission policy unchanged, and add wording regressions.

Formatting and whitespace checks passed. No local build or test execution; validation awaits hosted CI.
2026-11-06 17:51:45 +01:00
David Mann 7919429708 Merge remote-tracking branch 'origin/main' into feat/crop-task-bar-10890 2026-11-06 17:50:28 +01:00
David MannandClaude Opus 5.5 c7b5373ba8 Crop: Contextual Task Bar under the crop frame, as a reusable task-bar widget (#10890)
The Crop tool gets the reference application's contextual task bar: a small floating
bar centred 11 pt under the crop frame with a grip, the preset dropdown (the options
bar's own, so both stay in sync), Straighten, a ⋯ menu (Hide bar, Reset bar position,
Pin bar position) and, while a crop is pending, Cancel and Done. It follows the frame,
stays inside the canvas, and stays put once dragged or pinned. Window › Contextual Task
Bar (after Tools, as in the reference) shows and hides it.

The bar itself is a reusable widget (widgets/task_bar.rs): position rule, grip, ⋯ menu
and the hide/pin/place state in Panels (kept with the panel layout across restarts,
read by ui.inspect › taskBar, set by ui.set {panels}). A context supplies only its
controls and where ⋯ goes; the Crop contents are tools/crop_task_bar.rs. Generative
Expand stays out until #41.

Also: Lucide pin and rotate-ccw icons, six new strings in all 27 catalogues, parity
661/661 (FLOOR raised), control-protocol docs. Three tests about the options bar's
Ratio dropdown now hide the task bar, which shows the same dropdown.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:50:20 +01:00
David Mann b5acb4c622 Merge origin/main into integration-batch-19 2026-11-06 17:32:14 +01:00
FredApps 8d2ee0787f Merge scratch query updates into memory admission policy 2026-11-06 17:29:23 +01:00
FredApps aee46a2fc6 Merge remote-tracking branch 'origin/main' into fix/10164-final-prune-u2 2026-11-06 17:28:48 +01:00
David Mann af99f69602 Merge pull request #7719 from davidmann4/fix/cas-background-selection
Content-Aware Scale works on the Background with a selection (#7717)
2026-11-06 17:28:41 +01:00
FredApps 898979da30 Merge main into scratch folder capacity queries 2026-11-06 17:27:38 +01:00
FredApps 2ce36bd66c Merge main and use replacement for adjustment smart filter edits 2026-11-06 17:27:16 +01:00
David Mann 1e82972ee1 Merge pull request #9667 from davidmann4/fix/system-tools-full-path
Windows: run explorer.exe and reg.exe by full path (#9666)
2026-11-06 17:26:45 +01:00
FredApps c8e4376ec6 Merge pull request #11513 from wanikhawar/claude/investigate-issue-e27e90
Windows: count scratch room when opening large files; refusal names the build's limit
2026-11-06 17:26:22 +01:00
David Mann 8b70147d06 Merge pull request #9244 from davidmann4/fix/flip-angle-gradient-sweep
Image Rotation: a flip reverses an Angle gradient fill's sweep (#9243)
2026-11-06 17:26:13 +01:00
David Mann 3768e84b67 Merge pull request #9480 from davidmann4/fix/remove-enable-animations
Interface: remove the Enable animations preference (#9479)
2026-11-06 17:25:38 +01:00
David Mann 89235b39ac Merge pull request #10501 from davidmann4/fix/10328-review-followup
Review follow-up to #10328: Liquify saved twirl, copied type brings its styles, restored tests (#10500)
2026-11-06 17:25:11 +01:00
David Mann 90f6d9aab6 Merge pull request #9300 from davidmann4/fix/trim-subquantum-alpha
Image: Trim (Transparent Pixels) ignores alpha that rounds to 0 at the document's depth (#9299)
2026-11-06 17:23:32 +01:00
2e294450af Find Layers: set the panel filter on every run path; a blank name lists every layer (#11238)
Two review findings on #11238 (#10884):
- `engine.execute` runs `select.findLayers` through `PhotocraftApp::run`, not `menus::invoke`, so
  the Layers panel's Name filter was never set on that path. `run` now applies the reply's filter
  after every Find Layers (menu, shortcut, `engine.execute`, action steps).
- A blank or whitespace `name` replied `selected: []`, while the panel doesn't filter by a blank
  Name and lists every layer. It now lists every layer.

Co-Authored-By: NaufalDzz <NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 16:25:36 +01:00
David Mann f38a7dfecb Merge remote-tracking branch 'origin/main' into pr-11238
# Conflicts:
#	crates/ui-egui/src/panels/layer_filter_ui.rs
#	docs/control-protocol.md
2026-11-06 16:25:36 +01:00
David Mann 2740c5d58f Merge main into fix-transform-several-selection-rules (main c101cbfb7e) 2026-11-06 16:24:54 +01:00
Saloouu 5393bb680e Merge main 2026-11-06 16:19:00 +01:00
David Mann 5a6cd8c6bf Merge pr-11249-fixup: review fixes for #11249 (Gradient Fill Make export and extra layer props) 2026-11-06 15:59:28 +01:00
9d6cdca3fc Actions: a Gradient Fill Make exports with stops, keeps extra layer props (#11249)
Two CodeRabbit findings on #11249:
- A layer.newFillLayer.gradient step with from, to and stops plays the
  stops, but the ATN export refused it. from/to are now left out beside
  stops.
- A recorded Make whose Usng also held a name, opacity, mode or clipping
  loaded as the plain command, which plays none of them and saved back
  without them. It now stays the recorded step.

Each has a test that fails without the fix.

Co-Authored-By: NaufalDzz <90562913+NaufalDzz@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 15:58:57 +01:00
Trevor BrownandClaude Fable 5.1 8b7b161058 Artboard options bar: the background control shows and recolours the selected boards (#11385)
With boards selected the swatch and dropdown show the first board's background, and a choice sets every selected board in one layer.artboard.set step (Edit Artboard / Edit Artboards) and the tool option. layer.artboard.set takes a layers array for this. Also drops the bar_size dead_code allow and adds the placed-board size test.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-11-06 09:58:15 -05:00
David Mann eaddba69bd Merge PR #11249: Actions: load and save Blend If and Gradient Fill layers (#10771) 2026-11-06 15:36:23 +01:00