Preserve the PR's intended behavior and regressions while retaining upstream module extraction and changes. Formatting and independent static review passed.
Local verification: Runtime tests and broader Clippy/WASM/integration gates remain unverified locally because of resource limits.
Local UI verification is incomplete. Hosted CI must establish the remaining gates; this commit does not claim the PR is ready to merge.
Resolve conflicts with the engine's cmd/ module move and the per-crate
integration test binaries. Run a selected VectorCraft.app bundle directly
(identified by bundle id) and reject nested gzip in bounded SVG parsing.
Retry printer enumeration after a busy result and restore the available printer controls without reopening the dialog. Cover opening and drawing the dialog while the spooler is held, then drawing it after release.
Return an empty or unsupported result when the spooler lock is held and no matching cached printer list exists. Preserve the source-specific cache and cover empty and mismatched caches with regression tests.
Merge current main and move the Print dialog changes into its extracted modules.
The feather's ⌈3σ⌉ truncation radius was written out in the blur and again in two engine callers: the windowed marquee and lasso feather (#9794) and the canvas-edge padding of Select › Modify › Feather. selection::feather_reach returns it from the blur's own σ rules, and both callers use it, so a change to the blur's reach can't leave them behind. Output is unchanged; a test pins that the feather leaves everything past its reach at zero.
Resolves the move of crates/engine/src/selection_cmds.rs to cmd/selection_cmds.rs: the two hunks apply at the new path, and modify_window.rs with its tests moves under cmd/selection_cmds/.
Port selected-colour editing through main d42f9da94 and its engine/UI
module layout. Preserve native channel targets, drawing previews, tone
editors and filter behavior in the split modules, with their existing
regressions and public facade exports.
Upstream split smart_cmds.rs into smart_cmds/ and smart_map.rs into
smart_map/: the stored-mesh hook moves to smart_cmds/rendering.rs, the
Puppet Warp import and export arms to smart_map/import.rs and export.rs.
main split atn_cmds.rs into submodules: the Camera Raw Filter mapping moves to
cmd/atn_cmds/steps_image.rs and its event to events.rs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Type Path branch in edit_path caught every `"name":"layer"` edit of a
type-on-a-path layer, including edits of its targeted vector mask: Direct
Selection showed the mask, but a drag moved the Type Path by the mask's
knot indices and left the mask as it was. On main the same command edits
the mask, and path.info / path.get / path.transform still read the mask.
`"name":"layer"` now keeps that meaning: it edits the vector mask when
the layer has one, and the Type Path only when it has none or with
`"typePath": true`, which Direct Selection sends for the Type Path
(PathRef::TypePath). path.list reports the Type Path under its own
`typePath` key, so `layerPath` still names the vector mask, and an edited
Type Path keeps the knot cap type.attachToPath enforces. Both points were
found by CodeRabbit.
The canvas also draws the Type Path with the other tools, as it does a
shape's path: the Pen's Auto Add/Delete edits it, and before this a Pen
click on the baseline added or deleted anchors the user couldn't see.
Co-authored-by: DuBearte <130190089+DuBearte@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
zlib-rs maps level 1 to deflate_quick, which writes static Huffman blocks
only, so every Compression::fast() caller (PDF export and print, brush
presets, PNG Fast) wrote 5-32% bigger streams than miniz's level 1 did.
Level 3 is the lowest level that is never bigger than miniz level 1 on the
docs/images photos, raw and Up-filtered (level 2 was +0.9% on one); it is
0-16% smaller and takes 1.2-3.4 times as long. The new test exports a
noisy-gradient RGB document as PDF and checks the image stream against
miniz level 1 of the same samples: 603007 vs 547315 bytes with fast(),
passes with level 3. The PR's doc no longer says the levels are unchanged.
Main moved the io integration tests into crates/io/tests/it/, so the new
deflate_compatibility.rs moves there and uses crate::common.
Co-authored-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Served fonts chose the layers to redraw from the open document only, so the
first History snapshot was refreshed only for layers the open document still
had, and with the open layer's "shows our own layout" verdict. A type layer
deleted since the document opened kept its fallback-font pixels in the
snapshot, and a PSD layer edited since lost the file's pixels there.
`served_fonts::pick` now checks the snapshot (when it no longer is the open
document) on its own, and `Session::refresh_type_layers` takes
`TypeLayerRef`s that say which version each layer was picked in.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- External vector editing on macOS: discover VectorCraft.app in /Applications and
~/Applications, offer Illustrator when an Adobe Illustrator*.app is found, and accept a
chosen .app under Other application. CFBundleExecutable is read from a bounded Info.plist
(XML or binary, streamed with a nesting cap) and must resolve inside Contents/MacOS;
chosen bundles open with /usr/bin/open -a. vectorcraft-cli is looked for in the same
bundle, then in known installs. Logic is compiled and unit-tested on every Unix.
- Windows "not found" errors name the dialog's "Other application" option.
- Native preview hash verification is remembered per source allocation in a 32-entry
Weak-keyed LRU (no strong references, no reusable stale addresses, lock not held
while hashing), so refreshes and warp frames hash a shared source once.
- source_box uses the new io::svg::bounded_canvas_bounds for SVG without Stack Mode, so
warp setup gets a frame for drawings whose editable layer caches exceed the budget.
Stack Mode and Edit Contents stay strict. Exact 24,000,000-pixel boundary tested.
- Document every non-test function this PR adds; describe macOS behaviour in
docs/embedded-vector-editing.md.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The i18n coverage scan and prefs_usage stopped reading a file at its first `#[cfg(test)] mod`. A split parent declares `#[cfg(test)] mod tests;` before the rest of its code, so the scans skipped that code, and on main an inline test module in the middle of panels.rs hid the code after it. Both now drop only the body of an inline test module.
The prefs audits in scorecard and prefs_usage count a read when the section and the field appear in the same file. Both now also treat a split module (`foo.rs` with `foo/`) as one file, and prefs_usage leaves out `engine/src/prefs/` as scorecard already does, since that directory now holds the rest of the prefs model.
On main and on this branch: the i18n coverage report is identical (2,142 source keys; the old scan found 2,049 on main), `cargo xtask scorecard --check` is up to date, and prefs_usage passes.
The spooling tests rerun themselves in a child process with an exact test-name filter. print_cmds moved under cmd/, so the filters name cmd::print_cmds::tests::…; with the old names the child ran no tests.