Commit Graph
3891 Commits
Author SHA1 Message Date
yoriswind 027b2cdd3c Cover normal Paste followed by Paste As after an internal copy 2026-11-01 11:43:45 -08:00
yoriswind a78b1f1bf8 Keep command-option dependencies limited to style scaling and profile intent 2026-11-01 11:33:53 -08:00
yoriswind 33ee38b431 Merge main and preserve the Render gap update 2026-11-01 10:22:26 -08:00
RickiNanoandClaude Opus 5.5 b800c40cfd Don't auto-select off-canvas layers from the pasteboard (#10665)
A Move-tool click on the pasteboard with Auto-Select only cleared the layer
selection (#4991) when nothing was hit there, but `layers_hit` was not clipped
to the canvas: fill layers and pixels hanging past the edge were hit on the
pasteboard, so the click selected a layer that isn't drawn there instead.

Outside the canvas of a document without artboards, nothing is hit now, and
the layer marquee is clipped to the canvas the same way. Artboard documents
keep picking over the pasteboard, where they draw their layers (#5712).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 19:17:45 +01:00
yoriswind 363caa53c3 Check pixel orientation after relative rotation 2026-11-01 10:07:36 -08:00
yoriswind 7e0bf9ab6c Merge main and retain both gap log updates 2026-11-01 10:04:57 -08:00
yoriswind 53f3ef7c41 Record the default resampler for point-sized actions 2026-11-01 09:57:05 -08:00
yoriswind 46fb7822c9 Support source-backed SVG Paste modes and ATN classes
Retain bounded original SVG alongside its raster mirror. Explicit Pixels,
Path and Shape modes use real source data, validate destination and workload
limits before editing, and preserve legacy Paste when the mode is omitted.
Round-trip typed Photoshop Paste classes and keep unsupported descriptors.

Adapted-from: Skyfuller1303's PR #3409
Original-commit: 897f200727
Original-source: https://github.com/storytold/photocraft/pull/3409

Validation: engine check --tests; strict lib and vector target Clippy;
7 focused native/ATN tests; owned-file formatting and diff checks.
2026-11-01 09:35:13 -08:00
yoriswind c345eef785 Validate ATN sizing and opacity and honor transform anchors 2026-11-01 09:34:25 -08:00
yoriswind d3392e6124 Honor fill rotation and style paste group eligibility 2026-11-01 09:09:00 -08:00
5f63b3fe4c Integration: address CodeRabbit review of batch 11
- #8714: a Camera Raw Filter step imports only with a process version
  the PSD mapping has verified (PrVN/PrVe 5/184549376 or 6/251920384)
  and a CrVe text; other steps stay kept steps that save back unchanged.
- #7642: the patternName fallback matches names only, so a pattern
  whose id equals that text no longer wins. A step that names its
  pattern only by patternName exports that name.
- #8327: the iso-2022-jp label is refused (its names are 7-bit escape
  sequences that would pass through as ASCII).
- #10417: the Levels export gate also refuses endpoints of the wrong
  shape (both ends text, a text gamma) and channels that aren't objects.
- #10459: a set paused at a step dialog keeps the rest of the set by
  action name, so actions.move while the dialog is open neither plays a
  foreign action nor skips one; "Played N steps" covers the whole Play
  (steps before the pause and the dialog's own step); the suggested .atn
  name is cut to 255 bytes at a character boundary; actions.list returns
  every set, empty ones too; set_names dedups with a HashSet.

Co-authored-by: FinnNk <1424666+FinnNk@users.noreply.github.com>
Co-authored-by: Silvertree2010 <133535268+Silvertree2010@users.noreply.github.com>
Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-authored-by: marshiyar <57055687+marshiyar@users.noreply.github.com>
Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 17:51:02 +01:00
yoriswindandbommerts bfe096a988 Preserve named Vibrance exports and adjustment creation opacity
Port the relevant changes from @bommerts in PR #8659:
c4d5c63259,
9f0ae2e43f,
35d1102540 and
668f006ef8.

Keep current mask handling and layer placement. Separate layer opacity from
adjustment settings so a default Gradient Map still saves as a default preset.

Co-authored-by: bommerts <44821497+bommerts@users.noreply.github.com>
2026-11-01 08:11:10 -08:00
yoriswind c2c5b5c30f Cover Vibrance and adjustment opacity action round trips
Vibrance playback coverage adapted from bommerts' PR #8659, commit c4d5c63259. Add the reported Gradient Map opacity case, metadata-only defaults, and atomic validation controls.
2026-11-01 08:09:11 -08:00
yoriswind ab0b26a9c6 Wire profile action options and dither 8-bit conversions 2026-11-01 07:46:48 -08:00
yoriswind f64e3b39f2 Update Image Size import expectation for explicit style scaling 2026-11-01 07:38:01 -08:00
yoriswind 23f1b8bce7 Revert "Add optional layer-style scaling to Image Size"
This reverts commit d7bce26deb.
2026-11-01 07:15:45 -08:00
yoriswind 947d4fd1b0 Revert "Preserve Image Size style scaling through ATN actions"
This reverts commit de9c5e743e.
2026-11-01 07:15:45 -08:00
yoriswind 91fd170570 Resolve recorded ATN dimensions at playback and write mode classes 2026-11-01 07:15:34 -08:00
yoriswind 69e93b8ca1 Add native profile flatten and placed-rasterization options 2026-11-01 07:05:52 -08:00
yoriswind 84a84851cb Cover recorded canvas percentages, point sizes and mode flags 2026-11-01 07:04:05 -08:00
yoriswind c56822347b Preserve Image Size style scaling through ATN actions 2026-11-01 06:59:02 -08:00
yoriswind db1fb662a8 Add optional layer-style scaling to Image Size 2026-11-01 06:59:02 -08:00
David MannandClaude Opus 5.5 4614b3e119 Integration: build two ATN test files with defaults (#8714, #8858, #8327)
#8327 adds `AtnFile::encoding`. Two tests from other PRs in the batch
build an AtnFile literal without it (#8714 fix-up's Camera Raw save-back
test, #8858's Vibrance string-class test), so the engine's lib tests
didn't compile on the batch. They now fill the rest with
`..Default::default()`, as the other literals in the file do.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:46:37 +01:00
midasdf 52d4292624 Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	docs/target-app-parity.md
2026-11-01 23:42:30 +09:00
yoriswind 775dc0c070 Keep document lifecycle tests consistent with wrapped offsets 2026-11-01 06:39:03 -08:00
yoriswind ca60678754 Describe CAF action conversion and regression witnesses 2026-11-01 06:37:14 -08:00
David Mann bb8edaf596 Merge PR #8327: Actions: read .atn step names in the code page Photoshop wrote them in (#6743)
# Conflicts:
#	contributors/people.toml
#	crates/engine/src/cmd/atn_cmds/tests.rs
2026-11-01 15:36:45 +01:00
yoriswind 376949a6f3 Preserve Content-Aware Fill options in ATN actions 2026-11-01 06:34:22 -08:00
yoriswind abb28e4d37 Correct mapped ATN identifiers and wrap document offsets 2026-11-01 06:24:58 -08:00
yoriswind da496ec03f Document Content-Aware Fill adaptation helpers 2026-11-01 06:23:16 -08:00
David Mann 6aba9ddfd8 Merge PR #10459: Actions panel: New Set, and New Action records into the selected set (#7535)
# Conflicts:
#	crates/engine/src/cmd/atn_cmds/tests.rs
2026-11-01 15:13:27 +01:00
yoriswind 4875f94ebb Expose Content-Aware Fill scale and mirror options 2026-11-01 06:13:03 -08:00
yoriswind de9c5e743e Preserve Image Size style scaling through ATN actions 2026-11-01 06:13:02 -08:00
yoriswind d7bce26deb Add optional layer-style scaling to Image Size 2026-11-01 06:13:00 -08:00
1d0bc23c3e Integration: don't count symbols on Mac Roman letters as windows-1252 (#8327)
The previous fix-up counted § ® ¾ ¿ (and ¹ » ¼ ½) as common windows-1252
text, but those bytes are Mac Roman ß Æ æ ø (π ª º Ω). Mac names with no
Unicode copy such as "Weiß", "Gaußscher Weichzeichner", "Størrelse",
"Lærredstørrelse" and "Æble" then tied and read as windows-1252 ("Wei§",
"St¿rrelse"), where the PR read them right.

Keep only the 12 symbols whose byte is not a letter in Mac Roman
(¡ ¢ £ ¥ © « ° ± ² ³ ¶ ·). Windows "Größe »", "50 °" and "« auto »" still
read as windows-1252; a name whose only non-ASCII character is ® ("Logo
®") reads as Mac Roman "Logo Æ" again, as on the PR head (tested as a
known limitation).

Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 15:00:36 +01:00
yoriswind 04cf63f68c Preserve recorded ATN settings across load and save 2026-11-01 05:58:42 -08:00
aiongg 84732d09bc Merge pull request #9618 from RickiNano/prefs/gpu-adapter-typed-read
Prefs: startup reads Graphics Adapter through the typed Performance section
2026-11-01 08:56:16 -05:00
aiongg dbe24c7e92 Merge pull request #10658 from RickiNano/fix/10640-preset-group-reimport
Ask before re-importing a brush or gradient file over its group (#10640)
2026-11-01 08:55:56 -05:00
midasdf d1a02c7f2f Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	docs/target-app-parity.md
2026-11-01 22:50:04 +09:00
af59f65b82 Integration: keep windows-1252 symbols in .atn step names (#8327)
The code-page guess counted only letters and typographic marks as common
text in single-byte pages, so a Windows step name with no Unicode copy and
a Latin-1 symbol read better as Mac Roman, whose letters sit on those
bytes: "Logo ®" showed as "Logo Æ", "Größe »" as "Grˆfle ª" (main showed
them right), and Save Actions wrote that text back.

When the guess lands on Mac Roman, weigh it against windows-1252 once more
with common Latin-1 symbols (© ® ° § « » ± ½ …) counted and the letters
windows-1252 has only at 0x80-0x9F left out. Mac Roman keeps the names
only when it still reads better; a tie goes to windows-1252, confident
with a Latin hint and flagged uncertain otherwise. Mac Roman "Größe",
"Ändern", "Contrôle", "Arrière-plan" and the corpus French sets still read
as Mac Roman.

Co-authored-by: regexer <3689390+regexer@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:43:03 +01:00
David Mann acddb90d47 Merge PR #8736: Refuse exporting an adjustment edit that names its layer to .atn
Conflict: main moved crates/engine/src/atn_cmds.rs into crates/engine/src/cmd/atn_cmds/; the refusal is ported into steps_make.rs set_to's layer.setAdjustment arm unchanged. The tests followed the rename.
2026-11-01 14:41:56 +01:00
David Mann f2fd6efdc0 Merge PR #7642: Prefer an installed pattern ID over a colliding name in ATN import 2026-11-01 14:41:19 +01:00
David Mann 2c0ad3fc34 Merge PR #8714: feat(actions): import recorded Camera Raw Filter steps as filter.cameraRaw 2026-11-01 14:41:16 +01:00
David Mann 1b308ca411 Merge PR #8858: fix(atn): import Photoshop's string class for Vibrance adjustment Sets 2026-11-01 14:41:14 +01:00
David Mann fa69a54f74 Merge PR #10424: ATN export: Stroke steps write the settings they leave at default (#8303) 2026-11-01 14:41:09 +01:00
David Mann 53aa1a4a2c Merge PR #10417: fix(engine): refuse strict .atn export of a partial Levels edit (#8530) 2026-11-01 14:41:06 +01:00
adc4e45fe7 Integration: look up a recorded pattern id by id alone before the name (#7642)
`resolve_or_named` resolved the recorded `Idnt` with `resolve`, which also
matches by name in each collection. So a document pattern named like the
id beat the library pattern with that id, and a foreign id equal to some
pattern's name (`Idnt "Red"`, `Nm "Blue"`) played "Red" and never tried
the recorded name. The id is now looked up by id only (document, then
library), then the name decides. A library pattern found by id whose
pixels can't be read reports that instead of falling back, main's
paintable check still runs, and a pattern installed neither way is named
in the error (`no pattern "My Wood" (id "...")`) instead of only its UUID.

Co-authored-by: Silvertree2010 <133535268+Silvertree2010@users.noreply.github.com>
Co-authored-by: FredApps <153173854+FredApps@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:36:29 +01:00
68b869eac4 Integration: save Vibrance adjustment steps with the string class vibrance (#8858)
Vibrance's adjustment class is now Photoshop's string id `vibrance`, so Set and Make steps
save back with the class Photoshop runs instead of the `Vbrn` code it refuses (#8383).
`Vbrn` moves to LEGACY_CLASSES, so actions saved before still load. A recorded Vibrance
with non-zero temperature or tint stays a kept step and saves back unchanged.

Co-authored-by: jturnbach <70334515+jturnbach@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:34:17 +01:00
4d2fd2214d Integration: Camera Raw Filter steps save back and refuse unknown keys (#8714)
A loaded Camera Raw Filter step became an import-only filter.cameraRaw, so
Save Actions dropped it (skipUnsupported) or failed, where before it was
written back byte for byte. Keys outside the table (e.g. PerV = 20, a
profile name) were ignored, so the step replayed a different look without
being reported.

The step now keeps its recorded descriptor in a hidden param and saves back
as that descriptor while its params are still what it imports as; edited or
PhotoCraft-recorded steps are still refused. A step with any unknown key, or
with no settings, stays a kept Photoshop step, as the PSD mapping does.

Co-authored-by: FinnNk <1424666+FinnNk@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-01 14:31:13 +01:00
David Mann d86f678325 Merge main into #8327 2026-11-01 14:27:37 +01:00