Commit Graph
3891 Commits
Author SHA1 Message Date
David Mann 4f6a2c50f0 Merge #4579: the author's latest commits
# Conflicts:
#	docs/gaps.md
#	docs/target-app-parity.md
2026-11-03 01:05:27 +01:00
David MannandClaude Opus 5.5 6a63960ec6 Batch 13: settle the overlaps between the batched PRs
- Check Spelling: with #8726's measured form a `change` made in the dialog records no step
  (the reference application records one `spellCheck` step), so #4514's two tests that
  expected recorded `change` steps are removed; its portable recording stays for all else.
- Clippy `chunks_exact_to_as_chunks` in #10765's tests; a single-element loop in #10755's.
- docs/parity-checklist.md and docs/scorecard.md regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 01:04:44 +01:00
David MannandClaude Opus 5.5 072dfd3724 Batch 13: rustfmt the resolved files
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 00:51:18 +01:00
David MannandClaude Opus 5.5 55a8d917de Batch 13: #10755 and #10765 on top of batch 12
- Link Layers keeps main's measured toggle mapping (batch 12, #10628): played twice in the
  reference application it links, then unlinks. #10755's second, explicit `linked: true`
  entry for the same event was unreachable on import and contradicted that measurement, so
  it is dropped; Unlink stays explicit. Its tests now cover Unlink only, and `{}` exports.
- #10765: an ordinary Gradient Map now saves as `gradientMapEvent` (#10702 landed in batch 12).
- #10755: flattened pixels read with `Buffer::into_px()` since `Buffer` implements `Drop`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 00:50:41 +01:00
David Mann eb3c2044d4 Merge #10755: Support newer recorded Action events
# Conflicts:
#	crates/engine/src/cmd/artboard_cmds.rs
#	crates/engine/src/cmd/atn_cmds.rs
#	crates/engine/src/cmd/atn_cmds/events.rs
#	crates/engine/src/cmd/atn_cmds/steps_make.rs
#	crates/engine/tests/it/main.rs
#	docs/atn.md
#	docs/development.md
#	docs/file-format-parity.md
2026-11-03 00:44:15 +01:00
David Mann b0aa230ae8 Merge #10765: Actions: support direct Gradient Map and Lab-range Replace Color
# Conflicts:
#	crates/engine/src/cmd/atn_cmds.rs
#	crates/engine/src/cmd/atn_cmds/events.rs
#	crates/engine/tests/it/main.rs
#	docs/atn.md
#	docs/development.md
#	docs/file-format-parity.md
2026-11-03 00:38:44 +01:00
Fabio Lissi a2c4ac0b0c Match Batch Esc flow and show read-only input preview 2026-11-02 17:36:55 -06:00
David Mann 2915849b07 Merge #4514: Record actions in a document-independent form (#219) [depends on #4496]
# Conflicts:
#	crates/engine/src/cmd/type_spell_cmds.rs
#	crates/engine/src/jobs.rs
#	docs/gaps.md
#	docs/target-app-parity.md
2026-11-03 00:36:40 +01:00
David Mann 98c2213e5c Merge #9211: Layers panel: the filter row lists linked, missing or embedded smart objects
# Conflicts:
#	crates/automation/src/server.rs
#	crates/ui-egui/src/control/tests.rs
#	crates/ui-egui/src/panels/layer_filter_ui.rs
#	crates/ui-egui/src/panels/layer_filter_ui/tests.rs
#	docs/control-protocol.md
#	docs/ui-parity.md
2026-11-03 00:34:07 +01:00
ljkx c0b08120a6 Reveal All's crop passes the session gate; Crop doc names the Content-Aware exception (#10867)
Reveal All runs its crop through crop_keeping_background instead of
Session::execute, so the session's authorize gate no longer saw the
image.crop it runs on its behalf. It now calls the gate with the crop's
params before the crop, as dispatch would.

The image.crop params doc now says the Background becomes Layer 0 with
Delete Cropped Pixels off only when contentAware is false.

Tests: the action-step case now goes through a binary .atn (the Crop
descriptor carries Dlt false, import decodes it, actions.play runs it);
new tests for the Reveal All gate and for Content-Aware with Delete off
keeping the Background.
2026-11-03 00:32:25 +01:00
David Mann 29474646f4 Merge #4579: Batch: subfolders, open documents, file naming, stop on error, error log, progress and cancel (#219) 2026-11-03 00:30:53 +01:00
David Mann 222ba50635 Merge #5430: Actions: a recorded Save As or Save for Web with the suggested name saves each document under its own (#5305) 2026-11-03 00:30:52 +01:00
David Mann 7c17521aad Merge #8726: Actions: Check Spelling records and saves as the spellCheck event 2026-11-03 00:30:51 +01:00
David Mann b8bcc02cdb Merge #10905: Crop with Delete Cropped Pixels off turns the Background into Layer 0 (#10867) 2026-11-03 00:30:48 +01:00
yoriswind 6182b5b0d2 fix: preserve TIFF channels omitted by decoder limits 2026-11-02 15:28:15 -08:00
FredApps 51e9bed8b7 Borrow guarded tile bytes in the profile dither from main
Main's new profile dither (8a0f959d2) matched on the tile bytes by value inside the
per-pixel loop. On this branch Tile::bytes returns a TileBytes guard rather than a
slice, so borrow it for the loop instead, and compare the test's tiles as owned
bytes since the guard has no Debug or PartialEq.
2026-11-03 00:13:34 +01:00
FredApps fb684cd114 Merge remote-tracking branch 'upstream/main' into pr-5330 2026-11-03 00:02:18 +01:00
yoriswind c3f61de9d4 test: use the current TIFF fixture alignment idiom 2026-11-02 14:53:53 -08:00
yoriswind faed6b4fb5 fix: capture action dependencies inside explicit Batch steps 2026-11-02 14:46:19 -08:00
vangel76andClaude Sonnet 5.5 439e029b19 Render Video: say what the GIF staging cap does and does not bound (#6103)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-02 23:44:40 +01:00
Fabio Lissi bc48f31da0 Allow ATN group-end select no-op through admission 2026-11-02 16:43:52 -06:00
yoriswind ea6a120b7d fix: retain ambiguous Custom kernel descriptors 2026-11-02 14:40:00 -08:00
yoriswind 84d6bd7572 fix: retain group canvas transparency after ATN integration 2026-11-02 14:36:08 -08:00
vangel76andClaude Sonnet 5.5 f4adb8fb9b Render Video: cap the total an animated GIF keeps staged (#6103)
The GIF branch checked one frame against MAX_GIF_FRAME_PIXELS but kept every
encoded frame until the file was written, so frames x pixels was unbounded: a
4000 x 4000 canvas on a long timeline staged terabytes. Check the total
(one index byte per pixel plus the palette, 2 GiB like imported footage) and
the 16-bit GIF side before the first frame is rendered, with checked u64
arithmetic and an error that names the limit.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-02 23:36:03 +01:00
yoriswind 47d8af320c fix: preserve FITS payloads and separate TIFF masks in Batch 2026-11-02 14:34:01 -08:00
dotCooCoo 9e718d7793 Actions: Check Spelling playback keeps to its document and its corrections run
- A loaded spellCheck step reads null and Usng by name, in either order.
- A correction step (action set) with its dialog on runs without opening
  the Check Spelling dialog.
- Done continues a waiting action only on the document it was playing on;
  on another document the action ends there and the status says why.
- When recording the step fails at Done, the status keeps that error next
  to the playback's outcome.
2026-11-02 14:10:42 -08:00
yoriswind 91c94b025e test: isolate file command fixtures with repeated labels 2026-11-02 14:05:28 -08:00
Fabio Lissi 95a7d211c2 Correct Batch command naming and folder docs 2026-11-02 15:59:20 -06:00
Fabio Lissi 0306fafb9b Preserve active spelling layer in recorded actions 2026-11-02 15:58:29 -06:00
dotCooCoo 9817a88779 Merge main into fix/spelling-change-keeps-its-layer-when-recorded 2026-11-02 13:41:01 -08:00
yoriswind 3b22f79b80 fix: preserve Batch references and multi-image sources 2026-11-02 13:40:23 -08:00
Daktyl198andClaude Opus 5.5 399282c41e Merge main into the #5305 fix, and bring it to the new layout
Main moved the Save As, Save for Web and .atn code (cmd/atn_cmds,
cmd/web_cmds, app/files.rs, dialogs/) and added DDS and JPEG Options
prompts, so the fix is applied again there:

- Save As with the suggested name records {"folder", "extension"}, also
  when answered in the Targa, DDS or JPEG Options prompt, and a Save of
  the document's own file is still journaled as File > Save.
- A loaded "save in directory" (DIDr) Save As imports as that folder step
  and exports back with DIDr, instead of staying a kept step; a copy into
  a folder stays kept.
- Playing it on two documents writes one file for each, under its name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 21:32:49 +00:00
FredApps 9eddf1d8ca Pause and retry a failed or full scratch disk instead of turning spilling off
A scratch write or create failure, or a volume about to drop below max(1 GiB, 5%)
free space, now pauses spilling with exponential backoff (1 s doubling to 60 s)
instead of disabling it for the session. Tiles stay resident, set_budget keeps
the latest budget for the resume, preference changes retry at once, and
spill::epoch lets the engine re-apply History's byte limit while paused.
spill::set_size_cap adds an explicit size limit; free space comes from sysinfo's
disk feature.
2026-11-02 22:31:56 +01:00
FredApps 44f13e5498 Scope scratch read failures to the document that holds the tile
One unreadable tile used to block editing, saving and exporting every open document
(spill::check_integrity was process-global). Add Tile/Surface/Document::scratch_health
(free while no tile has failed) and Document::for_each_surface (ops' history walk now
delegates to it). edit_with checks the document before and after, jobs the document they
captured, import the result, save/export the document written; check_since is now
generation-only so a failure or recovery during an operation refuses it once and a retry
works. Caches check their own sources and purge once per new failure instead of every
frame. Fault-injection tests use a duplicated handle (the Unix file has no name).
2026-11-02 22:23:42 +01:00
FredApps 947038d0db Unlink Unix scratch files right after opening
The spill manager is process-global and never dropped, so the Unix scratch file was only
removed by the next launch's reap. Unlink it immediately after opening and read/write
through the one handle with pread/pwrite (readers can no longer reopen it by path).
Windows keeps delete-on-close and per-thread readers. The abrupt-exit test now asserts
that no file remains on every platform; docs/scratch-disks.md updated.
2026-11-02 22:17:50 +01:00
FredApps b0f3c7516b Merge current main into codex/scratch-storage
Resolve conflicts with main's prefs UI split, session/execute.rs move, GPU memory
budget (gpuMemoryMb, 0 = auto, kept from main) and effective_memory_usage_mb history
budget. Port the Memory Usage % and Scratch Disks preferences into prefs_ui, the edit
integrity guard into session/execute.rs, and adapt main's new pixel readers to the
guarded TileBytes API. Cargo.lock regenerated; scorecard regenerated.
2026-11-02 22:16:22 +01:00
midasdf 7f592772c8 Merge remote-tracking branch 'origin/main' into pr
# Conflicts:
#	ROADMAP.md
2026-11-03 05:52:38 +09:00
Fabio Lissi 499f7ab609 Merge upstream main into action recording 2026-11-02 14:44:32 -06:00
Fabio Lissi 2537b927e0 Merge upstream main into batch automation 2026-11-02 14:38:41 -06:00
yoriswind 3d5a42e3bb Merge current main before Batch review repairs 2026-11-02 12:29:16 -08:00
Khawar Zamman Wani e97480ac76 fix: synchronize test dependencies and repair CI compile diagnostics 2026-11-03 01:31:34 +05:30
Khawar Zamman Wani 5992650b36 fix: address PSD admission review and enable platform memory consent 2026-11-03 01:26:13 +05:30
Fabio Lissi 50670f9d67 fix: preserve active batch edits and cancellation result 2026-11-02 13:54:58 -06:00
yoriswind 003a8a5482 fix: preserve Batch references, source images and script limits 2026-11-02 11:36:42 -08:00
David Mann 673bfb4d9c Merge remote-tracking branch 'origin/main' into integration-batch-12
# Conflicts:
#	docs/file-format-parity.md
2026-11-02 20:15:23 +01:00
Fabio Lissi b22384aab8 Release action snapshot before closed-document scratch buffers 2026-11-02 12:44:46 -06:00
Fabio Lissi d1141d08f8 Merge branch 'main' of https://github.com/storytold/photocraft into feat/actions-record-independent 2026-11-02 12:40:52 -06:00
FredApps 9236d27eb6 Merge current main into fix/gnome-window-decorations 2026-11-02 19:10:43 +01:00
David MannandClaude Opus 5.5 79fee53116 Address CodeRabbit review: the hidden-pixel resample refusal suggests Delete Cropped Pixels only when it would help
Delete Cropped Pixels clips pixel layers, fill caches and video frames only. When a layer mask,
channel, the quick mask, the selection, type, a shape or a smart object holds the hidden pixels
over the budget, the refusal now says so instead of pointing to an option that can't clear it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 19:05:38 +01:00
yoriswind 4649808594 Adapt action test fixtures to pooled render buffers 2026-11-02 09:49:07 -08:00