Commit Graph
1803 Commits
Author SHA1 Message Date
jonathanwxh-cell 963bc8ab4e Merge upstream main into the action document-offset branch
Keep the #7103 opening-order note with main's newer gap status.
2026-10-26 10:06:28 +00:00
jonathanwxh-cell 059940c993 Merge upstream main into the CSH shape import branch
Keep the custom-shape translations and the CSH import notes with main's newer format and gap status.
2026-10-26 09:50:13 +00:00
Khawar Zamman Wani 490396f87e Type font field: ⌘/Ctrl+Enter resolves a pending query like Enter
commit_shortcut skipped the highlighted row and fell back to the first
match, so with the current family highlighted it applied a different
family than the menu showed. Both paths now share accept_row (exact name,
then the highlighted row, then the first). Also remove the blank line
that split the ui-parity revision-history table.
2026-10-26 14:58:33 +05:30
Brennan StehlingandClaude Opus 5.5 f342dba86e xtask perf: a row that failed in any run gets no baseline; judge contention on the load before the build (#7494)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 22:33:56 -07:00
Khawar Zamman Wani 8bbffe7760 Merge origin/main into fix/font-name-editable-9338 2026-10-26 10:22:36 +05:30
Khawar Zamman Wani 56008a682d Merge origin/main into select-mask-workspace 2026-10-26 10:20:37 +05:30
Khawar Zamman Wani 6fc599dea9 Merge origin/main into save-for-web-webp 2026-10-26 10:20:32 +05:30
Khawar Zamman Wani 07549fd6a6 Merge origin/main into pen-path-operations 2026-10-26 10:20:27 +05:30
Khawar Zamman Wani cdc3bdbd2f Merge origin/main into fix/8169-huge-tiff-open 2026-10-26 10:20:12 +05:30
Khawar Zamman Wani 34b6a94b0c Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-26 10:20:08 +05:30
Hector VillarrealandClaude Opus 5.5 a7b412d422 docs: regenerate the scorecard
The gate's scorecard check failed on #9606: the new remembered Color
panel option is one more preference (179). Regenerated with
`cargo xtask scorecard`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 22:03:16 -06:00
Hector VillarrealandClaude Opus 5.5 e2d0965d20 docs: keep the parity history newest first
Rebasing onto main put this PR's history row above main's newer rows
(CodeRabbit flagged the same on #9282).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:43:18 -06:00
Hector VillarrealandClaude Opus 5.5 20803d1f15 docs: keep ui-parity's history newest first
CodeRabbit on #9282 (inline 4373668508): the rebase put this PR's
2026-10-24 row above main's 2026-10-25 rows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 21:42:34 -06:00
Hector VillarrealandClaude Opus 5.5 3183dd4efd docs: the cube modes' gamut alert needs a 53 pt field
CodeRabbit on #9154: the Hue Cube and Brightness Cube draw the ⚠ only when
the chips column is at least 53 pt tall; the slider modes always do. The
ui-parity row, history entry and status line now say so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:26 -06:00
Hector VillarrealandClaude Opus 5.5 2a83a24f2b Color panel: the cube modes warn when a colour can't print (#8672)
Photoshop's Color panel shows the out-of-gamut warning and a chip of the
nearest printable colour under the foreground/background chips in its
Hue Cube, the default mode. PhotoCraft drew it only in the slider modes.
The Hue and Brightness Cube now draw the same alerts (a click takes the
nearest printable colour), when the field is tall enough to hold them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:26 -06:00
Hector VillarrealandClaude Opus 5.5 5a432c2b7e feat(ui): Preset menus for Levels, Exposure, Black & White and Channel Mixer
Fixes #9263, #9265, #9268, #9270. Each of these adjustments gains a
Preset menu at the top of its editor (dialog and Properties), with the
preset names Photoshop uses and Custom once edited; a choice is one edit.

The settings are PhotoCraft's own, designed for each look: Levels
presets lift, lower or stretch the tones; Exposure presets are whole
stops; the Black & White and Channel Mixer "filter" presets follow what a
coloured lens filter does on black-and-white film. None is taken or
measured from another application's presets.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 20:34:19 -06:00
aiongg b078e0e8a6 Panels: review follow-ups to the shared docking and egui 0.37 merges (#9575) 2026-10-25 22:03:26 -04:00
aiongg da02d0ef2d Merge remote-tracking branch 'upstream/main' into docking-adopt
# Conflicts:
#	Cargo.toml
#	crates/ui-egui/Cargo.toml
2026-10-26 00:12:23 +00:00
Brennan Stehling 9010154943 docs: record a perf baseline from several nightly runs (#7494) 2026-10-25 16:04:30 -07:00
Brennan Stehling 43581abc5f perf budgets: judge P25 on p95, keep P16 unenforced (#7494)
P25 broke at 299 ms once on the contended runner (2026-10-18). It now uses
the p95 metric with the same 200 ms budget; with n <= 20 the p95 rank equals
the max, so on the runner (n = 8) this has no effect until reps >= 21.
P16 stays unenforced: the new --from enforce report over the 2026-10-18..25
nightlies lists it as flaky (p95 103.7 ms on 2026-10-18).
2026-10-25 16:04:30 -07:00
Brennan Stehling 6caa8056ce scorecard: label a contended baseline and say where the regression check runs (#7494)
The 2026-10-05 baseline was recorded at load 224.9 on 14 cores; the scorecard now
says so without changing a number, shows the baseline's run count, and replaces
the claim that the nightly checks regressions with the machine class it actually
runs on.
2026-10-25 16:04:30 -07:00
ebosido444-ai 819f2692db Startup: a failed launch says why in a dialog instead of closing silently (#7643)
`main` returns `eframe::run_native`'s error, and a desktop launch has no console —
release builds are GUI-subsystem on Windows, a Dock launch has no terminal on
macOS — so the error went nowhere and PhotoCraft "just closed" (#7643).

The error is now logged, and when nothing else can see it it is also shown in one
native `rfd::MessageDialog` with the renderer that was tried, the GPU-startup
fallback reason, the version and the log file to attach. A terminal launch keeps
printing to standard error, a `--control` launch keeps its exit status and a
headless Linux launch (no DISPLAY, no WAYLAND_DISPLAY) keeps the error on stderr,
so none of them gets a modal dialog.

`AppLogger` remembers the file `attach_dir` opened (`path()`): the logger only
held the `File`, and the dialog has to name the file a reporter should attach.
2026-10-26 00:40:55 +03:00
David MannandClaude Opus 5.5 8aa8e4f0cb Integration: docs status lines follow the revision history
brush-parity.md, gaps.md and ui-parity.md had 2026-10-25 revision rows
under a 2026-10-23/24 "Last updated" header; the headers now carry the
latest row. gaps.md (24 of 171), ui-parity.md and target-app-parity.md
(46 of 149) quoted stale counts of preferences that do nothing; they now
quote the scorecard's 12 of 178. target-app-parity.md still listed the
Camera Raw Calibration panel as missing, which landed on 2026-10-13
(#5128); the row now names per-camera colour for non-DNG cameras, as
gaps.md G14 does.

Found by CodeRabbit on #9386.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 21:56:01 +01:00
David MannandClaude Opus 5.5 8812fe1e73 Merge main (egui 0.37, #9363)
Conflicts: the batch's wheel reads (#5547 Animated Zoom) keep their extra
argument with main's ids (`Id::unique`, `ui.scope_id()`); crop presets keep
#6620's `apply_choice` with main's accessible name; Bevel & Emboss keeps
#9370's per-mode id with main's name argument; the Stroke field keeps
#7203's gradients with main's name; tone.rs keeps #9139's move of the
Histogram panel to histogram_panel.rs (main only renamed ids there);
translation catalogs as unions.

Not flagged by git, the batch's new code follows egui 0.37 too: dropdowns
take an accessible name (Histogram Channel/Source #9139, tool Mode #5504,
Art History Style #1610, New Snapshot From #3567), MouseWheel events carry
`source`, `WidgetType` is `Role` (ColorButton is ColorWell, #7203),
`Id::new`/`Ui::id` are `Id::unique`/`Ui::scope_id`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 20:53:11 +01:00
skylartaylor 6f6e0d1793 Reconcile migration review fixes with published PhotoCraft changes 2026-10-25 20:07:13 +01:00
5c9192bbe2 Migrate PhotoCraft to egui 0.37 (#9363)
* egui037: name each control for what it sets, and order the eager fonts for the UI

CodeRabbit review follow-ups on the migration: the Artboard X/Y fields, the CAF
dropdowns, the channel Solidity field, the GPU backend/adapter dropdowns, the
corner radius fields and the canvas extension colour all had an accessible name
that named another control (or was shared by four). The eager craft-fonts
registration now puts the UI Japanese face first, as the lazy loader does, so
Japanese UI is not drawn in the manifest's Mincho face and shared Han characters
do not take Japanese forms.

Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>

* egui037: rustfmt the eager craft-font order

---------

Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
Co-authored-by: Codebuff <noreply@codebuff.com>
2026-10-25 15:04:35 -04:00
aiongg c580637749 Merge remote-tracking branch 'upstream/egui037' into docking-adopt
# Conflicts:
#	crates/ui-egui/src/layer_props_ui.rs
2026-10-25 18:49:13 +00:00
Dylan M. Taylor b1f73ab821 Merge origin/main into the egui 0.37 migration
Reconcile 39 upstream commits: keep main's off-menu gallery zoom, folder-field
picker and Transform edit tolerance while keeping the migration's accessible
names, and use Id::unique for the ids main added.

The Windows legs build with the suite's craft-fonts input: the runner has no
Japanese or Simplified Chinese system font, and egui 0.37 panics on a missing
glyph, which failed the localized UI tests. The background-redraw test now
holds the worker after its first batch, so an edit during a redraw cannot lose
the race on a fast machine.

Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
2026-10-25 14:33:46 -04:00
David Mann 6c35275a30 Merge PR #9197: fix(ui): the font menu opens on the current family's recent row (#9160)
# Conflicts:
#	docs/ui-parity.md
2026-10-25 18:55:13 +01:00
Vlad Grankovsky 1cec8bce81 Record native preview benchmarks and review evidence 2026-10-25 18:54:49 +01:00
aiongg 292f869d8a Merge remote-tracking branch 'upstream/egui037' into docking-adopt
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	crates/ui-egui/src/gallery_ui.rs
#	crates/ui-egui/src/layer_props_ui.rs
#	crates/ui-egui/src/lib.rs
#	crates/ui-egui/src/panel_docking.rs
#	crates/ui-egui/src/panel_docking_tests.rs
#	crates/ui-egui/src/view_cmds.rs
#	crates/ui-egui/tests/it/batch_export_options.rs
2026-10-25 17:51:11 +00:00
10e20c4751 Integration: the font menu scrolls to the marked row, and a missing font doesn't jump the list later (#9197)
- The open scroll brings the marked row itself into view, keeping the recent
  group's top in view when the row fits below it: with Font Preview Size Huge
  and 10 recents, recent #8 opened below the fold.
- The open scroll is armed for the first laid-out pass only, whether or not a
  row matched: with a missing font or a mixed selection the scrolled list
  jumped later, once the font loaded or the selection settled.

Co-authored-by: hectorviov <1501713+hectorviov@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 18:00:52 +01:00
skylar taylor-barrick 8fdcda5ecc M0: reconcile current PhotoCraft main with egui 0.37 2026-10-25 17:38:12 +01:00
Erica Franco 938542c78b Security: pin and verify the Windows signing client (#2936) (#3938)
sign.ps1 downloaded Microsoft.Trusted.Signing.Client from the unversioned
NuGet URL and loaded its dlib into signtool, next to the Azure signing
secrets, with no version or integrity check.

Download a pinned version (1.0.95, which the unversioned URL serves today)
and refuse it unless its SHA-256 matches, so upgrading the client is a
deliberate change in the repository. The release docs say where the pin
lives.
2026-10-25 12:32:10 -04:00
VladimirPozdnyakov fe65585ddc The overflow flag reads as no-session, and the port tooltip stops painting on a resting pointer
CodeRabbit round-4 on the merge: an ui.inspect running between the frame
that ended the edit and the one that resets ui.type_box_overflow could
report typeBoxOverflow: true beside a null textEdit — the snapshot field
now reads false whenever the edit session is over
(inspect_gates_the_overflow_flag_on_the_session). The tooltip's
unconditional request_repaint per frame is gone: a resting pointer must
not redraw, and a pointer movement brings its own frame to hide the
card; the stale 'tooltip follows the pointer' comment is replaced with
the real contract.
2026-10-25 19:29:25 +03:00
aiongg e3f242af38 Merge remote-tracking branch 'upstream/main' into docking-adopt 2026-10-25 16:25:21 +00:00
VladimirPozdnyakov 516580ee07 The merge-back takes the edge tip only: two clusters, once per row, and leaves a justified paragraph's last line alone
davidmann4's round-3 review of #8347: a marks row the box had to split
out of a run folded row after row into one line running past the edge by
almost the whole run, and a row merged into a justified paragraph's last
line kept the row above's spread instead of the last-line align.

- A marks-only row steps back only while it is at most two clusters (the
  tip that hangs at the edge); a row above that already ends in a
  hangable mark takes no more.
- A justified paragraph's last row keeps its own align (centered, right
  or left): the placed clusters already carry the spread, and the merge
  only moves x1/range.end.
- hanging_marks_of_a_split_run_keep_their_breaks pins that a run keeps
  its rows and no line outgrows the box by more than two marks;
  hanging_marks_stay_off_a_justified_paragraphs_last_line pins the
  JustifyCenter/Right/All last lines. The old merged-row test now pins
  the tip (a_stepped_mark_row_keeps_its_clusters_and_glyphs_in_step).
2026-10-25 19:10:26 +03:00
Khawar Zamman Wani 08909ac143 Merge origin/main into save-for-web-webp 2026-10-25 21:25:58 +05:30
Khawar Zamman Wani 18b32f1202 Merge origin/main into pen-path-operations 2026-10-25 21:25:26 +05:30
Khawar Zamman Wani 96f0a5c6d6 Merge origin/main into fix/6501-multi-layer-free-transform 2026-10-25 21:25:00 +05:30
David MannandClaude Opus 5.5 ac7de75007 Integration: scorecard regenerated without #4573
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-25 16:36:23 +01:00
Vlad Grankovsky a37d21de7e Merge origin/main into codex/multi-channel-editing 2026-10-25 16:30:23 +01:00
David MannandClaude Opus 5.5 38609e5615 Merge PR #8885: PSD: spot channels in Photoshop's polarity; PSDs from earlier PhotoCraft versions keep their ink
Merged with our fix-up branch pr-8885-fixup (8f6863f53) on the author's head 996b55eb4.

Conflicts resolved:
- crates/io/src/tiff_layers.rs: #9148's tiff_source (an empty LMsk gets Photoshop's 14 bytes)
  gives way to #8885's tiff_image_source, which writes the same bytes for an empty or short
  LMsk; #9148's test stays.
- crates/io/src/flat.rs: #8776's DDS alpha step and #8885's TIFF channel stamp both run.
- crates/io/Cargo.toml, Cargo.lock: #8402's zune dev-deps and #8885's tiff dev-dep.
- crates/io/tests/it/tiff_layers.rs, docs: unions; docs/scorecard.md kept as is, regenerated at
  the batch gate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 16:28:00 +01:00
VladimirPozdnyakov 8e145860c6 Merge upstream/main into qol-type-overflow 2026-10-25 18:26:49 +03:00
David MannandClaude Opus 5.5 14693eb085 Integration: merge main 528491f9a, resolve conflicts
- crates/engine/src/edit_cmds.rs: copy_mask keeps #3297's filter-mask target and takes main's
  clipboard `source` (#8945).
- crates/cms/src/lutfile.rs: #9183's shaper doc comment next to main's UTF-16 decode_text (#9129).
- contributors/people.toml, docs: unions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 16:26:06 +01:00
8f6863f536 Integration: a kept 1053 doesn't hide an earlier PhotoCraft's spot ink (#8885)
Earlier PhotoCraft versions kept the 1053 of a Photoshop file they opened
and wrote it back unchanged, while storing spot channels added there
straight. A transparent Photoshop document carries 1053 = [0], so a white
plate added to it in 0.16.0 or earlier sat behind a 1053, and the rule
read that file in Photoshop's polarity: the added spot opened inverted.

A 1053 that lists fewer channels (non-zero ids; 0 is the transparency's)
than the file has after its transparency now counts as kept, with the
PhotoCraft 1057 and DisplayInfo spot conditions unchanged. Planes the
kept 1053 lists stay in Photoshop's polarity (they are the Photoshop
file's own); the ones after them are read straight. Photoshop and this
version write one id per extra channel, so their files are unaffected.
Known limit, as before: channels reordered there, or as many deleted as
added, can't be told apart from the Photoshop file's own.

The earlier versions are 0.1.0 to 0.16.0, not 0.11.1: every release
since writes the same 1057 and straight spot planes without a 1053.

Co-authored-by: jasallen <615848+jasallen@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 16:22:13 +01:00
VladimirPozdnyakov ebde50d6d5 Merge upstream/main into qol-type-hanging 2026-10-25 18:11:43 +03:00
David Mann ff479a2c01 Merge PR #9139: Rebuild the Histogram panel
# Conflicts:
#	crates/ui-egui/src/control.rs
#	docs/scorecard.md
#	docs/ui-parity.md
2026-10-25 16:11:31 +01:00
a87d9cb637 Integration: Histogram panel review fixes (#9139)
- Cache Levels 1 in Preferences turned off the 250 ms recount throttle,
  because "forced" was derived from max_level == 1: only an Uncached
  Refresh skips it now.
- The proxy factor became 2^(level-1) for every count, so the Levels,
  Curves and Threshold dialogs counted a 6000x3000 image on an 8x proxy
  instead of main's 7x (a 36 MP one 16x instead of 9x). Uncapped counts
  use main's factor again; only a Cache Levels cap halves by powers of two.
- The panel opens in Compact View, as in Photoshop, and Compact View
  counts the entire image whatever Source Expanded View was left at.
- The clipping corner marks are gone: Photoshop's Histogram panel has none.
- ui.inspect: "preview" counts only the active document's preview, and
  "current" compares the source and cache level too, not only the
  revision (a Source change left it true until the recount landed).
- ui-parity row lists two more differences (selection, Selected Layer
  with a dialog preview); cargo fmt.

Co-authored-by: mathildalabs <347373177+mathildalabs@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 16:08:36 +01:00
David MannandClaude Opus 5.5 4365c0537d Integration: merge main, resolve conflicts (#8885)
psd_import.rs keeps main's warning for an incomplete merged extra channel
next to the PR's Photoshop spot polarity. people.toml takes main's entries
plus jasallen's own. Docs take both sides' status lines and revision rows;
docs/scorecard.md is regenerated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-25 16:07:44 +01:00