diff --git a/crates/ui-egui/src/dialogs.rs b/crates/ui-egui/src/dialogs.rs index 0167a24c23..753a855ba5 100644 --- a/crates/ui-egui/src/dialogs.rs +++ b/crates/ui-egui/src/dialogs.rs @@ -787,8 +787,8 @@ fn about_tab_body(app: &mut PhotocraftApp, ui: &mut egui::Ui, tab: &str) { /// The dialog title as shown: [`title`] in the UI language. fn display_title(d: &Dialog) -> String { match d.fields.get("__colorPicker").and_then(Value::as_str) { - Some("foreground") => return tl!("Color Picker (Foreground Color)").to_string(), - Some("background") => return tl!("Color Picker (Background Color)").to_string(), + Some("foreground") => return crate::color_picker_ui::fixed_title("Color Picker (Foreground Color)", "Foreground Color"), + Some("background") => return crate::color_picker_ui::fixed_title("Color Picker (Background Color)", "Background Color"), _ => {} } if crate::smart_filter_dialog::owns(&d.fields) { diff --git a/crates/ui-egui/src/dialogs/color_picker_ui.rs b/crates/ui-egui/src/dialogs/color_picker_ui.rs index a59a316fee..0d48956651 100644 --- a/crates/ui-egui/src/dialogs/color_picker_ui.rs +++ b/crates/ui-egui/src/dialogs/color_picker_ui.rs @@ -221,6 +221,11 @@ pub fn title_for(name: &str) -> String { crate::i18n::fmt(tl!("Color Picker ({name})"), &[("name", name)]) } +/// Prefer a complete catalogued title; some locales only provide the named-colour template. +pub(crate) fn fixed_title(label: &str, name: &str) -> String { + if crate::i18n::has(crate::i18n::current(), label) { tl!(label).to_string() } else { title_for(tl!(name)) } +} + /// The `"#rrggbb"` at `field` of `f` (a key or a JSON pointer). fn field_value<'a>(f: &'a Map, field: &str) -> Option<&'a str> { match field.strip_prefix('/') {