diff --git a/crates/ui-egui/src/tools/transform_tool/pointer.rs b/crates/ui-egui/src/tools/transform_tool/pointer.rs index a342bc8481..3aebfd81f5 100644 --- a/crates/ui-egui/src/tools/transform_tool/pointer.rs +++ b/crates/ui-egui/src/tools/transform_tool/pointer.rs @@ -106,6 +106,10 @@ pub fn pointer(app: &mut PhotocraftApp, ev: ToolEvent, mods: egui::Modifiers) -> if matches!(ev, ToolEvent::Up { .. }) && g.is_some_and(|g| accepts_outside_click(g, [x, y], tol)) { if on_pasteboard(app, [x, y]) { commit(app); + } else if let (Some(g), Some(s)) = (g, app.ui.transform.as_mut()) { + // Jitter before the release may have turned the box a little: put it back. + s.quad = g.quad0; + s.pivot = g.pivot0; } return true; } diff --git a/crates/ui-egui/src/transform_commit_click_tests.rs b/crates/ui-egui/src/transform_commit_click_tests.rs index 1fcb6fdb8c..1d43c501f7 100644 --- a/crates/ui-egui/src/transform_commit_click_tests.rs +++ b/crates/ui-egui/src/transform_commit_click_tests.rs @@ -49,6 +49,17 @@ fn a_click_outside_the_box_on_the_image_keeps_it_open() { assert_eq!(steps(&app), before); } +#[test] +fn a_jittery_click_outside_the_box_leaves_it_unchanged() { + let mut app = app(); + let (quad, pivot) = (app.ui.transform.as_ref().unwrap().quad, app.ui.transform.as_ref().unwrap().pivot); + tool_event(&mut app, ToolEvent::Down { x: 150.0, y: 150.0, pressure: 1.0 }, Modifiers::NONE); + tool_event(&mut app, ToolEvent::Move { x: 150.0, y: 151.0, pressure: 1.0 }, Modifiers::NONE); + tool_event(&mut app, ToolEvent::Up { x: 150.0, y: 151.0 }, Modifiers::NONE); + let t = app.ui.transform.as_ref().unwrap(); + assert_eq!((t.quad, t.pivot), (quad, pivot)); +} + #[test] fn a_click_on_the_pasteboard_commits_one_free_transform_step() { for p in [[-30.0, 100.0], [100.0, -30.0], [230.0, 100.0], [100.0, 230.0]] {