mirror of
https://github.com/storytold/pdfcraft.git
synced 2026-11-10 21:11:52 +00:00
Eric KadenandZach
b8111effc6
Review follow-ups to the landscape fix rebased from #3068: - Both submission paths add the orientation through pdfcraft_print::add_cups_orientation, which never adds it over an orientation the job already names (a driver choice in the Print dialog, or a caller's doc_print options), so lp never gets it twice. - doc_print adds it inside spool_job, next to the paper (#3752), so its test checks the job it sends. - The Print dialog takes a stand-in for the spooler in tests (PdfCraftApp::spooler), like printer_source and options_source, and a test follows a real Print click to the job. - Doc comments for the tests beside the change. Checked on macOS with cupsfilter (cgpdftoraster, AirPrint PPD): a landscape sheet sent as before lands unrotated at 100% and cut off at the paper's right edge (#3739); with the option it is turned inside the margins. Co-authored-by: Zach <90340773+zdblazer@users.noreply.github.com>