M3: select text across pages (view.text-select)

Allow a text selection to run across pages, keeping main's same-page table-row selection (head_x) and the JavaScript link click dispatch from #2081.
This commit is contained in:
TheSuperStew authored and GitHub committed 2026-11-15 22:55:35 +01:00
1 parent 42c0ba8679
commit e191b0ea69
15 files changed
+1282 -180

No files matched your search

+2 -2
View File
@@ -1538,8 +1538,8 @@ milestone = "M3"
status = "shipped"
commands = []
tools = []
evidence = ["crates/ui-egui/tests/it/ui.rs::drag_selects_text_and_copy_returns_it", "crates/ui-egui/tests/it/ui.rs::selection_works_in_every_view_rotation", "crates/ui-egui/tests/it/text_select.rs::quick_clicks_select_a_word_then_the_line_then_the_page", "crates/ui-egui/tests/it/text_select.rs::quick_clicks_with_the_highlighter_mark_only_the_word", "crates/ui-egui/tests/it/text_select.rs::shift_click_extends_the_selection_from_its_anchor", "crates/ui-egui/tests/it/comments.rs::selected_text_shows_actions_and_underlines_without_changing_tools", "crates/ui-egui/tests/it/comments.rs::selected_text_replace_action_opens_replacement_composer", "crates/ui-egui/tests/it/comments.rs::selected_text_comment_action_opens_note_composer", "crates/render/src/text/tests.rs::a_drag_along_one_table_row_selects_that_row", "crates/render/src/text/tests.rs::a_drag_over_table_rows_selects_those_rows", "crates/render/src/text/tests.rs::a_pointer_ending_beside_the_column_takes_the_rows", "crates/render/src/text/tests.rs::a_drag_in_the_right_column_takes_nothing_from_the_left", "crates/render/src/text/tests.rs::a_cell_padded_with_spaces_joins_the_next_cell_of_its_row", "crates/ui-egui/tests/it/column_select.rs::a_plain_drag_along_one_table_row_selects_only_that_row", "crates/ui-egui/tests/it/column_select.rs::a_drag_ending_between_the_columns_selects_the_rows", "crates/render/src/text/tests.rs::a_barcode_drawn_with_a_font_reads_apart_from_the_text_beside_it", "crates/render/src/text/tests.rs::a_point_beside_a_barcode_takes_the_text_not_the_code_row", "crates/ui-egui/tests/it/column_select.rs::a_drag_down_text_beside_a_barcode_selects_only_the_text"]
notes = "Drag to select; across a table, which reads column by column, a drag selects by visual rows (the rest of its first row, the rows between, the start of its last), and copy gives the cells tab-separated; a drag down one column keeps reading order, and a QR or Aztec code drawn with a barcode font (as on Mexican CFDI invoices) reads apart from the text beside it. ⇧-click extends the selection to the click, keeping its anchor (same page only); with the Select tool, quick clicks select a word (two), the line (three) or all the text on the page (four). A floating action bar offers comment, highlight, underline, strikethrough, replace text and copy after selection. The markup and Redact tools mark a double-clicked word and stop there. Missing: selection across pages (dragging or ⇧-clicking onto another page), paragraph selection, and ⌘A across the whole document (it selects the current page). Acrobat's other selection context actions such as bookmark, link and export selection remain outside this bar."
evidence = ["crates/ui-egui/tests/it/ui.rs::drag_selects_text_and_copy_returns_it", "crates/ui-egui/tests/it/ui.rs::selection_works_in_every_view_rotation", "crates/ui-egui/tests/it/text_select.rs::quick_clicks_select_a_word_then_the_line_then_the_page", "crates/ui-egui/tests/it/text_select.rs::quick_clicks_with_the_highlighter_mark_only_the_word", "crates/ui-egui/tests/it/text_select.rs::shift_click_extends_the_selection_from_its_anchor", "crates/ui-egui/tests/it/text_select.rs::a_drag_selects_text_across_pages", "crates/ui-egui/tests/it/text_select.rs::shift_click_extends_the_selection_onto_another_page", "crates/ui-egui/tests/it/text_select.rs::a_selection_across_pages_is_marked_on_every_page_in_one_step", "crates/ui-egui/tests/it/text_select.rs::a_highlight_across_pages_selects_its_last_part_and_opens_its_note", "crates/ui-egui/tests/it/text_select.rs::an_area_highlight_ended_with_escape_stays_a_highlight", "crates/ui-egui/tests/it/text_select.rs::a_page_range_redaction_is_not_followed_up_as_a_selection", "crates/ui-egui/tests/it/text_select.rs::a_selection_drag_keeps_scrolling_over_the_gap_and_the_next_page", "crates/ui-egui/src/canvas/tests.rs::a_selection_across_pages_copies_each_page_on_its_own_line_once_all_are_read", "crates/ui-egui/src/canvas/tests.rs::a_selection_across_pages_still_to_be_read_is_copied_once_read", "crates/ui-egui/src/canvas/tests.rs::redaction_refuses_a_selection_over_an_unreadable_page", "crates/ui-egui/src/canvas/tests.rs::a_marking_tool_waits_for_the_selections_pages", "crates/ui-egui/src/canvas/tests.rs::waiting_marks_are_dropped_when_their_pages_change", "crates/ui-egui/tests/it/comments.rs::selected_text_shows_actions_and_underlines_without_changing_tools", "crates/ui-egui/tests/it/comments.rs::selected_text_replace_action_opens_replacement_composer", "crates/ui-egui/tests/it/comments.rs::selected_text_comment_action_opens_note_composer", "crates/render/src/text/tests.rs::a_drag_along_one_table_row_selects_that_row", "crates/render/src/text/tests.rs::a_drag_over_table_rows_selects_those_rows", "crates/render/src/text/tests.rs::a_pointer_ending_beside_the_column_takes_the_rows", "crates/render/src/text/tests.rs::a_drag_in_the_right_column_takes_nothing_from_the_left", "crates/render/src/text/tests.rs::a_cell_padded_with_spaces_joins_the_next_cell_of_its_row", "crates/ui-egui/tests/it/column_select.rs::a_plain_drag_along_one_table_row_selects_only_that_row", "crates/ui-egui/tests/it/column_select.rs::a_drag_ending_between_the_columns_selects_the_rows", "crates/render/src/text/tests.rs::a_barcode_drawn_with_a_font_reads_apart_from_the_text_beside_it", "crates/render/src/text/tests.rs::a_point_beside_a_barcode_takes_the_text_not_the_code_row", "crates/ui-egui/tests/it/column_select.rs::a_drag_down_text_beside_a_barcode_selects_only_the_text"]
notes = "Drag to select; ⇧-click extends the selection to the click, keeping its anchor. A selection runs across pages (dragging onto another page, with the edge and wheel scrolling of #721/#1670, or ⇧-clicking there): the rest of the first page, the pages between whole and the last page up to the pointer, copied with each page on a line of its own; pages not read yet are read off the UI thread for Copy, and a markup or Redact tool that finishes the selection first marks it once they are. Across a table, which reads column by column, a drag selects by visual rows (the rest of its first row, the rows between, the start of its last), and copy gives the cells tab-separated; a drag down one column keeps reading order, and a QR or Aztec code drawn with a barcode font (as on Mexican CFDI invoices) reads apart from the text beside it. With the Select tool, quick clicks select a word (two), the line (three) or all the text on the page (four). A floating action bar offers comment, highlight, underline, strikethrough, replace text and copy after selection; across pages, highlight, underline, strikethrough and Redact put one mark on each page in one undo step (Redact refuses a selection over a page whose text could not be read, and says so, rather than leave that page unmarked), while Add comment and Replace text (one page each) are greyed out. The markup and Redact tools mark a double-clicked word and stop there. Missing: paragraph selection, column selection across pages, an explanation on the greyed-out cross-page actions, and a check against Acrobat of its cross-page copied-text format (not observed). Acrobat's other selection context actions such as bookmark, link and export selection remain outside this bar."
[[feature]]
id = "view.column-select"