From 6d95958cccfb3b0059aee6ef844beacb51e9c0f7 Mon Sep 17 00:00:00 2001 From: FredApps <153173854+FredApps@users.noreply.github.com> Date: Wed, 18 Nov 2026 16:08:32 +0100 Subject: [PATCH 1/2] Use merged XFA namespace and BOM safety fixes --- Cargo.lock | 6 +++--- crates/xfa/Cargo.toml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 8607ed66c9..9b1f96990f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1569,9 +1569,9 @@ dependencies = [ [[package]] name = "craft-xfa" version = "0.1.0" -source = "git+https://github.com/storytold/craft-libs?rev=1a0d5d607859a2e529851482de09b8e53aaeec3e#1a0d5d607859a2e529851482de09b8e53aaeec3e" +source = "git+https://github.com/storytold/craft-libs?rev=23acc704933a9a5619a5cd1cddc9bb1fb5a9b2d3#23acc704933a9a5619a5cd1cddc9bb1fb5a9b2d3" dependencies = [ - "craft-xml 0.1.0 (git+https://github.com/storytold/craft-libs?rev=1a0d5d607859a2e529851482de09b8e53aaeec3e)", + "craft-xml 0.1.0 (git+https://github.com/storytold/craft-libs?rev=23acc704933a9a5619a5cd1cddc9bb1fb5a9b2d3)", ] [[package]] @@ -1586,7 +1586,7 @@ dependencies = [ [[package]] name = "craft-xml" version = "0.1.0" -source = "git+https://github.com/storytold/craft-libs?rev=1a0d5d607859a2e529851482de09b8e53aaeec3e#1a0d5d607859a2e529851482de09b8e53aaeec3e" +source = "git+https://github.com/storytold/craft-libs?rev=23acc704933a9a5619a5cd1cddc9bb1fb5a9b2d3#23acc704933a9a5619a5cd1cddc9bb1fb5a9b2d3" dependencies = [ "quick-xml 0.41.0", "serde", diff --git a/crates/xfa/Cargo.toml b/crates/xfa/Cargo.toml index 73e02252b4..ca8d308e4f 100644 --- a/crates/xfa/Cargo.toml +++ b/crates/xfa/Cargo.toml @@ -11,7 +11,7 @@ repository.workspace = true workspace = true [dependencies] -craft-xfa = { version = "0.1.0", git = "https://github.com/storytold/craft-libs", rev = "1a0d5d607859a2e529851482de09b8e53aaeec3e" } +craft-xfa = { version = "0.1.0", git = "https://github.com/storytold/craft-libs", rev = "23acc704933a9a5619a5cd1cddc9bb1fb5a9b2d3" } pdfcraft-cos = { workspace = true } pdfcraft-fonts = { workspace = true } craft-xml = { workspace = true } From fe16ea4834a64d352535790d3f676650582109fc Mon Sep 17 00:00:00 2001 From: FredApps <153173854+FredApps@users.noreply.github.com> Date: Wed, 18 Nov 2026 18:07:30 +0100 Subject: [PATCH 2/2] fix(xfa): classify shared namespace admission as too large --- crates/xfa/src/data/import.rs | 10 +++++++++- crates/xfa/src/tests.rs | 9 +++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/crates/xfa/src/data/import.rs b/crates/xfa/src/data/import.rs index 23a72e8f98..4738b56fa2 100644 --- a/crates/xfa/src/data/import.rs +++ b/crates/xfa/src/data/import.rs @@ -193,7 +193,15 @@ pub fn parse_data_file(text: &str, expect_root: Option<&str>) -> Result", ""] { + assert!(matches!(parse_data_file(xml, None), Err(XfaError::Malformed(_))), "{xml}"); + } + let nodes = parse_data_file("value", None).unwrap(); + assert!(!nodes.is_empty()); +} /// A long data name with a high index is not copied into every sibling created before it. #[test] fn long_names_repeated_by_an_index_are_capped() {