From b10f85262c9f5740f0aa4517281e4096864a6e66 Mon Sep 17 00:00:00 2001 From: FredApps <153173854+FredApps@users.noreply.github.com> Date: Tue, 10 Nov 2026 20:57:08 +0100 Subject: [PATCH] Test: the non-UTF-8 output-name probe test doesn't run on macOS (#6913) output_probe_paths_preserve_non_utf8_names creates files named with bytes that aren't UTF-8. APFS keeps only UTF-8 file names, so on macOS creating the probe fails before the check runs and the test fails; no output can have such a name there. It runs on the other unix systems as before. Found running the automation tests on hosted macOS. --- crates/automation/src/bates.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/automation/src/bates.rs b/crates/automation/src/bates.rs index 71ae6b3b91..931b9cfd90 100644 --- a/crates/automation/src/bates.rs +++ b/crates/automation/src/bates.rs @@ -366,7 +366,9 @@ mod tests { assert_eq!(std::fs::read_dir(dir.path()).unwrap().count(), 0); } - #[cfg(unix)] + // Not on macOS: APFS keeps only UTF-8 file names, so no output there can have such a name, and + // creating the probe fails before the check runs. + #[cfg(all(unix, not(target_os = "macos")))] #[test] fn output_probe_paths_preserve_non_utf8_names() { use std::os::unix::ffi::OsStringExt;