From 40b9b1f412f6178315d310740cf6f335504a7d91 Mon Sep 17 00:00:00 2001 From: Brandon Thomas Date: Sun, 15 Nov 2026 09:41:09 -0500 Subject: [PATCH 1/5] test(preflight): freeze original ICC v2 writer as parity oracle Original PDFCraft source at e098c5c85, introduced by 4d60af8b1 and renamed in d3db99818. This copy will only be compiled for tests. --- crates/preflight/src/icc_legacy_test.rs | 128 ++++++++++++++++++++++++ 1 file changed, 128 insertions(+) create mode 100644 crates/preflight/src/icc_legacy_test.rs diff --git a/crates/preflight/src/icc_legacy_test.rs b/crates/preflight/src/icc_legacy_test.rs new file mode 100644 index 0000000000..935dd105ce --- /dev/null +++ b/crates/preflight/src/icc_legacy_test.rs @@ -0,0 +1,128 @@ +//! A small sRGB ICC profile (version 2, display class, matrix/TRC), written from the published +//! sRGB primaries (IEC 61966-2-1) adapted to D50, with the sRGB tone curve sampled at 1024 +//! points. Used as the PDF/A output intent's destination profile. + +fn s15f16(v: f64) -> [u8; 4] { + ((v * 65536.0).round() as i32).to_be_bytes() +} + +fn xyz(x: f64, y: f64, z: f64) -> Vec { + let mut t = b"XYZ \0\0\0\0".to_vec(); + t.extend(s15f16(x)); + t.extend(s15f16(y)); + t.extend(s15f16(z)); + t +} + +fn desc(text: &str) -> Vec { + let mut t = b"desc\0\0\0\0".to_vec(); + let ascii: Vec = text.bytes().chain(std::iter::once(0)).collect(); + t.extend((ascii.len() as u32).to_be_bytes()); + t.extend(&ascii); + // No Unicode or ScriptCode descriptions. + t.extend([0u8; 4 + 4]); + t.extend([0u8; 2 + 1 + 67]); + t +} + +fn text(text: &str) -> Vec { + let mut t = b"text\0\0\0\0".to_vec(); + t.extend(text.bytes()); + t.push(0); + t +} + +fn curve() -> Vec { + const N: usize = 1024; + let mut t = b"curv\0\0\0\0".to_vec(); + t.extend((N as u32).to_be_bytes()); + for i in 0..N { + let v = i as f64 / (N - 1) as f64; + let lin = if v <= 0.04045 { v / 12.92 } else { ((v + 0.055) / 1.055).powf(2.4) }; + t.extend(((lin * 65535.0).round() as u16).to_be_bytes()); + } + t +} + +/// The profile's bytes. +pub fn srgb() -> Vec { + // sRGB primaries, Bradford-adapted to the D50 profile connection space. + let tags: Vec<(&[u8; 4], Vec)> = vec![ + (b"desc", desc("sRGB (PdfCraft)")), + (b"cprt", text("No copyright, use freely")), + (b"wtpt", xyz(0.9642, 1.0, 0.8249)), + (b"rXYZ", xyz(0.4361, 0.2225, 0.0139)), + (b"gXYZ", xyz(0.3851, 0.7169, 0.0971)), + (b"bXYZ", xyz(0.1431, 0.0606, 0.7141)), + (b"rTRC", curve()), + ]; + // gTRC and bTRC share rTRC's data. + let count = tags.len() + 2; + let table_len = 4 + count * 12; + let mut offset = 128 + table_len; + let mut table = (count as u32).to_be_bytes().to_vec(); + let mut data = Vec::new(); + let mut trc = (0, 0); + for (sig, body) in &tags { + let len = body.len(); + table.extend(*sig); + table.extend((offset as u32).to_be_bytes()); + table.extend((len as u32).to_be_bytes()); + if *sig == b"rTRC" { + trc = (offset, len); + } + data.extend(body); + // Tags start on 4-byte boundaries. + let pad = (4 - len % 4) % 4; + data.extend(std::iter::repeat_n(0u8, pad)); + offset += len + pad; + } + for sig in [b"gTRC", b"bTRC"] { + table.extend(sig); + table.extend((trc.0 as u32).to_be_bytes()); + table.extend((trc.1 as u32).to_be_bytes()); + } + let size = 128 + table.len() + data.len(); + let mut h = Vec::with_capacity(size); + h.extend((size as u32).to_be_bytes()); + h.extend(b"\0\0\0\0"); // preferred CMM + h.extend([2, 0x10, 0, 0]); // version 2.1 + h.extend(b"mntr"); + h.extend(b"RGB "); + h.extend(b"XYZ "); + h.extend([0u8; 12]); // date + h.extend(b"acsp"); + h.extend(b"\0\0\0\0"); // platform + h.extend([0u8; 4]); // flags + h.extend([0u8; 4]); // manufacturer + h.extend([0u8; 4]); // model + h.extend([0u8; 8]); // attributes + h.extend([0, 0, 0, 0]); // perceptual intent + h.extend(s15f16(0.9642)); + h.extend(s15f16(1.0)); + h.extend(s15f16(0.8249)); + h.extend([0u8; 4]); // creator + h.resize(128, 0); + h.extend(table); + h.extend(data); + h +} + +#[cfg(test)] +mod tests { + #[test] + fn profile_is_well_formed() { + let p = super::srgb(); + assert_eq!(u32::from_be_bytes(p[0..4].try_into().unwrap()) as usize, p.len()); + assert_eq!(&p[36..40], b"acsp"); + assert_eq!(&p[12..20], b"mntrRGB "); + let n = u32::from_be_bytes(p[128..132].try_into().unwrap()) as usize; + assert_eq!(n, 9); + for i in 0..n { + let e = 132 + i * 12; + let off = u32::from_be_bytes(p[e + 4..e + 8].try_into().unwrap()) as usize; + let len = u32::from_be_bytes(p[e + 8..e + 12].try_into().unwrap()) as usize; + assert!(off.is_multiple_of(4) && off + len <= p.len(), "tag {i}"); + } + } +} From acb6408244abc546b314f604fbe067162a5b018d Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sun, 15 Nov 2026 09:42:07 -0500 Subject: [PATCH 2/5] preflight: use shared byte-compatible ICC v2 sRGB profile --- Cargo.lock | 16 ++++- crates/preflight/Cargo.toml | 1 + crates/preflight/src/icc.rs | 128 +++--------------------------------- 3 files changed, 23 insertions(+), 122 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index a259e0fe5e..fd20becd74 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1190,6 +1190,15 @@ dependencies = [ "libc", ] +[[package]] +name = "craft-cms" +version = "0.1.0" +source = "git+https://github.com/storytold/craft-libs?rev=7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3#7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3" +dependencies = [ + "md-5 0.10.6", + "rayon", +] + [[package]] name = "craft-cms" version = "0.1.0" @@ -4540,7 +4549,7 @@ name = "pdfcraft-automation" version = "0.21.1" dependencies = [ "base64 0.23.1", - "craft-cms", + "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=e2dc681a3)", "craft-image-codecs", "craft-prc", "flate2", @@ -4655,7 +4664,7 @@ name = "pdfcraft-engine" version = "0.21.1" dependencies = [ "chrono", - "craft-cms", + "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=e2dc681a3)", "craft-docpath", "craft-image-codecs", "craft-tiff", @@ -4852,6 +4861,7 @@ dependencies = [ name = "pdfcraft-preflight" version = "0.21.1" dependencies = [ + "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3)", "craft-xml", "flate2", "pdfcraft-content", @@ -4863,7 +4873,7 @@ dependencies = [ name = "pdfcraft-print" version = "0.21.1" dependencies = [ - "craft-cms", + "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=e2dc681a3)", "craft-print", "log", "pdfcraft-content", diff --git a/crates/preflight/Cargo.toml b/crates/preflight/Cargo.toml index 28c76ccd97..1954e8236f 100644 --- a/crates/preflight/Cargo.toml +++ b/crates/preflight/Cargo.toml @@ -11,6 +11,7 @@ repository.workspace = true workspace = true [dependencies] +craft-cms-v2 = { package = "craft-cms", git = "https://github.com/storytold/craft-libs", rev = "7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3" } craft-xml = { workspace = true } pdfcraft-content = { workspace = true } pdfcraft-cos = { workspace = true } diff --git a/crates/preflight/src/icc.rs b/crates/preflight/src/icc.rs index 935dd105ce..81764fbcee 100644 --- a/crates/preflight/src/icc.rs +++ b/crates/preflight/src/icc.rs @@ -1,128 +1,18 @@ -//! A small sRGB ICC profile (version 2, display class, matrix/TRC), written from the published -//! sRGB primaries (IEC 61966-2-1) adapted to D50, with the sRGB tone curve sampled at 1024 -//! points. Used as the PDF/A output intent's destination profile. +//! PDF/A output-intent policy stays here; ICC v2 bytes come from craft-cms. +//! Keep v2.1 rather than substituting the shared v4 built-in profile. -fn s15f16(v: f64) -> [u8; 4] { - ((v * 65536.0).round() as i32).to_be_bytes() -} - -fn xyz(x: f64, y: f64, z: f64) -> Vec { - let mut t = b"XYZ \0\0\0\0".to_vec(); - t.extend(s15f16(x)); - t.extend(s15f16(y)); - t.extend(s15f16(z)); - t -} - -fn desc(text: &str) -> Vec { - let mut t = b"desc\0\0\0\0".to_vec(); - let ascii: Vec = text.bytes().chain(std::iter::once(0)).collect(); - t.extend((ascii.len() as u32).to_be_bytes()); - t.extend(&ascii); - // No Unicode or ScriptCode descriptions. - t.extend([0u8; 4 + 4]); - t.extend([0u8; 2 + 1 + 67]); - t -} - -fn text(text: &str) -> Vec { - let mut t = b"text\0\0\0\0".to_vec(); - t.extend(text.bytes()); - t.push(0); - t -} - -fn curve() -> Vec { - const N: usize = 1024; - let mut t = b"curv\0\0\0\0".to_vec(); - t.extend((N as u32).to_be_bytes()); - for i in 0..N { - let v = i as f64 / (N - 1) as f64; - let lin = if v <= 0.04045 { v / 12.92 } else { ((v + 0.055) / 1.055).powf(2.4) }; - t.extend(((lin * 65535.0).round() as u16).to_be_bytes()); - } - t -} - -/// The profile's bytes. pub fn srgb() -> Vec { - // sRGB primaries, Bradford-adapted to the D50 profile connection space. - let tags: Vec<(&[u8; 4], Vec)> = vec![ - (b"desc", desc("sRGB (PdfCraft)")), - (b"cprt", text("No copyright, use freely")), - (b"wtpt", xyz(0.9642, 1.0, 0.8249)), - (b"rXYZ", xyz(0.4361, 0.2225, 0.0139)), - (b"gXYZ", xyz(0.3851, 0.7169, 0.0971)), - (b"bXYZ", xyz(0.1431, 0.0606, 0.7141)), - (b"rTRC", curve()), - ]; - // gTRC and bTRC share rTRC's data. - let count = tags.len() + 2; - let table_len = 4 + count * 12; - let mut offset = 128 + table_len; - let mut table = (count as u32).to_be_bytes().to_vec(); - let mut data = Vec::new(); - let mut trc = (0, 0); - for (sig, body) in &tags { - let len = body.len(); - table.extend(*sig); - table.extend((offset as u32).to_be_bytes()); - table.extend((len as u32).to_be_bytes()); - if *sig == b"rTRC" { - trc = (offset, len); - } - data.extend(body); - // Tags start on 4-byte boundaries. - let pad = (4 - len % 4) % 4; - data.extend(std::iter::repeat_n(0u8, pad)); - offset += len + pad; - } - for sig in [b"gTRC", b"bTRC"] { - table.extend(sig); - table.extend((trc.0 as u32).to_be_bytes()); - table.extend((trc.1 as u32).to_be_bytes()); - } - let size = 128 + table.len() + data.len(); - let mut h = Vec::with_capacity(size); - h.extend((size as u32).to_be_bytes()); - h.extend(b"\0\0\0\0"); // preferred CMM - h.extend([2, 0x10, 0, 0]); // version 2.1 - h.extend(b"mntr"); - h.extend(b"RGB "); - h.extend(b"XYZ "); - h.extend([0u8; 12]); // date - h.extend(b"acsp"); - h.extend(b"\0\0\0\0"); // platform - h.extend([0u8; 4]); // flags - h.extend([0u8; 4]); // manufacturer - h.extend([0u8; 4]); // model - h.extend([0u8; 8]); // attributes - h.extend([0, 0, 0, 0]); // perceptual intent - h.extend(s15f16(0.9642)); - h.extend(s15f16(1.0)); - h.extend(s15f16(0.8249)); - h.extend([0u8; 4]); // creator - h.resize(128, 0); - h.extend(table); - h.extend(data); - h + craft_cms_v2::builtin::srgb_v2() } +#[cfg(test)] +#[path = "icc_legacy_test.rs"] +mod legacy; + #[cfg(test)] mod tests { #[test] - fn profile_is_well_formed() { - let p = super::srgb(); - assert_eq!(u32::from_be_bytes(p[0..4].try_into().unwrap()) as usize, p.len()); - assert_eq!(&p[36..40], b"acsp"); - assert_eq!(&p[12..20], b"mntrRGB "); - let n = u32::from_be_bytes(p[128..132].try_into().unwrap()) as usize; - assert_eq!(n, 9); - for i in 0..n { - let e = 132 + i * 12; - let off = u32::from_be_bytes(p[e + 4..e + 8].try_into().unwrap()) as usize; - let len = u32::from_be_bytes(p[e + 8..e + 12].try_into().unwrap()) as usize; - assert!(off.is_multiple_of(4) && off + len <= p.len(), "tag {i}"); - } + fn shared_profile_preserves_original_bytes() { + assert_eq!(super::srgb(), super::legacy::srgb()); } } From 0ca899e8302a064eb55a0812c8cde04fd0d0886c Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sun, 15 Nov 2026 09:43:56 -0500 Subject: [PATCH 3/5] preflight: follow shared ICC helper lint fix --- Cargo.lock | 4 ++-- crates/preflight/Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index fd20becd74..7b1bb83183 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1193,7 +1193,7 @@ dependencies = [ [[package]] name = "craft-cms" version = "0.1.0" -source = "git+https://github.com/storytold/craft-libs?rev=7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3#7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3" +source = "git+https://github.com/storytold/craft-libs?rev=cab96afd08c3b68073340d2162657ccc989bd751#cab96afd08c3b68073340d2162657ccc989bd751" dependencies = [ "md-5 0.10.6", "rayon", @@ -4861,7 +4861,7 @@ dependencies = [ name = "pdfcraft-preflight" version = "0.21.1" dependencies = [ - "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3)", + "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=cab96afd08c3b68073340d2162657ccc989bd751)", "craft-xml", "flate2", "pdfcraft-content", diff --git a/crates/preflight/Cargo.toml b/crates/preflight/Cargo.toml index 1954e8236f..dd844dd6ed 100644 --- a/crates/preflight/Cargo.toml +++ b/crates/preflight/Cargo.toml @@ -11,7 +11,7 @@ repository.workspace = true workspace = true [dependencies] -craft-cms-v2 = { package = "craft-cms", git = "https://github.com/storytold/craft-libs", rev = "7bc5f2a4c8214b97394a5dcf60d01e9f5f5298c3" } +craft-cms-v2 = { package = "craft-cms", git = "https://github.com/storytold/craft-libs", rev = "cab96afd08c3b68073340d2162657ccc989bd751" } craft-xml = { workspace = true } pdfcraft-content = { workspace = true } pdfcraft-cos = { workspace = true } From 08d24b3ad8968c6f6c5a3163ac6626a01420f0f8 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sun, 15 Nov 2026 10:10:12 -0500 Subject: [PATCH 4/5] preflight: constrain shared CMS package version --- crates/preflight/Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/preflight/Cargo.toml b/crates/preflight/Cargo.toml index dd844dd6ed..204c316d96 100644 --- a/crates/preflight/Cargo.toml +++ b/crates/preflight/Cargo.toml @@ -11,7 +11,7 @@ repository.workspace = true workspace = true [dependencies] -craft-cms-v2 = { package = "craft-cms", git = "https://github.com/storytold/craft-libs", rev = "cab96afd08c3b68073340d2162657ccc989bd751" } +craft-cms-v2 = { package = "craft-cms", version = "0.1.0", git = "https://github.com/storytold/craft-libs", rev = "cab96afd08c3b68073340d2162657ccc989bd751" } craft-xml = { workspace = true } pdfcraft-content = { workspace = true } pdfcraft-cos = { workspace = true } From e14ed45a4d757e6bea4fab60bab804d3afd640c9 Mon Sep 17 00:00:00 2001 From: "Dylan M. Taylor" Date: Sun, 15 Nov 2026 17:24:08 +0000 Subject: [PATCH 5/5] Pin ICC v2 generator to merged shared revision --- Cargo.lock | 4 ++-- crates/preflight/Cargo.toml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 7b1bb83183..095387a427 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1193,7 +1193,7 @@ dependencies = [ [[package]] name = "craft-cms" version = "0.1.0" -source = "git+https://github.com/storytold/craft-libs?rev=cab96afd08c3b68073340d2162657ccc989bd751#cab96afd08c3b68073340d2162657ccc989bd751" +source = "git+https://github.com/storytold/craft-libs?rev=8503f24cb845268f47f97e829491114fe9ad1bfa#8503f24cb845268f47f97e829491114fe9ad1bfa" dependencies = [ "md-5 0.10.6", "rayon", @@ -4861,7 +4861,7 @@ dependencies = [ name = "pdfcraft-preflight" version = "0.21.1" dependencies = [ - "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=cab96afd08c3b68073340d2162657ccc989bd751)", + "craft-cms 0.1.0 (git+https://github.com/storytold/craft-libs?rev=8503f24cb845268f47f97e829491114fe9ad1bfa)", "craft-xml", "flate2", "pdfcraft-content", diff --git a/crates/preflight/Cargo.toml b/crates/preflight/Cargo.toml index 204c316d96..aabde13699 100644 --- a/crates/preflight/Cargo.toml +++ b/crates/preflight/Cargo.toml @@ -11,7 +11,7 @@ repository.workspace = true workspace = true [dependencies] -craft-cms-v2 = { package = "craft-cms", version = "0.1.0", git = "https://github.com/storytold/craft-libs", rev = "cab96afd08c3b68073340d2162657ccc989bd751" } +craft-cms-v2 = { package = "craft-cms", version = "0.1.0", git = "https://github.com/storytold/craft-libs", rev = "8503f24cb845268f47f97e829491114fe9ad1bfa" } craft-xml = { workspace = true } pdfcraft-content = { workspace = true } pdfcraft-cos = { workspace = true }