Review fixes for the saved Upright import.
- The saved matrix is placed when the sidecar is merged, in the frame the file's orientation and
then the photo's own Rotate Left / Right give (Orientation::then). Read Metadata after a
rotation no longer keeps it in the old frame (up to 21 px off on DSC_1457). Rotate Left / Right
turns a stored Upright correction with the photo (upright::turned), LightCraft's own as well.
- Sidecar crops go through the Lightroom catalog import's conversion (catalog_crop, moved to
crs::crop_in_frame unchanged) whenever the file's orientation is known. A portrait raw's crop
used to cut the wrong side (DSC_1486 rendered 2548 x 4812 for Lightroom's 3200 x 3808; now
0.12 px mean from Lightroom's export after the NEF frame inset), and straightened crops from a
real catalog's settings came out 8459 x 3827 for Lightroom's 7725 x 5150. A straightened crop
on top of a saved Upright isn't measured: the mode is solved again, with the warning.
- Lightroom catalogs don't read the saved Upright until a real catalog verifies its encoding and
frame: the mode is solved again and the import reports it.
- Guided Upright guides are reported whether or not automatic matrices are present.
The new regressions fail on the previous commit and pass here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alex ChambersandClaude Opus 5.5
7bb11f4604