mirror of
https://github.com/storytold/gridcraft.git
synced 2026-11-10 20:41:47 +00:00
Shirish Veerabattini
56f784473d
A formula calling a built-in function with too few or too many arguments (=DATEDIF(a,b), =SUM(), =DATE(2024,1)) was stored and showed #VALUE! with no hint about what was wrong. Entry now refuses it with the function's signature, e.g. "DATEDIF has too few arguments. Use DATEDIF(start_date, end_date, unit)", and leaves the cell unchanged. Only registered functions are checked: special forms the evaluator handles itself (IF, LET, LAMBDA...), LAMBDA names and unknown functions are skipped. Paste and Find & Replace keep turning input that fails entry into text. DATEDIF's description now lists its units. Fixes #363 Claude-Session: https://claude.ai/code/session_01BGBBGBC2gRpQ7GDuwQ6WPt
2171 lines
112 KiB
Rust
2171 lines
112 KiB
Rust
use gridcraft_core::{CellRef, Value};
|
||
use serde_json::json;
|
||
|
||
use crate::Session;
|
||
|
||
fn s() -> Session {
|
||
let mut s = Session::new();
|
||
s.new_workbook();
|
||
s
|
||
}
|
||
|
||
fn v(s: &Session, a: &str) -> Value {
|
||
s.doc().unwrap().wb.active().unwrap().value(CellRef::parse(a).unwrap())
|
||
}
|
||
|
||
#[test]
|
||
fn entering_empty_cells_preserves_whole_sheet_formatting() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "existing"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A1:XFD1048576"})).unwrap();
|
||
s.execute("home.alignCenter", json!({})).unwrap();
|
||
let border = gridcraft_model::BorderLine { style: gridcraft_model::BorderStyle::Thin, color: gridcraft_model::Color::Auto };
|
||
s.execute("home.formatCells", json!({"style": {"borders": {"top": border, "bottom": border, "left": border, "right": border}}})).unwrap();
|
||
let expected = {
|
||
let d = s.doc().unwrap();
|
||
d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse("B1").unwrap())).clone()
|
||
};
|
||
assert_eq!(expected.align.h, gridcraft_model::HAlign::Center);
|
||
for (cell, input) in [("A1", "edited"), ("B1", "new"), ("C1", "=1+2"), ("XFD1048576", "edge")] {
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse(cell).unwrap())), &expected, "{cell}");
|
||
}
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [["text", 7, true]]})).unwrap();
|
||
for cell in ["D1", "E1", "F1"] {
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse(cell).unwrap())), &expected, "{cell}");
|
||
}
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert!(v(&s, "D1").is_empty());
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
assert_eq!(d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse("D1").unwrap())), &expected);
|
||
assert_eq!(d.wb.active().unwrap().cells.len(), 7);
|
||
let (reopened, _) = gridcraft_xlsx::read_xlsx(&gridcraft_xlsx::write_xlsx(&d.wb).unwrap()).unwrap();
|
||
for cell in ["A1", "B1", "C1", "D1", "E1", "F1", "G1", "XFD1048576"] {
|
||
assert_eq!(
|
||
reopened.styles.get(reopened.active().unwrap().style_id(CellRef::parse(cell).unwrap())),
|
||
&expected,
|
||
"{cell} after XLSX round trip"
|
||
);
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn pasted_currency_text_keeps_the_number_from_the_clipboard_html() {
|
||
// #257: "Rp10,000.00" copied from Excel for the web / LibreOffice Calc pasted as text. Their
|
||
// clipboard HTML records the number (x:num, sdval); paste keeps it and shows the same text.
|
||
let mut s = s();
|
||
let text = "Rp10,000.00\tRp2,500.50\tLabel\n";
|
||
let html =
|
||
r#"<table><tr><td x:num="10000">Rp10,000.00</td><td sdval="2500.5" sdnum="1033;0;x"><font>Rp2,500.50</font></td><td>Label</td></tr></table>"#;
|
||
s.execute("edit.paste", json!({"at": "A1", "text": text, "html": html})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::number(10000.0));
|
||
assert_eq!(v(&s, "B1"), Value::number(2500.5));
|
||
assert_eq!(v(&s, "C1"), Value::text("Label"));
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(crate::display::cell_text(&d.wb, sh, CellRef::parse("A1").unwrap()), "Rp10,000.00");
|
||
assert_eq!(crate::display::cell_text(&d.wb, sh, CellRef::parse("B1").unwrap()), "Rp2,500.50");
|
||
|
||
// HTML that doesn't show the same text (left over from another copy) changes nothing; without
|
||
// HTML the text stays text, as typing it would in an en-US locale.
|
||
let stale = r#"<table><tr><td x:num="7">Rp7.00</td></tr></table>"#;
|
||
s.execute("edit.paste", json!({"at": "A3", "text": "Rp10,000.00", "html": stale})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "A4", "text": "Rp10,000.00"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::text("Rp10,000.00"));
|
||
assert_eq!(v(&s, "A4"), Value::text("Rp10,000.00"));
|
||
}
|
||
|
||
#[test]
|
||
fn editing_a_name_renames_it_in_formulas() {
|
||
// Name Manager › Edit…: `oldName` edits the name in place; formulas that use it follow.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "21"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Price", "refersTo": "=Sheet1!$A$1"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Other", "refersTo": "=1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=Price*2"})).unwrap();
|
||
let err = s.execute("formulas.defineName", json!({"name": "Other", "refersTo": "=Sheet1!$A$1", "oldName": "Price"}));
|
||
assert!(err.is_err(), "renaming onto another existing name is refused");
|
||
s.execute("formulas.defineName", json!({"name": "Cost", "refersTo": "=Sheet1!$A$1", "comment": "unit", "oldName": "Price"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let names: Vec<&str> = d.wb.names.iter().map(|n| n.name.as_str()).collect();
|
||
assert_eq!(names, ["Other", "Cost"]);
|
||
let b1 = d.wb.active().unwrap().cell(CellRef::parse("B1").unwrap()).and_then(|c| c.formula.clone()).unwrap();
|
||
assert_eq!(b1.text, "Cost*2");
|
||
assert_eq!(v(&s, "B1"), Value::number(42.0));
|
||
assert!(s.execute("formulas.defineName", json!({"name": "X", "oldName": "Missing"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn chart_recommendations_follow_the_data_shape() {
|
||
// #215: Recommended Charts lists chart types for the data; programmatic insert stays dialog-free.
|
||
let mut s = s();
|
||
let kinds = |s: &mut Session, range: &str| -> Vec<String> {
|
||
let r = s.execute("insert.chartRecommendations", json!({"range": range})).unwrap();
|
||
r.as_array().unwrap().iter().map(|x| format!("{}{}", x["type"].as_str().unwrap(), x["subtype"].as_str().unwrap())).collect()
|
||
};
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Fruit", "Sales"], ["Apples", 5], ["Pears", 3], ["Plums", 2]]})).unwrap();
|
||
assert_eq!(kinds(&mut s, "A1:B4"), ["column", "bar", "pie", "doughnut", "linemarkers"]);
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[1, 2], [2, 4.5], [3, 5.5], [4, 9]]})).unwrap();
|
||
assert_eq!(kinds(&mut s, "D1:E4").first().map(String::as_str), Some("scatter"), "two numeric columns: scatter first");
|
||
s.execute("range.setValues", json!({"range": "G1", "values": [["Q", "North", "South"], ["Q1", 1, -2], ["Q2", 3, 4]]})).unwrap();
|
||
let multi = kinds(&mut s, "G1:I3");
|
||
assert_eq!(multi.first().map(String::as_str), Some("column"));
|
||
assert!(!multi.iter().any(|k| k == "pie"), "several series: no pie");
|
||
assert!(s.execute("insert.chartRecommendations", json!({"range": "K1:K3"})).is_err(), "no numbers, no chart");
|
||
|
||
// Without a type the command inserts the first recommendation; with one, that type.
|
||
s.execute("insert.recommendedCharts", json!({"range": "D1:E4"})).unwrap();
|
||
s.execute("insert.recommendedCharts", json!({"range": "A1:B4", "type": "pie"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let kinds: Vec<_> = d.wb.active().unwrap().charts.iter().map(|c| c.kind).collect();
|
||
assert_eq!(kinds, [gridcraft_model::ChartKind::Scatter, gridcraft_model::ChartKind::Pie]);
|
||
assert!(s.ui_requests.is_empty(), "programmatic calls never open the dialog");
|
||
}
|
||
|
||
#[test]
|
||
fn chart_category_axis_from_blank_corner_and_select_data() {
|
||
// #287: numeric X values must be the category axis, not a series of their own.
|
||
let mut s = s();
|
||
let series = |s: &Session| -> Vec<(Option<String>, String)> {
|
||
let d = s.doc().unwrap();
|
||
d.wb.active().unwrap().charts.last().unwrap().series.iter().map(|x| (x.categories.clone(), x.values.clone())).collect()
|
||
};
|
||
// A blank top-left cell marks the first column as category labels, numbers or not.
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[null, "Sales"], [2020, 5], [2021, 7], [2022, 9]]})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "A1:B4", "type": "line"})).unwrap();
|
||
assert_eq!(series(&s), [(Some("Sheet1!$A$2:$A$4".to_string()), "Sheet1!$B$2:$B$4".to_string())]);
|
||
|
||
// With a "Year" header the year column is a series, as before; Select Data fixes it:
|
||
// Horizontal (Category) Axis Labels and Remove on the year series.
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [["Year", "Sales"], [2020, 5], [2021, 7], [2022, 9]]})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "D1:E4", "type": "line"})).unwrap();
|
||
assert_eq!(series(&s).len(), 2);
|
||
assert!(s.execute("chart.selectData", json!({})).is_err(), "nothing to change");
|
||
assert!(s.execute("chart.selectData", json!({"categories": "not a range"})).is_err());
|
||
s.execute("chart.selectData", json!({"categories": "=D2:D4", "removeSeries": [0, 7]})).unwrap();
|
||
assert_eq!(series(&s), [(Some("Sheet1!$D$2:$D$4".to_string()), "Sheet1!$E$2:$E$4".to_string())]);
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
let data = gridcraft_chart::resolve(&d.wb, d.wb.active_sheet, sh.charts.last().unwrap());
|
||
assert_eq!(data.categories, ["2020", "2021", "2022"]);
|
||
// The last series can't be removed; "" clears the labels.
|
||
s.execute("chart.selectData", json!({"categories": "", "removeSeries": [0]})).unwrap();
|
||
assert_eq!(series(&s), [(None, "Sheet1!$E$2:$E$4".to_string())]);
|
||
}
|
||
|
||
#[test]
|
||
fn entry_and_text_paste_use_inherited_formats_and_cell_overrides() {
|
||
let mut s = s();
|
||
s.execute("home.bold", json!({"range": "B:B", "on": true})).unwrap();
|
||
s.execute("home.formatCells", json!({"range": "3:3", "style": {"num_fmt": "@", "font": {"italic": true}}})).unwrap();
|
||
s.execute("home.fontColor", json!({"range": "B3", "color": "#FF0000"})).unwrap();
|
||
let expected = {
|
||
let d = s.doc().unwrap();
|
||
d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse("B3").unwrap())).clone()
|
||
};
|
||
s.execute("cell.set", json!({"cell": "B3", "input": "=1+2"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C3", "input": "00123"})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "D3", "text": "=2+3\t00456"})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::text("=1+2"));
|
||
assert_eq!(v(&s, "C3"), Value::text("00123"));
|
||
assert_eq!(v(&s, "D3"), Value::text("=2+3"));
|
||
assert_eq!(v(&s, "E3"), Value::text("00456"));
|
||
s.execute("cell.set", json!({"cell": "B4", "input": "12%"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(d.wb.styles.get(sh.style_id(CellRef::parse("B3").unwrap())), &expected);
|
||
for cell in ["C3", "D3", "E3"] {
|
||
let st = d.wb.styles.get(sh.style_id(CellRef::parse(cell).unwrap()));
|
||
assert!(st.font.italic);
|
||
assert!(!st.font.bold, "row style takes precedence over column style");
|
||
assert_eq!(st.num_fmt.as_str(), "@");
|
||
}
|
||
let percent = d.wb.styles.get(sh.style_id(CellRef::parse("B4").unwrap()));
|
||
assert!(percent.font.bold);
|
||
assert_ne!(percent.num_fmt.as_str(), "General");
|
||
}
|
||
|
||
#[test]
|
||
fn enter_values_and_formulas() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "10"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "32"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A3", "input": "=sum(a1:a2"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::Number(42.0));
|
||
assert!(s.execute("cell.set", json!({"cell": "A4", "input": "=1+*2"})).is_err());
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "12%"})).unwrap();
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert_eq!(crate::display::cell_text(&d.wb, sh, CellRef::parse("B1").unwrap()), "12%");
|
||
}
|
||
|
||
#[test]
|
||
fn formulas_with_the_wrong_argument_count_are_refused_on_entry() {
|
||
// #363: =DATEDIF(start, end) was stored and showed #VALUE!. Like Excel, entry refuses it and
|
||
// the message gives the signature, so the missing unit argument is visible.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "kept"})).unwrap();
|
||
for (input, word) in [
|
||
("=DATEDIF(DATE(2024,1,1),DATE(2024,3,15))", "few"),
|
||
("=1+DATE(2024,1)", "few"),
|
||
("=SUM()", "few"),
|
||
("=IFERROR(1,LEFT(\"a\",1,2,3))", "many"),
|
||
("=datedif(1,2,\"D\",4)", "many"),
|
||
] {
|
||
let e = s.execute("cell.set", json!({"cell": "A1", "input": input})).unwrap_err().to_string();
|
||
assert!(e.contains(&format!("too {word} arguments")), "{input}: {e}");
|
||
assert_eq!(v(&s, "A1"), Value::text("kept"), "{input} must not replace the cell");
|
||
}
|
||
let e = s.execute("cell.set", json!({"cell": "A1", "input": "=DATEDIF(1,2)"})).unwrap_err().to_string();
|
||
assert!(e.contains("DATEDIF(start_date, end_date, unit)"), "{e}");
|
||
// Correct counts, optional arguments left empty, special forms, LAMBDA names and unknown
|
||
// functions (#NAME?) still enter.
|
||
s.execute("formulas.defineName", json!({"name": "TWICE", "refersTo": "=LAMBDA(x,x*2)"})).unwrap();
|
||
for (cell, input) in [
|
||
("B1", "=DATEDIF(DATE(2024,1,1),DATE(2024,3,15),\"D\")"),
|
||
("B2", "=IF(TRUE,1)"),
|
||
("B3", "=LET(a,1,b,2,a+b)"),
|
||
("B4", "=TWICE(4)"),
|
||
("B5", "=NOSUCHFUNCTION(1,2,3)"),
|
||
("B6", "=ROUND(2.5,)"),
|
||
] {
|
||
s.execute("cell.set", json!({"cell": cell, "input": input})).unwrap_or_else(|e| panic!("{input}: {e}"));
|
||
}
|
||
assert_eq!(v(&s, "B1"), Value::Number(74.0));
|
||
assert_eq!(v(&s, "B4"), Value::Number(8.0));
|
||
// Pasted text that isn't a valid formula stays text, as it does for a parse error.
|
||
s.execute("edit.paste", json!({"at": "C1", "text": "=DATEDIF(1,2)\n"})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::text("=DATEDIF(1,2)"));
|
||
}
|
||
|
||
#[test]
|
||
fn undo_redo() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "2"})).unwrap();
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(2.0));
|
||
assert!(s.doc().unwrap().is_dirty());
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_edit_undo_redo_and_noop() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"at": "C4", "width": 210, "height": 90, "text": "Original"})).unwrap()["shape"].clone();
|
||
let original = s.doc().unwrap().wb.active().unwrap().shapes[0].clone();
|
||
let mut changed = original.clone();
|
||
changed.text = "First line\n\nSecond line & <text>".into();
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
s.execute("shape.setText", json!({"id": id, "text": changed.text})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], changed);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len + 1);
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], original);
|
||
|
||
let before_noop = s.doc().unwrap().wb.clone();
|
||
let revision = s.doc().unwrap().revision;
|
||
s.execute("shape.setText", json!({"id": id, "text": "Original"})).unwrap();
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before_noop));
|
||
assert_eq!(s.doc().unwrap().revision, revision);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
assert_eq!(s.doc().unwrap().redo.len(), 1);
|
||
s.execute("edit.redo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], changed);
|
||
|
||
s.execute("shape.setText", json!({"id": id, "text": ""})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text, "");
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0], changed);
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_rejects_invalid_targets_and_params() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"text": "Original"})).unwrap()["shape"].clone();
|
||
let rectangle = s.execute("insert.shape", json!({"kind": "rectangle", "text": "Rectangle"})).unwrap()["shape"].clone();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
for params in [
|
||
json!({}),
|
||
json!({"id": id}),
|
||
json!({"id": id, "text": 12}),
|
||
json!({"id": "1", "text": "bad id"}),
|
||
json!({"id": -1, "text": "bad id"}),
|
||
json!({"id": 1.5, "text": "bad id"}),
|
||
json!({"id": u64::from(u32::MAX) + 1, "text": "bad id"}),
|
||
json!({"id": 999, "text": "unknown"}),
|
||
json!({"id": rectangle, "text": "not a text box"}),
|
||
] {
|
||
assert!(matches!(s.execute("shape.setText", params), Err(crate::EngineError::BadParams { .. })));
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before));
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
}
|
||
s.execute("home.insertSheet", json!({})).unwrap();
|
||
assert!(matches!(s.execute("shape.setText", json!({"id": id, "text": "wrong sheet"})), Err(crate::EngineError::BadParams { .. })));
|
||
assert_eq!(s.doc().unwrap().wb.sheet(0).unwrap().shapes[0].text, "Original");
|
||
assert!(s.doc().unwrap().wb.active().unwrap().shapes.is_empty());
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_respects_sheet_protection() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"text": "Original"})).unwrap()["shape"].clone();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
assert!(s.execute("shape.setText", json!({"id": id, "text": "Changed"})).is_err());
|
||
assert!(std::sync::Arc::ptr_eq(&s.doc().unwrap().wb, &before));
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
s.execute("review.unprotectSheet", json!({})).unwrap();
|
||
s.execute("shape.setText", json!({"id": id, "text": "Changed"})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text, "Changed");
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_is_capped_like_a_cell() {
|
||
let mut s = s();
|
||
let id = s.execute("insert.textBox", json!({"text": "Original"})).unwrap()["shape"].clone();
|
||
// The cap counts characters, not bytes.
|
||
let longest = "é".repeat(32_767);
|
||
s.execute("shape.setText", json!({"id": id, "text": longest})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text.chars().count(), 32_767);
|
||
let undo_len = s.doc().unwrap().undo.len();
|
||
let too_long = "x".repeat(32_768);
|
||
assert!(matches!(s.execute("shape.setText", json!({"id": id, "text": too_long})), Err(crate::EngineError::BadParams { .. })));
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().shapes[0].text.chars().count(), 32_767);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_len);
|
||
}
|
||
|
||
#[test]
|
||
fn shape_text_edit_survives_xlsx_roundtrip() {
|
||
let mut s = s();
|
||
s.execute("insert.textBox", json!({"text": "Imported"})).unwrap();
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "text-box.xlsx", "base64": saved["base64"]})).unwrap();
|
||
let id = s.doc().unwrap().wb.active().unwrap().shapes[0].id;
|
||
let text = "Edited & <escaped>\n\nLast line\n";
|
||
s.execute("shape.setText", json!({"id": id, "text": text})).unwrap();
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "edited.xlsx", "base64": saved["base64"]})).unwrap();
|
||
let shape = &s.doc().unwrap().wb.active().unwrap().shapes[0];
|
||
assert_eq!(shape.kind, gridcraft_model::ShapeKind::TextBox);
|
||
assert_eq!(shape.text, text);
|
||
}
|
||
|
||
#[test]
|
||
fn no_border_clears_only_shared_edges_and_undo_restores_them() {
|
||
use gridcraft_core::RangeRef;
|
||
use gridcraft_model::{BorderLine, Borders};
|
||
|
||
for (range, neighbors) in [
|
||
("B2", &[("B1", "bottom"), ("B3", "top"), ("A2", "right"), ("C2", "left")][..]),
|
||
(
|
||
"B2:C3",
|
||
&[("B1", "bottom"), ("C1", "bottom"), ("B4", "top"), ("C4", "top"), ("A2", "right"), ("A3", "right"), ("D2", "left"), ("D3", "left")][..],
|
||
),
|
||
] {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2, 3, 4], [5, 6, 7, 8], [9, 10, 11, 12], [13, 14, 15, 16]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D4", "input": "=SUM(A1:C1)"})).unwrap();
|
||
s.execute("home.bold", json!({"range": "A1:D4", "on": true})).unwrap();
|
||
for preset in ["all", "diagonalDown"] {
|
||
s.execute("home.borders", json!({"range": "A1:D4", "preset": preset, "style": "double", "color": "#CC3344"})).unwrap();
|
||
}
|
||
let before: Vec<_> = RangeRef::parse("A1:D4").unwrap().iter().map(|c| s.execute("cell.get", json!({"cell": c.a1()})).unwrap()).collect();
|
||
s.execute("home.borders", json!({"range": range, "preset": "none"})).unwrap();
|
||
let selected = RangeRef::parse(range).unwrap();
|
||
for original in &before {
|
||
let address = original["cell"].as_str().unwrap();
|
||
let mut expected = original.clone();
|
||
if selected.contains(CellRef::parse(address).unwrap()) {
|
||
expected["style"]["borders"] = json!(Borders::default());
|
||
} else if let Some((_, edge)) = neighbors.iter().find(|(cell, _)| *cell == address) {
|
||
expected["style"]["borders"][*edge] = json!(BorderLine::default());
|
||
}
|
||
assert_eq!(s.execute("cell.get", json!({"cell": address})).unwrap(), expected, "clearing {range}, cell {address}");
|
||
}
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
for original in before {
|
||
assert_eq!(s.execute("cell.get", json!({"cell": original["cell"]})).unwrap(), original);
|
||
}
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn no_border_handles_sheet_corners_without_creating_out_of_bounds_cells() {
|
||
for (range, corner, neighbors) in [
|
||
("A1:B2", "A1", [("B1", "left"), ("A2", "top")]),
|
||
("XFC1048575:XFD1048576", "XFD1048576", [("XFC1048576", "right"), ("XFD1048575", "bottom")]),
|
||
] {
|
||
let mut s = s();
|
||
s.execute("home.borders", json!({"range": range, "preset": "all"})).unwrap();
|
||
s.execute("home.borders", json!({"range": corner, "preset": "none"})).unwrap();
|
||
for (neighbor, edge) in neighbors {
|
||
assert_eq!(s.execute("cell.get", json!({"cell": neighbor})).unwrap()["style"]["borders"][edge]["style"], "None");
|
||
}
|
||
let sh = s.doc().unwrap().wb.active().unwrap();
|
||
assert!(sh.cells.iter().all(|(c, _)| c.is_valid()));
|
||
assert!(sh.cells.iter().count() <= 4);
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn borders_respect_sheet_formatting_protection() {
|
||
let mut s = s();
|
||
s.execute("home.borders", json!({"range": "A1:B2", "preset": "all"})).unwrap();
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let undo_count = s.doc().unwrap().undo.len();
|
||
for preset in ["none", "left"] {
|
||
assert!(s.execute("home.borders", json!({"range": "A1", "preset": preset})).is_err());
|
||
assert_eq!(s.doc().unwrap().wb.styles, before.styles);
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().cells, before.active().unwrap().cells);
|
||
assert_eq!(s.doc().unwrap().undo.len(), undo_count);
|
||
}
|
||
s.execute("review.protectSheet", json!({"formatCells": true})).unwrap();
|
||
s.execute("home.borders", json!({"range": "A1", "preset": "none"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "B1"})).unwrap()["style"]["borders"]["left"]["style"], "None");
|
||
}
|
||
|
||
#[test]
|
||
fn copy_paste_shifts_formulas() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2], [3, 4]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=A1+B1"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "C1"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "C2"})).unwrap();
|
||
s.execute("edit.paste", json!({})).unwrap();
|
||
assert_eq!(v(&s, "C2"), Value::Number(7.0));
|
||
s.execute("edit.cut", json!({"range": "A1"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "E5"})).unwrap();
|
||
s.execute("edit.paste", json!({})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(1.0));
|
||
let f = s.execute("cell.get", json!({"cell": "C1"})).unwrap();
|
||
assert_eq!(f["formula"], "=E5+B1");
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_copies_selected_displayed_cells_and_styles() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "outside selection"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "B2", "values": [[0.125, "<tag>&\"\nnext"], [0.25, "last"]]})).unwrap();
|
||
s.execute("home.numberFormat", json!({"range": "B2:B3", "code": "0.0%"})).unwrap();
|
||
s.execute("home.bold", json!({"range": "B2", "on": true})).unwrap();
|
||
s.execute("home.italic", json!({"range": "B2", "on": true})).unwrap();
|
||
s.execute("home.fontColor", json!({"range": "B2", "color": "#123456"})).unwrap();
|
||
s.execute("home.fillColor", json!({"range": "B2", "color": "#FEDCBA"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "B2:C3", "html": true})).unwrap();
|
||
let html = copied["html"].as_str().expect("copy publishes HTML as well as plain text");
|
||
assert_eq!(copied["text"], "12.5%\t\"<tag>&\"\"\nnext\"\n25.0%\tlast\n");
|
||
assert!(html.starts_with("<table "));
|
||
assert!(html.ends_with("</table>"));
|
||
assert_eq!(html.matches("<tr>").count(), 2);
|
||
assert_eq!(html.matches("<td ").count(), 4);
|
||
assert!(html.contains("<tag>&"<br>next"));
|
||
for content in ["12.5%", "25.0%", "font-weight:bold;", "font-style:italic;", "color:#123456;", "background:#FEDCBA;", "text-align:right;"] {
|
||
assert!(html.contains(content), "missing {content}");
|
||
}
|
||
assert!(!html.contains("outside selection"));
|
||
assert!(!html.contains("<html"));
|
||
|
||
let cut = s.execute("edit.cut", json!({"range": "B2:C3", "html": true})).unwrap();
|
||
assert_eq!(cut["html"], copied["html"]);
|
||
assert_eq!(cut["text"], copied["text"]);
|
||
s.execute("edit.paste", json!({"at": "E5", "text": cut["text"]})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(0.125));
|
||
assert_eq!(v(&s, "B2"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn copy_and_cut_return_html_only_when_requested() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "x"})).unwrap();
|
||
for cmd in ["edit.copy", "edit.cut"] {
|
||
for params in [json!({"range": "A1"}), json!({"range": "A1", "html": false})] {
|
||
let r = s.execute(cmd, params).unwrap();
|
||
assert_eq!(r["text"], "x\n");
|
||
assert!(r.get("html").is_none(), "{cmd} must not bloat programmatic responses with HTML");
|
||
}
|
||
let r = s.execute(cmd, json!({"range": "A1", "html": true})).unwrap();
|
||
assert!(r["html"].as_str().is_some_and(|h| h.contains(">x</td>")));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_clips_merges_and_skips_hidden_rows() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "merged"})).unwrap();
|
||
s.execute("home.mergeCenter", json!({"range": "B2:D5"})).unwrap();
|
||
s.execute("home.hideRows", json!({"rows": "3:3"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E4", "input": "side"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "B2:C4", "html": true})).unwrap();
|
||
let html = copied["html"].as_str().expect("merged copy publishes HTML");
|
||
assert_eq!(copied["text"], "merged\t\n\t\n");
|
||
assert_eq!(html.matches("<tr>").count(), 2);
|
||
assert_eq!(html.matches("<td ").count(), 1);
|
||
assert!(html.contains("rowspan=\"2\" colspan=\"2\""));
|
||
assert!(html.contains(">merged</td>"));
|
||
|
||
// A selection beginning inside a merge must keep its shape without copying
|
||
// the original anchor's value from outside the selected rectangle.
|
||
let copied = s.execute("edit.copy", json!({"range": "C3:E5", "html": true})).unwrap();
|
||
let html = copied["html"].as_str().expect("partially selected merge publishes HTML");
|
||
assert_eq!(html.matches("<tr>").count(), 2);
|
||
assert_eq!(html.matches("<td ").count(), 3);
|
||
assert!(html.contains("rowspan=\"2\" colspan=\"2\""));
|
||
assert!(!html.contains("merged"));
|
||
assert!(html.contains(">side</td>"));
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_omits_html_for_large_ranges_without_truncating_text() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A10001", "input": "last cell"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "A1:A10001", "html": true})).unwrap();
|
||
assert!(copied.get("html").is_none(), "oversized HTML must be omitted, not partially copied");
|
||
let text = copied["text"].as_str().unwrap();
|
||
assert_eq!(text.lines().count(), 10_001);
|
||
assert!(text.ends_with("last cell\n"));
|
||
let copied = s.execute("edit.copy", json!({"range": "A10001", "html": true})).unwrap();
|
||
assert!(copied["html"].as_str().is_some_and(|html| html.contains("last cell")));
|
||
}
|
||
|
||
#[test]
|
||
fn rich_clipboard_omits_html_when_escaping_exceeds_byte_budget() {
|
||
let mut s = s();
|
||
let text = "&".repeat(1_000_000);
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[text]]})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({"range": "A1", "html": true})).unwrap();
|
||
assert!(copied.get("html").is_none(), "an oversized escaped value must not produce partial HTML");
|
||
assert_eq!(copied["text"].as_str().unwrap().len(), 1_000_001);
|
||
assert!(copied["text"].as_str().unwrap().ends_with("&\n"));
|
||
}
|
||
|
||
#[test]
|
||
fn insert_delete_rows_adjust() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SUM(A1:A3)"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "2:2"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "B1"})).unwrap()["formula"], "=SUM(A1:A4)");
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "10"})).unwrap();
|
||
assert_eq!(v(&s, "B1"), Value::Number(16.0));
|
||
s.execute("home.deleteRows", json!({"rows": "1:1"})).unwrap();
|
||
assert_eq!(v(&s, "B1"), Value::Empty);
|
||
assert_eq!(v(&s, "A1"), Value::Number(10.0));
|
||
}
|
||
|
||
#[test]
|
||
fn insert_copied_cells_inserts_rows_columns_and_blocks() {
|
||
// Issue #21: Insert Copied Cells.
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "=A2*10"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "2:2"})).unwrap();
|
||
s.execute("selection.set", json!({"range": "C4"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A4"), Value::Number(2.0));
|
||
assert_eq!(v(&s, "B4"), Value::Number(20.0), "the formula follows its new row");
|
||
assert_eq!(v(&s, "A5"), Value::Number(4.0));
|
||
assert_eq!(v(&s, "A6"), Value::Number(5.0));
|
||
assert_eq!(s.doc().unwrap().selection.current(), gridcraft_core::RangeRef::rows(3, 3));
|
||
// One undo step puts everything back.
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A4"), Value::Number(4.0));
|
||
assert_eq!(v(&s, "A6"), Value::Empty);
|
||
// Whole columns.
|
||
s.execute("edit.copy", json!({"range": "A:A"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "A1"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), Value::Number(3.0));
|
||
assert_eq!(v(&s, "B3"), Value::Number(3.0));
|
||
assert_eq!(v(&s, "C2"), Value::Number(20.0), "the old column B moved right");
|
||
// A block shifts cells right.
|
||
s.execute("cell.set", json!({"cell": "F1", "input": "x"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "G1", "input": "y"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "F1"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "G1", "shift": "right"})).unwrap();
|
||
assert_eq!(v(&s, "G1"), Value::from("x"));
|
||
assert_eq!(v(&s, "H1"), Value::from("y"));
|
||
assert!(s.clipboard.is_none(), "inserting ends copy mode");
|
||
s.execute("edit.copy", json!({"range": "F1"})).unwrap();
|
||
assert!(s.execute("home.insertCopiedCells", json!({"shift": "up"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn insert_cut_cells_moves_whole_rows() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=A5"})).unwrap();
|
||
// Up: row 5 goes above row 2.
|
||
s.execute("edit.cut", json!({"range": "5:5"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "A2"})).unwrap();
|
||
let col: Vec<Value> = (1..=6).map(|r| v(&s, &format!("A{r}"))).collect();
|
||
assert_eq!(col, [1.0, 5.0, 2.0, 3.0, 4.0].map(Value::Number).into_iter().chain([Value::Empty]).collect::<Vec<_>>());
|
||
assert_eq!(v(&s, "C1"), Value::Number(5.0), "references follow the moved cells");
|
||
assert!(s.clipboard.is_none());
|
||
// Down: row 1 goes above row 4.
|
||
s.execute("edit.cut", json!({"range": "1:1"})).unwrap();
|
||
s.execute("home.insertCopiedCells", json!({"at": "A4"})).unwrap();
|
||
let col: Vec<Value> = (1..=5).map(|r| v(&s, &format!("A{r}"))).collect();
|
||
assert_eq!(col, [5.0, 2.0, 1.0, 3.0, 4.0].map(Value::Number).to_vec());
|
||
assert_eq!(s.doc().unwrap().selection.current(), gridcraft_core::RangeRef::rows(2, 2));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
// Inside itself, and a cut block, are refused without changing anything.
|
||
s.execute("edit.cut", json!({"range": "2:4"})).unwrap();
|
||
assert!(s.execute("home.insertCopiedCells", json!({"at": "A3"})).is_err());
|
||
s.execute("edit.cut", json!({"range": "A1:A2"})).unwrap();
|
||
assert!(s.execute("home.insertCopiedCells", json!({"at": "B5"})).is_err());
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "B5"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn inserting_or_deleting_cells_cancels_copy_mode() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
s.execute("edit.cut", json!({"range": "3:3"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "3:3"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
// The cut data is now in row 4; a paste must not move the new blank row 3 instead.
|
||
assert!(s.execute("edit.paste", json!({"at": "A10"})).is_err());
|
||
assert_eq!(v(&s, "A4"), Value::Number(3.0));
|
||
s.execute("edit.copy", json!({"range": "A:A"})).unwrap();
|
||
s.execute("home.deleteColumns", json!({"cols": "B:B"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
s.execute("edit.copy", json!({"range": "A1"})).unwrap();
|
||
s.execute("home.insertCells", json!({"range": "A1", "shift": "down"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
s.execute("edit.copy", json!({"range": "A2"})).unwrap();
|
||
s.execute("home.deleteCells", json!({"range": "A1", "shift": "up"})).unwrap();
|
||
assert!(s.clipboard.is_none());
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [3]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1:A2", "target": "A1:A6"})).unwrap();
|
||
assert_eq!(v(&s, "A6"), Value::Number(11.0));
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "Mon"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "B1", "target": "B1:B3"})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::from("Wed"));
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "Item 9"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "C1", "target": "C1:C2"})).unwrap();
|
||
assert_eq!(v(&s, "C2"), Value::from("Item 10"));
|
||
}
|
||
|
||
#[test]
|
||
fn ctrl_drag_fill_swaps_copy_and_series() {
|
||
// Issue #264: Ctrl+drag fills a lone number as a series, and copies what a plain drag extends.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "7"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1", "target": "A1:A4"})).unwrap();
|
||
assert_eq!(v(&s, "A4"), Value::Number(7.0), "a plain drag copies a lone number");
|
||
s.execute("edit.autoFill", json!({"source": "A1", "target": "A1:A4", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Number(8.0));
|
||
assert_eq!(v(&s, "A4"), Value::Number(10.0));
|
||
// Upward too.
|
||
s.execute("cell.set", json!({"cell": "B5", "input": "7"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "B5", "target": "B3:B5", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::Number(5.0));
|
||
// A two-number series, a list entry and text with a number are copied.
|
||
s.execute("range.setValues", json!({"range": "C1", "values": [[1], [3]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "C1:C2", "target": "C1:C4", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "C3"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "C4"), Value::Number(3.0));
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "Mon"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "D1", "target": "D1:D3", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "D3"), Value::from("Mon"));
|
||
s.execute("cell.set", json!({"cell": "E1", "input": "Item 9"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "E1", "target": "E1:E2", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "E2"), Value::from("Item 9"));
|
||
// Plain text copies either way; an empty source clears.
|
||
s.execute("cell.set", json!({"cell": "F1", "input": "abc"})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "F1", "target": "F1:F2", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "F2"), Value::from("abc"));
|
||
s.execute("edit.autoFill", json!({"source": "G1", "target": "G1:G3", "mode": "alternate"})).unwrap();
|
||
assert_eq!(v(&s, "G3"), Value::Empty);
|
||
}
|
||
|
||
#[test]
|
||
fn insert_delete_cells_adjust() {
|
||
let formula = |s: &mut Session, a: &str| s.execute("cell.get", json!({"cell": a})).unwrap()["formula"].clone();
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3], [4], [5]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=SUM(A1:A5)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=A4*10"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C3", "input": "=SUM(A1:B5)"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Fourth", "refersTo": "=Sheet1!$A$4"})).unwrap();
|
||
s.execute(
|
||
"home.conditionalFormat",
|
||
json!({"range": "A4:A5", "rule": {"type": "cellIs", "operator": "greater", "value": "3", "preset": "redText"}}),
|
||
)
|
||
.unwrap();
|
||
s.execute("data.validation", json!({"range": "A5", "type": "whole", "operator": "greater", "formula1": "0"})).unwrap();
|
||
s.execute("insert.chart", json!({"range": "A1:A5", "type": "line"})).unwrap();
|
||
// Insert A3 shifting down: ranges across the insertion grow, references below move.
|
||
s.execute("home.insertCells", json!({"range": "A3", "shift": "down"})).unwrap();
|
||
assert_eq!(formula(&mut s, "C1"), "=SUM(A1:A6)");
|
||
assert_eq!(formula(&mut s, "C2"), "=A5*10");
|
||
assert_eq!(formula(&mut s, "C3"), "=SUM(A1:B5)");
|
||
assert_eq!(v(&s, "C2"), Value::Number(40.0));
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
assert_eq!(s.doc().unwrap().wb.names[0].formula, "Sheet1!$A$5");
|
||
assert_eq!(sh.cond_formats[0].ranges[0].a1(), "A5:A6");
|
||
assert_eq!(sh.validations[0].ranges[0].a1(), "A6");
|
||
assert_eq!(sh.charts[0].series[0].values, "Sheet1!$A$1:$A$6");
|
||
// Delete A5 (the 4) shifting up: references to it become #REF!, those below move up.
|
||
s.execute("home.deleteCells", json!({"range": "A5", "shift": "up"})).unwrap();
|
||
assert_eq!(formula(&mut s, "C1"), "=SUM(A1:A5)");
|
||
assert_eq!(formula(&mut s, "C2"), "=#REF!*10");
|
||
assert_eq!(s.doc().unwrap().wb.names[0].formula, "#REF!");
|
||
assert_eq!(v(&s, "C1"), Value::Number(11.0));
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
assert_eq!(sh.cond_formats[0].ranges[0].a1(), "A5");
|
||
assert_eq!(sh.validations[0].ranges[0].a1(), "A5");
|
||
assert_eq!(sh.charts[0].series[0].values, "Sheet1!$A$1:$A$5");
|
||
// Shifting right and left.
|
||
s.execute("range.setValues", json!({"range": "E1", "values": [[1, 2, 3]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E3", "input": "=G1+SUM(E1:G1)"})).unwrap();
|
||
s.execute("home.insertCells", json!({"range": "F1", "shift": "right"})).unwrap();
|
||
assert_eq!(formula(&mut s, "E3"), "=H1+SUM(E1:H1)");
|
||
s.execute("home.deleteCells", json!({"range": "E1:F1", "shift": "left"})).unwrap();
|
||
assert_eq!(formula(&mut s, "E3"), "=F1+SUM(E1:F1)");
|
||
assert_eq!(v(&s, "E3"), Value::Number(8.0));
|
||
}
|
||
|
||
#[test]
|
||
fn sort_and_filter() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
s.execute("selection.set", json!({"cell": "B2"})).unwrap();
|
||
s.execute("data.sortDescending", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::from("c"));
|
||
assert_eq!(v(&s, "A1"), Value::from("Name"));
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
let r = s.execute("data.filterBy", json!({"column": "B", "custom": {"op": ">", "value": "1"}})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 1);
|
||
}
|
||
|
||
/// Turning the filter on with only the header row selected filters the data below it (#201).
|
||
#[test]
|
||
fn filter_on_a_selected_header_row_covers_the_data_below() {
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["Name", "City"], ["Ana", "SP"], ["Bia", "RJ"], ["Caio", "SP"], ["Duda", "BH"], ["Eva", "RJ"]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("selection.set", json!({"range": "A1:B1"})).unwrap();
|
||
let r = s.execute("data.filter", json!({})).unwrap();
|
||
assert_eq!(r["range"], "A1:B6");
|
||
let r = s.execute("data.filterBy", json!({"column": "B", "values": ["SP"]})).unwrap();
|
||
assert_eq!(r["hiddenRows"], 3);
|
||
// An explicit range is taken as given.
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
let r = s.execute("data.filter", json!({"range": "A1:B1"})).unwrap();
|
||
assert_eq!(r["range"], "A1:B1");
|
||
}
|
||
|
||
#[test]
|
||
fn protection_passwords_stay_out_of_the_journal_and_recorded_scripts() {
|
||
const PW: &str = "synthetic-pw-7319";
|
||
let mut s = s();
|
||
s.execute("automate.recordActions", json!({})).unwrap();
|
||
s.execute("review.protectSheet", json!({"password": PW, "formatCells": true})).unwrap();
|
||
// The password still protects the sheet; the refused attempt isn't journaled.
|
||
assert!(s.execute("review.unprotectSheet", json!({})).is_err());
|
||
s.execute("review.unprotectSheet", json!({"password": PW})).unwrap();
|
||
s.execute("automate.recordActions", json!({"stop": true, "name": "Lock"})).unwrap();
|
||
|
||
let journal = serde_json::to_string(&s.journal).unwrap();
|
||
assert!(!journal.contains(PW), "{journal}");
|
||
let params = |s: &Session, id: &str| s.journal.iter().find(|(c, _)| c == id).map(|(_, p)| p.clone());
|
||
assert_eq!(params(&s, "review.protectSheet"), Some(json!({"formatCells": true})));
|
||
assert_eq!(params(&s, "review.unprotectSheet"), Some(json!({})));
|
||
|
||
// The recorded script is stored in the workbook, so it is saved with the file.
|
||
let bytes = crate::io::save_bytes(&s.doc().unwrap().wb, "book.xlsx").unwrap();
|
||
let (reopened, _) = crate::io::open_bytes("book.xlsx", &bytes).unwrap();
|
||
let script = reopened.names.iter().find(|n| n.name == "_sc_scripts").map(|n| n.formula.clone()).unwrap();
|
||
assert!(script.contains("review.protectSheet"), "{script}");
|
||
assert!(!script.contains(PW), "{script}");
|
||
|
||
// The journal still replays: protection without a password, then unprotection.
|
||
let mut r = self::s();
|
||
for (id, p) in s.journal.iter().filter(|(id, _)| !id.starts_with("automate.")) {
|
||
r.execute(id, p.clone()).unwrap_or_else(|e| panic!("{id}: {e}"));
|
||
let prot = r.doc().unwrap().wb.active().unwrap().protection.clone();
|
||
if id == "review.protectSheet" {
|
||
assert!(prot.as_ref().is_some_and(|p| p.format_cells && p.password_hash.is_none()), "{prot:?}");
|
||
}
|
||
}
|
||
assert!(r.doc().unwrap().wb.active().unwrap().protection.is_none());
|
||
s.execute("automate.runScript", json!({"name": "Lock"})).unwrap();
|
||
}
|
||
|
||
/// A sheet with locked data in A1:B3, unlocked cells in D1:D3 and row 10, then protected.
|
||
fn protected(extra: serde_json::Value) -> Session {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1], [2], [3]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=A1+D1"})).unwrap();
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[10], [20], [30]]})).unwrap();
|
||
s.execute("home.lockCell", json!({"range": "D1:D3", "on": false})).unwrap();
|
||
s.execute("home.lockCell", json!({"range": "10:10", "on": false})).unwrap();
|
||
s.execute("review.protectSheet", extra).unwrap();
|
||
s
|
||
}
|
||
|
||
#[test]
|
||
fn protection_refuses_edits_of_locked_cells() {
|
||
let refused = |s: &mut Session, id: &str, p: serde_json::Value| {
|
||
let before = s.doc().unwrap().wb.clone();
|
||
let e = s.execute(id, p).expect_err(id).to_string();
|
||
assert!(e.contains("protected sheet"), "{id}: {e}");
|
||
assert_eq!(*s.doc().unwrap().wb, *before, "{id} changed the workbook");
|
||
};
|
||
let mut s = protected(json!({}));
|
||
refused(&mut s, "cell.set", json!({"cell": "A1", "input": "9"}));
|
||
refused(&mut s, "edit.clearContents", json!({"range": "A1:A3"}));
|
||
refused(&mut s, "edit.clearAll", json!({"range": "A1"}));
|
||
refused(&mut s, "range.setValues", json!({"range": "A2", "values": [[9]]}));
|
||
refused(&mut s, "range.fill", json!({"range": "A5:A6", "input": "x"}));
|
||
refused(&mut s, "edit.fillDown", json!({"range": "A1:A3"}));
|
||
refused(&mut s, "edit.fillRight", json!({"range": "A1:B1"}));
|
||
refused(&mut s, "edit.fillUp", json!({"range": "A1:A3"}));
|
||
refused(&mut s, "edit.fillLeft", json!({"range": "A1:B1"}));
|
||
refused(&mut s, "edit.autoFill", json!({"source": "A1", "target": "A1:A5"}));
|
||
s.execute("edit.copy", json!({"range": "D1"})).unwrap();
|
||
refused(&mut s, "edit.paste", json!({"at": "A2"}));
|
||
refused(&mut s, "edit.paste", json!({"at": "A2", "text": "x\ty"}));
|
||
refused(&mut s, "home.deleteRows", json!({"rows": "2:2"}));
|
||
refused(&mut s, "home.deleteColumns", json!({"cols": "A:A"}));
|
||
refused(&mut s, "home.insertRows", json!({"rows": "1:1"}));
|
||
refused(&mut s, "home.deleteCells", json!({"range": "A1", "shift": "up"}));
|
||
refused(&mut s, "home.insertCells", json!({"range": "A1", "shift": "down"}));
|
||
refused(&mut s, "edit.replace", json!({"what": "2", "with": "5"}));
|
||
refused(&mut s, "data.goalSeek", json!({"set": "B1", "to": 50, "changing": "A1"}));
|
||
// Unlocked cells stay editable.
|
||
s.execute("edit.paste", json!({"at": "D2"})).unwrap();
|
||
assert_eq!(v(&s, "D2"), Value::Number(10.0));
|
||
s.execute("range.setValues", json!({"range": "D2", "values": [[5]]})).unwrap();
|
||
s.execute("edit.fillDown", json!({"range": "D1:D3"})).unwrap();
|
||
assert_eq!(v(&s, "D3"), Value::Number(10.0));
|
||
s.execute("edit.clearContents", json!({"range": "D3"})).unwrap();
|
||
assert_eq!(v(&s, "D3"), Value::Empty);
|
||
s.execute("data.goalSeek", json!({"set": "B1", "to": 50, "changing": "D1"})).unwrap();
|
||
assert!((v(&s, "B1").as_f64().unwrap() - 50.0).abs() < 0.001);
|
||
s.execute("edit.replace", json!({"what": "49", "with": "48", "wholeCell": true})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(1.0));
|
||
}
|
||
|
||
#[test]
|
||
fn protection_allows_permitted_row_and_column_edits() {
|
||
let mut s = protected(json!({"insertRows": true, "deleteRows": true, "insertColumns": true}));
|
||
// Inserting shifts locked cells, which the protection allows.
|
||
s.execute("home.insertRows", json!({"rows": "1:1"})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Number(1.0));
|
||
s.execute("home.insertColumns", json!({"cols": "A:A"})).unwrap();
|
||
// Deleting a row with locked cells isn't; deleting an unlocked row is.
|
||
assert!(s.execute("home.deleteRows", json!({"rows": "2:2"})).is_err());
|
||
s.execute("home.deleteRows", json!({"rows": "11:11"})).unwrap();
|
||
assert!(s.execute("home.deleteColumns", json!({"cols": "Z:Z"})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn hidden_formulas_stay_hidden_on_protected_sheets() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)*7"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=1+1"})).unwrap();
|
||
s.execute("home.formatCells", json!({"range": "A1", "style": {"protection": {"locked": true, "hidden": true}}})).unwrap();
|
||
s.execute("formulas.showFormulas", json!({"on": true})).unwrap();
|
||
let text = |s: &Session, a: &str| {
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
crate::display::cell_text(&d.wb, sh, CellRef::parse(a).unwrap())
|
||
};
|
||
assert_eq!(text(&s, "A1"), "=SEQUENCE(3)*7");
|
||
assert_eq!(s.execute("edit.find", json!({"what": "SEQUENCE", "all": true})).unwrap()["count"], 1);
|
||
s.execute("review.protectSheet", json!({})).unwrap();
|
||
assert_eq!(text(&s, "A1"), "7");
|
||
assert_eq!(text(&s, "B1"), "=1+1");
|
||
let d = s.doc().unwrap();
|
||
let sh = d.wb.active().unwrap();
|
||
assert!(crate::display::formula_hidden(&d.wb, sh, CellRef::parse("A2").unwrap()));
|
||
assert!(!crate::display::formula_hidden(&d.wb, sh, CellRef::parse("B1").unwrap()));
|
||
assert!(s.execute("edit.find", json!({"what": "SEQUENCE", "all": true})).is_err());
|
||
let r = s.execute("edit.find", json!({"what": "7", "all": true})).unwrap();
|
||
assert_eq!(r["results"][0]["value"], "7");
|
||
}
|
||
|
||
#[test]
|
||
fn case_sensitive_sort_puts_lowercase_first() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["b"], ["B"], ["Ab"], ["a"], ["aB"], ["A"]]})).unwrap();
|
||
s.execute("data.sort", json!({"range": "A1:A6", "header": false, "matchCase": true, "keys": [{"column": "A"}]})).unwrap();
|
||
let col: Vec<Value> = (1..=6).map(|r| v(&s, &format!("A{r}"))).collect();
|
||
assert_eq!(col, ["a", "A", "aB", "Ab", "b", "B"].map(Value::from));
|
||
}
|
||
|
||
#[test]
|
||
fn remove_duplicates_compares_shown_text() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Date", "Price"], ["2006-03-08", 1.01], ["2006-03-08", 1.02]]})).unwrap();
|
||
s.execute("home.numberFormat", json!({"range": "A3", "code": "mmm d, yyyy"})).unwrap();
|
||
s.execute("home.numberFormat", json!({"range": "B2:B3", "code": "0.0"})).unwrap();
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "A1:A3", "header": true})).unwrap();
|
||
assert_eq!(r["removed"], 0);
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "B1:B3", "header": true})).unwrap();
|
||
assert_eq!(r["removed"], 1);
|
||
}
|
||
|
||
#[test]
|
||
fn formatting_and_styles() {
|
||
let mut s = s();
|
||
s.execute("selection.set", json!({"range": "A1:B2"})).unwrap();
|
||
s.execute("home.bold", json!({})).unwrap();
|
||
s.execute("home.fillColor", json!({"color": "#FFFF00"})).unwrap();
|
||
s.execute("home.mergeCenter", json!({})).unwrap();
|
||
let c = s.execute("cell.get", json!({"cell": "B2"})).unwrap();
|
||
assert_eq!(c["style"]["font"]["bold"], true);
|
||
assert_eq!(c["merge"], "A1:B2");
|
||
s.execute("home.cellStyle", json!({"range": "D1", "name": "Good"})).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn spill_references_roundtrip_through_xlsx() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SEQUENCE(4)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "=sum(b1#)"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Seq", "refersTo": "=Sheet1!$B$1#"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=MAX(Seq)"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "C1"})).unwrap()["formula"], "=SUM(B1#)");
|
||
assert_eq!((v(&s, "C1"), v(&s, "C2")), (Value::Number(10.0), Value::Number(4.0)));
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "C1"})).unwrap()["formula"], "=SUM(B1#)");
|
||
assert_eq!(s.doc().unwrap().wb.names[0].formula, "Sheet1!$B$1#");
|
||
assert_eq!((v(&s, "C1"), v(&s, "C2")), (Value::Number(10.0), Value::Number(4.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn tables_and_structured_refs() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Item", "Qty"], ["x", 2], ["y", 5]]})).unwrap();
|
||
s.execute("insert.table", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "=SUM(Table1[Qty])"})).unwrap();
|
||
assert_eq!(v(&s, "D1"), Value::Number(7.0));
|
||
s.execute("table.totalRow", json!({"on": true, "table": "Table1"})).unwrap();
|
||
assert_eq!(v(&s, "B4"), Value::Number(7.0));
|
||
}
|
||
|
||
#[test]
|
||
fn create_names_from_selection() {
|
||
let names = |s: &Session| -> Vec<(String, String)> {
|
||
let mut v: Vec<_> = s.doc().unwrap().wb.names.iter().map(|n| (n.name.clone(), n.formula.clone())).collect();
|
||
v.sort();
|
||
v
|
||
};
|
||
let named = |n: &str, f: &str| (n.to_string(), f.to_string());
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["", "Jan", "Feb", ""], ["North", 1, 2, "N"], ["South", 3, 4, "S"], ["", "First", "Second", ""]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("formulas.createFromSelection", json!({"range": "A1:D4", "top": false, "bottom": true, "right": true})).unwrap();
|
||
assert_eq!(
|
||
names(&s),
|
||
[named("First", "Sheet1!$B$1:$B$3"), named("N", "Sheet1!$A$2:$C$2"), named("S", "Sheet1!$A$3:$C$3"), named("Second", "Sheet1!$C$1:$C$3")]
|
||
);
|
||
// Existing names are kept unless replacing is asked for.
|
||
let r = s.execute("formulas.createFromSelection", json!({"range": "A1:C3", "top": true, "left": true})).unwrap();
|
||
assert_eq!(r["created"], 4);
|
||
let r = s.execute("formulas.createFromSelection", json!({"range": "B1:C3", "top": true})).unwrap();
|
||
assert_eq!((r["created"].clone(), r["skipped"].clone()), (json!(0), json!(["Jan", "Feb"])));
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "N"})).unwrap();
|
||
let r = s.execute("formulas.createFromSelection", json!({"range": "B1:B3", "replace": true})).unwrap();
|
||
assert_eq!(r["created"], 1);
|
||
assert!(names(&s).contains(&named("N", "Sheet1!$B$2:$B$3")));
|
||
assert!(names(&s).contains(&named("North", "Sheet1!$B$2:$C$2")));
|
||
}
|
||
|
||
#[test]
|
||
fn names_that_look_like_references_are_refused() {
|
||
let mut s = s();
|
||
for bad in ["R1C1", "r2", "C3", "RC", "R", "c", "rc12", "A1", "XFD1048576", "1st"] {
|
||
assert!(s.execute("formulas.defineName", json!({"name": bad, "refersTo": "=1"})).is_err(), "{bad}");
|
||
}
|
||
for good in ["R1C1X", "Rate", "RCx", "Rx", "_R1", "Cost"] {
|
||
s.execute("formulas.defineName", json!({"name": good, "refersTo": "=1"})).unwrap();
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn lambda_names_keep_their_case_in_calls() {
|
||
let mut s = s();
|
||
s.execute("formulas.defineName", json!({"name": "Double", "refersTo": "=LAMBDA(x,x*2)"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Quad", "refersTo": "=LAMBDA(x,Double(Double(x)))"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=double(4)+Quad(1)+sum(1)"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["formula"], "=Double(4)+Quad(1)+SUM(1)");
|
||
assert_eq!(v(&s, "A1"), Value::Number(13.0));
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["formula"], "=Double(4)+Quad(1)+SUM(1)");
|
||
let quad = s.doc().unwrap().wb.names.iter().find(|n| n.name == "Quad").unwrap().formula.clone();
|
||
assert_eq!(quad, "LAMBDA(x,Double(Double(x)))");
|
||
assert_eq!(v(&s, "A1"), Value::Number(13.0));
|
||
}
|
||
|
||
#[test]
|
||
fn sheets() {
|
||
let mut s = s();
|
||
s.execute("home.insertSheet", json!({})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "5"})).unwrap();
|
||
s.execute("sheet.rename", json!({"name": "Data"})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": 0})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=Data!A1*2"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(10.0));
|
||
s.execute("sheet.rename", json!({"sheet": "Data", "name": "My Data"})).unwrap();
|
||
assert_eq!(s.execute("cell.get", json!({"cell": "A1"})).unwrap()["formula"], "='My Data'!A1*2");
|
||
}
|
||
|
||
#[test]
|
||
fn sheet_operations_keep_names_on_their_sheets() {
|
||
let names = |s: &Session| -> Vec<(String, Option<String>, String)> {
|
||
let wb = &s.doc().unwrap().wb;
|
||
let mut v: Vec<_> =
|
||
wb.names.iter().map(|n| (n.name.clone(), n.scope.and_then(|i| wb.sheet(i)).map(|s| s.name.clone()), n.formula.clone())).collect();
|
||
v.sort();
|
||
v
|
||
};
|
||
let named = |n: &str, scope: Option<&str>, f: &str| (n.to_string(), scope.map(str::to_string), f.to_string());
|
||
let mut s = s();
|
||
s.execute("home.insertSheet", json!({"name": "Data"})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Notes"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Rate", "refersTo": "=Data!$A$1", "scope": "Data"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Rate", "refersTo": "=Notes!$B$1", "scope": "Notes"})).unwrap();
|
||
s.execute("formulas.defineName", json!({"name": "Total", "refersTo": "=Data!$C$1"})).unwrap();
|
||
// Moving Data (index 1) to the end: its names go with it.
|
||
s.execute("sheet.move", json!({"sheet": "Data", "to": 2})).unwrap();
|
||
assert_eq!(names(&s), [named("Rate", Some("Data"), "Data!$A$1"), named("Rate", Some("Notes"), "Notes!$B$1"), named("Total", None, "Data!$C$1")]);
|
||
// Copying Data to the front copies its sheet-level names, referring to the copy.
|
||
s.execute("sheet.move", json!({"sheet": "Data", "to": 0, "copy": true})).unwrap();
|
||
assert_eq!(s.doc().unwrap().wb.sheets[0].name, "Data (2)");
|
||
assert_eq!(
|
||
names(&s),
|
||
[
|
||
named("Rate", Some("Data"), "Data!$A$1"),
|
||
named("Rate", Some("Data (2)"), "'Data (2)'!$A$1"),
|
||
named("Rate", Some("Notes"), "Notes!$B$1"),
|
||
named("Total", None, "Data!$C$1")
|
||
]
|
||
);
|
||
// Deleting Data removes its names; names referring to it become #REF!.
|
||
s.execute("home.deleteSheet", json!({"sheet": "Data"})).unwrap();
|
||
assert_eq!(
|
||
names(&s),
|
||
[named("Rate", Some("Data (2)"), "'Data (2)'!$A$1"), named("Rate", Some("Notes"), "Notes!$B$1"), named("Total", None, "#REF!")]
|
||
);
|
||
// Deleting a name in one scope keeps the others.
|
||
s.execute("formulas.deleteName", json!({"name": "rate", "scope": "Notes"})).unwrap();
|
||
assert_eq!(names(&s), [named("Rate", Some("Data (2)"), "'Data (2)'!$A$1"), named("Total", None, "#REF!")]);
|
||
assert!(s.execute("formulas.deleteName", json!({"name": "Total", "scope": "Notes"})).is_err());
|
||
s.execute("formulas.deleteName", json!({"name": "Total", "scope": "Workbook"})).unwrap();
|
||
assert_eq!(names(&s).len(), 1);
|
||
}
|
||
|
||
#[test]
|
||
fn deleting_a_3d_span_end_sheet_keeps_the_rest() {
|
||
let book = || {
|
||
let mut s = s();
|
||
for name in ["Sheet2", "Sheet3", "Results"] {
|
||
s.execute("home.insertSheet", json!({"name": name})).unwrap();
|
||
}
|
||
for (sheet, n) in [("Sheet1", 3), ("Sheet2", 5), ("Sheet3", 7)] {
|
||
s.execute("sheet.activate", json!({"sheet": sheet})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": n.to_string()})).unwrap();
|
||
}
|
||
s.execute("sheet.activate", json!({"sheet": "Results"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SUM(Sheet1:Sheet3!A1)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=Sheet1!A1"})).unwrap();
|
||
s
|
||
};
|
||
let gone = Value::Error(gridcraft_core::CellError::Ref);
|
||
for (deleted, total, direct) in [("Sheet1", 12.0, gone), ("Sheet3", 8.0, Value::Number(3.0)), ("Sheet2", 10.0, Value::Number(3.0))] {
|
||
let mut s = book();
|
||
s.execute("home.deleteSheet", json!({"sheet": deleted})).unwrap();
|
||
s.execute("sheet.activate", json!({"sheet": "Results"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(total), "deleting {deleted}");
|
||
assert_eq!(v(&s, "B1"), direct, "deleting {deleted}");
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn xlsx_roundtrip_through_engine() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["a", 1], ["b", 2]]})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B3", "input": "=SUM(B1:B2)"})).unwrap();
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
assert_eq!(v(&s, "B3"), Value::Number(3.0));
|
||
}
|
||
|
||
fn ods_fixture() -> Vec<u8> {
|
||
use std::io::{Cursor, Write};
|
||
let mut zip = zip::ZipWriter::new(Cursor::new(Vec::new()));
|
||
let options = zip::write::SimpleFileOptions::default().compression_method(zip::CompressionMethod::Stored);
|
||
for (name, data) in [
|
||
("mimetype", "application/vnd.oasis.opendocument.spreadsheet"),
|
||
(
|
||
"META-INF/manifest.xml",
|
||
r#"<manifest:manifest xmlns:manifest="urn:oasis:names:tc:opendocument:xmlns:manifest:1.0" manifest:version="1.3"><manifest:file-entry manifest:full-path="/" manifest:media-type="application/vnd.oasis.opendocument.spreadsheet"/><manifest:file-entry manifest:full-path="content.xml" manifest:media-type="text/xml"/></manifest:manifest>"#,
|
||
),
|
||
(
|
||
"content.xml",
|
||
r#"<office:document-content xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" office:version="1.3"><office:body><office:spreadsheet><table:table table:name="Data"><table:table-row><table:table-cell office:value-type="float" office:value="42" table:formula="of:=SUM([.B1:.B2])"/><table:table-cell office:value-type="string"><text:p>Original data</text:p></table:table-cell></table:table-row></table:table></office:spreadsheet></office:body></office:document-content>"#,
|
||
),
|
||
] {
|
||
zip.start_file(name, options).unwrap();
|
||
zip.write_all(data.as_bytes()).unwrap();
|
||
}
|
||
zip.finish().unwrap().into_inner()
|
||
}
|
||
|
||
#[test]
|
||
fn ods_import_keeps_cached_values_and_reports_limits() {
|
||
let bytes = ods_fixture();
|
||
assert_eq!(gridcraft_xlsx::sniff(&bytes), gridcraft_xlsx::Format::Ods);
|
||
for name in ["source.ods", "source.xlsx"] {
|
||
let mut s = s();
|
||
let r = s.execute("file.open", json!({"name": name, "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
assert!(!r["warnings"].as_array().unwrap().is_empty());
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Message(_))));
|
||
assert!(s.doc().unwrap().path.is_none());
|
||
assert!(s.doc().unwrap().display_title().ends_with(".xlsx"));
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
assert_eq!(v(&s, "B1"), Value::from("Original data"));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("A1").unwrap()).unwrap().formula.is_none());
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "imported.xlsx", "base64": saved["base64"]})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn ods_import_never_reuses_source_as_save_target() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-ods-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let bytes = ods_fixture();
|
||
for name in ["source.ods", "disguised.xlsx"] {
|
||
let path = dir.join(name);
|
||
std::fs::write(&path, &bytes).unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path})).unwrap();
|
||
s.take_ui_requests();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "43"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Dialog(name, _) if name == "saveAs")));
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
assert!(s.execute("file.saveAs", json!({"path": dir.join("source.ods")})).is_err());
|
||
assert!(s.execute("file.saveBytes", json!({"format": "ods"})).is_err());
|
||
let output = dir.join("converted.xlsx");
|
||
s.execute("file.saveAs", json!({"path": output})).unwrap();
|
||
assert!(!s.doc().unwrap().is_dirty());
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
s.execute("file.open", json!({"name": "converted.xlsx", "base64": crate::io::base64_encode(&std::fs::read(output).unwrap())})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(43.0));
|
||
}
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn samples_build() {
|
||
for (name, _) in crate::sample::SAMPLES {
|
||
let wb = crate::sample::build(name).unwrap_or_else(|| panic!("sample {name}"));
|
||
assert!(!wb.sheets[0].cells.is_empty());
|
||
}
|
||
}
|
||
|
||
/// Original minimal BIFF12 records, built in source rather than a vendor workbook fixture.
|
||
fn xlsb_fixture() -> Vec<u8> {
|
||
use std::io::{Cursor, Write};
|
||
fn wide(s: &str) -> Vec<u8> {
|
||
let units: Vec<_> = s.encode_utf16().collect();
|
||
(units.len() as u32).to_le_bytes().into_iter().chain(units.into_iter().flat_map(u16::to_le_bytes)).collect()
|
||
}
|
||
fn record(out: &mut Vec<u8>, id: u16, payload: &[u8]) {
|
||
if id < 128 {
|
||
out.push(id as u8);
|
||
} else {
|
||
out.extend([(id as u8 & 127) | 128, (id >> 7) as u8]);
|
||
}
|
||
let mut size = payload.len();
|
||
while size >= 128 {
|
||
out.push((size as u8 & 127) | 128);
|
||
size >>= 7;
|
||
}
|
||
out.push(size as u8);
|
||
out.extend(payload);
|
||
}
|
||
let mut book = vec![];
|
||
record(&mut book, 131, &[]); // BeginBook
|
||
record(&mut book, 143, &[]); // BeginBundleShs
|
||
let mut bundle = vec![0; 4]; // Visible
|
||
bundle.extend(1u32.to_le_bytes());
|
||
bundle.extend(wide("rId1"));
|
||
bundle.extend(wide("Imported"));
|
||
record(&mut book, 156, &bundle);
|
||
record(&mut book, 144, &[]);
|
||
record(&mut book, 132, &[]);
|
||
let mut sheet = vec![];
|
||
record(&mut sheet, 129, &[]); // BeginSheet
|
||
record(&mut sheet, 145, &[]); // BeginSheetData
|
||
record(&mut sheet, 0, &[0; 17]); // Row 0, no spans
|
||
let mut numeric = vec![0; 8]; // A1, default style
|
||
numeric.extend(42.0f64.to_le_bytes());
|
||
numeric.extend([0; 2]); // Formula flags
|
||
numeric.extend(3u32.to_le_bytes());
|
||
numeric.extend([0x1e, 42, 0]); // PtgInt(42)
|
||
numeric.extend(0u32.to_le_bytes());
|
||
record(&mut sheet, 9, &numeric); // FmlaNum
|
||
let mut text = 1u32.to_le_bytes().to_vec(); // B1
|
||
text.extend(0u32.to_le_bytes());
|
||
text.extend(wide("Original data"));
|
||
record(&mut sheet, 6, &text);
|
||
record(&mut sheet, 146, &[]);
|
||
record(&mut sheet, 130, &[]);
|
||
let mut zip = zip::ZipWriter::new(Cursor::new(Vec::new()));
|
||
let types = br#"<Types xmlns="http://schemas.openxmlformats.org/package/2006/content-types"><Override PartName="/xl/workbook.bin" ContentType="application/vnd.ms-excel.sheet.binary.macroEnabled.main"/><Override PartName="/xl/worksheets/sheet1.bin" ContentType="application/vnd.ms-excel.worksheet"/></Types>"#;
|
||
let rels = br#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument" Target="xl/workbook.bin"/></Relationships>"#;
|
||
let book_rels = br#"<Relationships xmlns="http://schemas.openxmlformats.org/package/2006/relationships"><Relationship Id="rId1" Type="http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet" Target="worksheets/sheet1.bin"/></Relationships>"#;
|
||
for (name, data) in [
|
||
("[Content_Types].xml", types.as_slice()),
|
||
("_rels/.rels", rels.as_slice()),
|
||
("xl/_rels/workbook.bin.rels", book_rels.as_slice()),
|
||
("xl/workbook.bin", book.as_slice()),
|
||
("xl/worksheets/sheet1.bin", sheet.as_slice()),
|
||
] {
|
||
zip.start_file(name, zip::write::SimpleFileOptions::default()).unwrap();
|
||
zip.write_all(data).unwrap();
|
||
}
|
||
zip.finish().unwrap().into_inner()
|
||
}
|
||
|
||
#[test]
|
||
fn replacing_a_spilling_formula_clears_its_spill() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "=SUM(A1:A3)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "2"})).unwrap();
|
||
assert_eq!((v(&s, "A2"), v(&s, "A3"), v(&s, "B1")), (Value::Empty, Value::Empty, Value::Number(2.0)));
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("edit.clearContents", json!({"range": "A1"})).unwrap();
|
||
assert_eq!((v(&s, "A2"), v(&s, "B1")), (Value::Empty, Value::Number(0.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn range_ending_in_index_recalculates() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B6", "input": "=SUM(C3:INDEX(B9:C11,2,2))"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C5", "input": "2"})).unwrap();
|
||
assert_eq!(v(&s, "B6"), Value::Number(2.0));
|
||
}
|
||
|
||
#[test]
|
||
fn structural_edits_move_spills_with_their_formula() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A5", "input": "=SEQUENCE(3)"})).unwrap();
|
||
s.execute("home.deleteRows", json!({"rows": "1:1"})).unwrap();
|
||
let col = |s: &Session| (4..=7).map(|r| v(s, &format!("A{r}"))).collect::<Vec<_>>();
|
||
assert_eq!(col(&s), [Value::Number(1.0), Value::Number(2.0), Value::Number(3.0), Value::Empty]);
|
||
s.execute("home.deleteRows", json!({"rows": "4:4"})).unwrap();
|
||
assert_eq!(col(&s), [Value::Empty, Value::Empty, Value::Empty, Value::Empty]);
|
||
}
|
||
|
||
#[test]
|
||
fn clearing_a_distant_blocker_unblocks_the_spill() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "=SEQUENCE(100)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A90", "input": "x"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Error(gridcraft_core::CellError::Spill));
|
||
s.execute("edit.clearContents", json!({"range": "A90"})).unwrap();
|
||
assert_eq!((v(&s, "A1"), v(&s, "A100")), (Value::Number(1.0), Value::Number(100.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn a_spill_that_goes_away_unblocks_another() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "F8", "input": "=SEQUENCE(5)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E10", "input": "=SEQUENCE(1,3)"})).unwrap();
|
||
assert_eq!(v(&s, "E10"), Value::Error(gridcraft_core::CellError::Spill));
|
||
// Blocking F8's array frees F10 for E10's.
|
||
s.execute("cell.set", json!({"cell": "F9", "input": "0"})).unwrap();
|
||
assert_eq!(v(&s, "F8"), Value::Error(gridcraft_core::CellError::Spill));
|
||
assert_eq!((v(&s, "E10"), v(&s, "G10")), (Value::Number(1.0), Value::Number(3.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn an_array_reading_another_arrays_spill_is_updated() {
|
||
// G5 is evaluated before D11 in the same pass, so it first reads D11's old spill.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "D11", "input": "=SEQUENCE(1,3,A1)"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "G5", "input": "=UNIQUE(VSTACK(F9:F12,A1))"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "10"})).unwrap();
|
||
assert_eq!((v(&s, "G6"), v(&s, "G7")), (Value::Number(12.0), Value::Number(10.0)));
|
||
s.execute("formulas.calculateNow", json!({})).unwrap();
|
||
assert_eq!((v(&s, "G6"), v(&s, "G7")), (Value::Number(12.0), Value::Number(10.0)));
|
||
}
|
||
|
||
#[test]
|
||
fn indirect_reads_a_spill_laid_out_in_the_same_pass() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "F5", "input": "=SEQUENCE(2,2,7)"})).unwrap();
|
||
s.execute("home.insertRows", json!({"rows": "3:3"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "E5", "input": "=INDIRECT(\"F7\")"})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(9.0));
|
||
s.execute("formulas.calculateNow", json!({})).unwrap();
|
||
assert_eq!(v(&s, "E5"), Value::Number(9.0));
|
||
}
|
||
|
||
#[test]
|
||
fn every_command_survives_empty_params() {
|
||
let mut s = Session::new();
|
||
s.execute("file.new", json!({"sample": "sales"})).unwrap();
|
||
for spec in crate::command_specs() {
|
||
if matches!(spec.id, "file.close" | "file.open" | "file.save" | "file.saveAs" | "file.exportCsv" | "file.exportHtml" | "insert.picture") {
|
||
continue;
|
||
}
|
||
let _ = s.execute(spec.id, json!({}));
|
||
let _ = s.execute(spec.id, json!([1, 2]));
|
||
let _ = s.execute(spec.id, json!({"range": "ZZZ999999999", "cell": "", "sheet": 99}));
|
||
}
|
||
}
|
||
|
||
fn fmt_of(s: &Session, a: &str) -> String {
|
||
let wb = &s.doc().unwrap().wb;
|
||
let sh = wb.active().unwrap();
|
||
wb.styles.get(sh.style_id(CellRef::parse(a).unwrap())).num_fmt.as_str().to_string()
|
||
}
|
||
|
||
#[test]
|
||
fn checkboxes_keep_values_toggle_and_delete_in_two_passes() {
|
||
// Issue #196.
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "hi"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "TRUE"})).unwrap();
|
||
s.execute("insert.checkbox", json!({"range": "A1:B2"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Bool(false), "an empty cell starts unchecked");
|
||
assert_eq!(v(&s, "B1"), Value::from("hi"), "other values stay");
|
||
s.execute("cell.toggleCheckbox", json!({"cell": "A1"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Bool(true));
|
||
// Space over a selection toggles only checkbox cells; an emptied checkbox counts as FALSE.
|
||
s.execute("cell.set", json!({"cell": "A2", "input": ""})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A2:C2"})).unwrap();
|
||
s.execute("cell.toggleCheckbox", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A2"), Value::Bool(true));
|
||
s.execute("selection.set", json!({"range": "C1"})).unwrap();
|
||
s.execute("cell.toggleCheckbox", json!({})).unwrap();
|
||
assert_eq!(v(&s, "C1"), Value::Bool(true), "a plain TRUE is not a checkbox");
|
||
// Delete: checked boxes are unchecked first, then the boxes go.
|
||
s.execute("edit.clearContents", json!({"range": "A1:A2"})).unwrap();
|
||
assert_eq!((v(&s, "A1"), v(&s, "A2")), (Value::Bool(false), Value::Bool(false)));
|
||
assert_eq!(fmt_of(&s, "A1"), "checkbox");
|
||
s.execute("edit.clearContents", json!({"range": "A1:A2"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Empty);
|
||
assert_ne!(fmt_of(&s, "A1"), "checkbox");
|
||
// Clear Formats removes the box and keeps the value (B2 was checked by the selection toggle).
|
||
s.execute("edit.clearFormats", json!({"range": "B2"})).unwrap();
|
||
assert_eq!(v(&s, "B2"), Value::Bool(true));
|
||
assert_ne!(fmt_of(&s, "B2"), "checkbox");
|
||
}
|
||
|
||
#[test]
|
||
fn checkboxes_survive_xlsx_as_cell_controls() {
|
||
let mut s = s();
|
||
s.execute("insert.checkbox", json!({"range": "A1:A2"})).unwrap();
|
||
s.execute("cell.toggleCheckbox", json!({"cell": "A1"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "0.5"})).unwrap();
|
||
reopen(&mut s);
|
||
assert_eq!(fmt_of(&s, "A1"), "checkbox");
|
||
assert_eq!(fmt_of(&s, "A2"), "checkbox");
|
||
assert_eq!(fmt_of(&s, "B1"), "General");
|
||
assert_eq!(v(&s, "A1"), Value::Bool(true));
|
||
assert_eq!(v(&s, "A2"), Value::Bool(false));
|
||
}
|
||
|
||
#[test]
|
||
fn file_options_reports_settings_and_asks_for_the_options_page() {
|
||
let mut s = Session::new();
|
||
// No workbook: nothing to report, but still no error.
|
||
assert_eq!(s.execute("file.options", json!({})).unwrap(), json!({"calculation": null}));
|
||
s.take_ui_requests();
|
||
s.new_workbook();
|
||
s.execute("formulas.calculationOptions", json!({"mode": "manual", "iterative": true})).unwrap();
|
||
let before = s.active().unwrap().wb.clone();
|
||
let r = s.execute("file.options", json!({})).unwrap();
|
||
assert_eq!(r["calculation"]["mode"], "manual");
|
||
assert_eq!(r["calculation"]["iterative"], true);
|
||
assert!(matches!(s.take_ui_requests().as_slice(), [crate::UiRequest::Dialog(name, _)] if name == "options"));
|
||
assert_eq!(s.active().unwrap().wb, before, "Options never changes the workbook");
|
||
}
|
||
|
||
fn reopen(s: &mut Session) {
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
}
|
||
|
||
fn chart_data(s: &mut Session) {
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["", "Open", "High", "Low", "Close"], ["Mon", 10, 14, 9, 12], ["Tue", 12, 15, 11, 14], ["Wed", 14, 16, 10, 11], ["Thu", 11, 13, 8, 9], ["Fri", 9, 12, 7, 11], ["Sat", 11, 15, 10, 14]]}),
|
||
)
|
||
.unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn every_chart_kind_survives_xlsx() {
|
||
use gridcraft_model::ChartKind;
|
||
let kinds = [
|
||
("combo", ChartKind::Combo),
|
||
("stock", ChartKind::Stock),
|
||
("histogram", ChartKind::Histogram),
|
||
("boxWhisker", ChartKind::BoxWhisker),
|
||
("waterfall", ChartKind::Waterfall),
|
||
("funnel", ChartKind::Funnel),
|
||
("treemap", ChartKind::Treemap),
|
||
("sunburst", ChartKind::Sunburst),
|
||
("column", ChartKind::ColumnClustered),
|
||
("line", ChartKind::Line),
|
||
("scatter", ChartKind::Scatter),
|
||
];
|
||
for (t, kind) in kinds {
|
||
let mut s = s();
|
||
chart_data(&mut s);
|
||
s.execute("insert.chart", json!({"type": t, "range": "A1:E7", "title": "Week"})).unwrap();
|
||
let before = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert_eq!(before.kind, kind);
|
||
reopen(&mut s);
|
||
assert!(s.doc().unwrap().wb.names.is_empty(), "{t}");
|
||
let after = &s.doc().unwrap().wb.active().unwrap().charts[0];
|
||
assert_eq!(after.kind, kind, "{t}");
|
||
assert_eq!(after.title.as_deref(), Some("Week"), "{t}");
|
||
assert_eq!(after.series.len(), before.series.len(), "{t}");
|
||
for (a, b) in after.series.iter().zip(&before.series) {
|
||
assert_eq!((&a.name, &a.values, &a.color), (&b.name, &b.values, &b.color), "{t}");
|
||
// A histogram bins its values; it has no categories in the file.
|
||
if kind != ChartKind::Histogram {
|
||
assert_eq!(a.categories, b.categories, "{t}");
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
fn whole_sheet_selection_stays_within_the_data() {
|
||
// On an empty sheet with everything selected these filled or scanned every cell of the
|
||
// sheet, running out of memory or time.
|
||
let mut s = s();
|
||
s.execute("edit.selectAll", json!({})).unwrap();
|
||
for cmd in ["edit.fillDown", "edit.fillRight", "edit.fillUp", "edit.fillLeft", "data.removeDuplicates"] {
|
||
s.execute(cmd, json!({})).unwrap();
|
||
}
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2], [3, 4], [5, 6]]})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A1:XFD1048576"})).unwrap();
|
||
s.execute("edit.fillUp", json!({})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(5.0));
|
||
assert!(s.execute("edit.fillDown", json!({"range": "A1:Z1000000"})).is_err(), "too large to fill");
|
||
assert!(s.execute("edit.autoFill", json!({"source": "A1:XFD1048576", "target": "A1"})).is_err(), "too large to fill");
|
||
s.execute("range.setValues", json!({"range": "D1", "values": [[1], [1], [2]]})).unwrap();
|
||
let r = s.execute("data.removeDuplicates", json!({"range": "D:D", "header": false})).unwrap();
|
||
assert_eq!((r["removed"].clone(), r["remaining"].clone()), (json!(1), json!(2)));
|
||
assert!(s.execute("data.removeDuplicates", json!({"range": "A1:XFD1048576", "header": false})).is_ok());
|
||
}
|
||
|
||
#[test]
|
||
fn parity_counts() {
|
||
let (done, total) = crate::catalog::parity();
|
||
assert!(total > 250);
|
||
assert!(done > 150, "parity {done}/{total}");
|
||
}
|
||
|
||
#[test]
|
||
fn switch_row_column_on_a_chart_read_from_a_file() {
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["", "North", "South", "East", "West"], ["Mon", 10, 14, 9, 12], ["Tue", 12, 15, 11, 14], ["Wed", 14, 16, 10, 11], ["Thu", 11, 13, 8, 9], ["Fri", 9, 12, 7, 11], ["Sat", 11, 15, 10, 14]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("insert.chart", json!({"type": "column", "range": "A1:E7"})).unwrap();
|
||
let r = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
let b64 = r["base64"].as_str().unwrap().to_string();
|
||
s.execute("file.open", json!({"name": "x.xlsx", "base64": b64})).unwrap();
|
||
let chart = |s: &Session| s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert_eq!((chart(&s).source, chart(&s).series.len()), (None, 4));
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
let c = chart(&s);
|
||
assert!(c.by_rows);
|
||
assert_eq!(c.source.as_deref(), Some("Sheet1!A1:E7"));
|
||
assert_eq!(c.series.len(), 6);
|
||
assert_eq!(c.series[0].name.as_deref(), Some("Sheet1!$A$2"));
|
||
assert_eq!(c.series[0].categories.as_deref(), Some("Sheet1!$B$1:$E$1"));
|
||
assert_eq!(c.series[0].values, "Sheet1!$B$2:$E$2");
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
assert_eq!(chart(&s).series.len(), 4);
|
||
}
|
||
|
||
#[test]
|
||
fn switch_row_column_with_whole_column_refs_is_bounded() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["", "North", "South"], ["Mon", 10, 14], ["Tue", 12, 15], ["Wed", 14, 16]]}))
|
||
.unwrap();
|
||
s.execute("insert.chart", json!({"type": "column", "range": "A1:C4"})).unwrap();
|
||
// As read from a file: no source block, series over whole columns.
|
||
let whole = |s: &mut Session| {
|
||
let c = &mut std::sync::Arc::make_mut(&mut s.doc_mut().unwrap().wb).sheet_mut(0).unwrap().charts[0];
|
||
c.source = None;
|
||
c.by_rows = false;
|
||
c.series.truncate(2);
|
||
for (i, col) in ["B", "C"].iter().enumerate() {
|
||
c.series[i].name = None;
|
||
c.series[i].categories = Some("Sheet1!$A:$A".into());
|
||
c.series[i].values = format!("Sheet1!${col}:${col}");
|
||
}
|
||
};
|
||
whole(&mut s);
|
||
s.execute("chart.switchRowColumn", json!({})).unwrap();
|
||
let c = s.doc().unwrap().wb.active().unwrap().charts[0].clone();
|
||
assert!(c.by_rows);
|
||
// Clipped to the used rows, not a million series.
|
||
assert_eq!(c.series.len(), 3);
|
||
// A used range that is itself enormous is refused rather than charted.
|
||
s.execute("cell.set", json!({"cell": "C1048576", "input": "1"})).unwrap();
|
||
whole(&mut s);
|
||
assert!(s.execute("chart.switchRowColumn", json!({})).is_err());
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().charts[0].series.len(), 2);
|
||
}
|
||
|
||
#[test]
|
||
fn ink_strokes_and_ink_to_shape() {
|
||
let mut s = s();
|
||
// A rough closed box.
|
||
let pts: Vec<[f64; 2]> = vec![[100.0, 100.0], [200.0, 102.0], [201.0, 180.0], [99.0, 181.0], [101.0, 104.0]];
|
||
s.execute("draw.stroke", json!({"points": pts})).unwrap();
|
||
let sh = s.doc().unwrap().wb.active().unwrap().clone();
|
||
assert_eq!(sh.shapes.len(), 1);
|
||
assert_eq!(sh.shapes[0].kind, gridcraft_model::ShapeKind::Ink);
|
||
let r = s.execute("draw.inkToShape", json!({})).unwrap();
|
||
assert_eq!(r["kind"], "Rectangle");
|
||
// An open stroke becomes a line.
|
||
s.execute("draw.stroke", json!({"points": [[0.0, 0.0], [50.0, 10.0], [120.0, 30.0]]})).unwrap();
|
||
assert_eq!(s.execute("draw.inkToShape", json!({})).unwrap()["kind"], "Line");
|
||
assert!(s.execute("draw.stroke", json!({"points": [[1.0, 1.0]]})).is_err());
|
||
}
|
||
|
||
#[test]
|
||
fn xlsb_import_keeps_cached_values_and_reports_limits() {
|
||
let bytes = xlsb_fixture();
|
||
assert_eq!(gridcraft_xlsx::sniff(&bytes), gridcraft_xlsx::Format::Xlsb);
|
||
for name in ["source.xlsb", "source.xlsx"] {
|
||
let mut s = s();
|
||
let r = s.execute("file.open", json!({"name": name, "base64": crate::io::base64_encode(&bytes)})).unwrap();
|
||
assert!(!r["warnings"].as_array().unwrap().is_empty());
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Message(_))));
|
||
assert!(s.doc().unwrap().path.is_none());
|
||
assert!(s.doc().unwrap().display_title().ends_with(".xlsx"));
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
assert_eq!(v(&s, "B1"), Value::from("Original data"));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("A1").unwrap()).unwrap().formula.is_none());
|
||
s.execute("cell.set", json!({"cell": "B1", "input": "Changed"})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0)); // Imported formula caches are constants.
|
||
let saved = s.execute("file.saveBytes", json!({"format": "xlsx"})).unwrap();
|
||
s.execute("file.open", json!({"name": "imported.xlsx", "base64": saved["base64"]})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(42.0));
|
||
}
|
||
}
|
||
|
||
#[test]
|
||
#[cfg(not(target_arch = "wasm32"))]
|
||
fn xlsb_import_never_reuses_source_as_save_target() {
|
||
#[allow(clippy::disallowed_methods)] // native-only test: a unique temp dir name
|
||
let nonce = std::time::SystemTime::now().duration_since(std::time::UNIX_EPOCH).unwrap().as_nanos();
|
||
let dir = std::env::temp_dir().join(format!("gridcraft-xlsb-{}-{nonce}", std::process::id()));
|
||
std::fs::create_dir(&dir).unwrap();
|
||
let bytes = xlsb_fixture();
|
||
for name in ["source.xlsb", "disguised.xlsx"] {
|
||
let path = dir.join(name);
|
||
std::fs::write(&path, &bytes).unwrap();
|
||
let mut s = s();
|
||
s.execute("file.open", json!({"path": path})).unwrap();
|
||
s.take_ui_requests();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "43"})).unwrap();
|
||
s.execute("file.save", json!({})).unwrap();
|
||
assert!(s.take_ui_requests().iter().any(|r| matches!(r, crate::UiRequest::Dialog(name, _) if name == "saveAs")));
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
assert!(s.execute("file.saveAs", json!({"path": dir.join("source.xlsb")})).is_err());
|
||
assert!(s.execute("file.saveBytes", json!({"format": "xlsb"})).is_err());
|
||
let output = dir.join("converted.xlsx");
|
||
s.execute("file.saveAs", json!({"path": output})).unwrap();
|
||
assert!(!s.doc().unwrap().is_dirty());
|
||
assert_eq!(std::fs::read(&path).unwrap(), bytes);
|
||
s.execute("file.open", json!({"name": "converted.xlsx", "base64": crate::io::base64_encode(&std::fs::read(output).unwrap())})).unwrap();
|
||
assert_eq!(v(&s, "A1"), Value::Number(43.0));
|
||
}
|
||
std::fs::remove_dir_all(dir).unwrap();
|
||
}
|
||
|
||
#[test]
|
||
fn malformed_xlsb_keeps_the_current_workbook() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "Keep me"})).unwrap();
|
||
assert!(s.execute("file.open", json!({"name": "bad.xlsb", "base64": crate::io::base64_encode(b"not a workbook")})).is_err());
|
||
assert_eq!(s.documents().len(), 1);
|
||
assert_eq!(v(&s, "A1"), Value::from("Keep me"));
|
||
assert!(s.doc().unwrap().is_dirty());
|
||
}
|
||
|
||
/// A 2×2 PNG, so objects can be injected into a workbook in tests.
|
||
fn tiny_png() -> Vec<u8> {
|
||
let img = image::RgbaImage::from_raw(2, 2, vec![255, 0, 0, 255, 0, 255, 0, 128, 0, 0, 255, 255, 0, 0, 0, 0]).unwrap();
|
||
let mut png = Vec::new();
|
||
image::DynamicImage::ImageRgba8(img).write_to(&mut std::io::Cursor::new(&mut png), image::ImageFormat::Png).unwrap();
|
||
png
|
||
}
|
||
|
||
fn add_image(s: &mut Session, cell: &str, mode: gridcraft_model::AnchorMode) -> u32 {
|
||
let d = s.doc_mut().unwrap();
|
||
let wb = std::sync::Arc::make_mut(&mut d.wb);
|
||
let id = wb.next_object_id();
|
||
wb.sheet_mut(0).unwrap().images.push(gridcraft_model::Image {
|
||
id,
|
||
anchor: gridcraft_model::Anchor { cell: CellRef::parse(cell).unwrap(), dx: 0.0, dy: 0.0, width: 40.0, height: 40.0, mode },
|
||
data: tiny_png(),
|
||
mime: "image/png".into(),
|
||
alt: String::new(),
|
||
});
|
||
id
|
||
}
|
||
|
||
fn image_cell(s: &Session, id: u32) -> Option<CellRef> {
|
||
s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id).map(|i| i.anchor.cell)
|
||
}
|
||
|
||
/// Issue #5: images anchored in cells follow their row when the sheet is sorted.
|
||
#[test]
|
||
fn sort_moves_anchored_images_with_their_rows() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
// One picture per data row, in its own row.
|
||
let ib = add_image(&mut s, "A2", AnchorMode::MoveAndSize);
|
||
let ic = add_image(&mut s, "A3", AnchorMode::MoveAndSize);
|
||
let ia = add_image(&mut s, "A4", AnchorMode::MoveAndSize);
|
||
s.execute("selection.set", json!({"range": "A1:B4"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"header": true, "column": "A"})).unwrap();
|
||
// Ascending by name: b, c, a → a, b, c. Each picture lands in its row's new home.
|
||
assert_eq!(image_cell(&s, ib), Some(CellRef::parse("A3").unwrap()));
|
||
assert_eq!(image_cell(&s, ic), Some(CellRef::parse("A4").unwrap()));
|
||
assert_eq!(image_cell(&s, ia), Some(CellRef::parse("A2").unwrap()));
|
||
}
|
||
|
||
/// An `absolute`-pinned object stays exactly where it was drawn across a sort and a row delete.
|
||
#[test]
|
||
fn absolute_objects_ignore_sort_and_structural_edits() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
let pinned = add_image(&mut s, "A3", AnchorMode::Absolute);
|
||
s.execute("selection.set", json!({"range": "A1:B4"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"header": true, "column": "A"})).unwrap();
|
||
assert_eq!(image_cell(&s, pinned), Some(CellRef::parse("A3").unwrap()));
|
||
s.execute("home.deleteRows", json!({"rows": "2:2"})).unwrap();
|
||
assert_eq!(image_cell(&s, pinned), Some(CellRef::parse("A3").unwrap()));
|
||
}
|
||
|
||
/// A "move but don't size" object follows its row across a sort but keeps its size.
|
||
#[test]
|
||
fn move_only_objects_follow_but_do_not_resize() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "N"], ["b", 2], ["a", 1]]})).unwrap();
|
||
let id = add_image(&mut s, "A2", AnchorMode::MoveOnly);
|
||
s.execute("selection.set", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"column": "A"})).unwrap();
|
||
// "a" moved to row 2 and "b" to row 3, so the image follows from A2 to A3.
|
||
assert_eq!(image_cell(&s, id), Some(CellRef::parse("A3").unwrap()));
|
||
let a = s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id).unwrap().anchor;
|
||
assert_eq!((a.width, a.height), (40.0, 40.0));
|
||
}
|
||
|
||
/// `object.setAnchorMode` changes how an object follows its cells.
|
||
#[test]
|
||
fn set_anchor_mode_changes_following() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "N"], ["b", 2], ["a", 1]]})).unwrap();
|
||
let id = add_image(&mut s, "A2", AnchorMode::MoveAndSize);
|
||
let r = s.execute("object.setAnchorMode", json!({"kind": "image", "id": id, "mode": "dontMoveOrSizeWithCells"})).unwrap();
|
||
assert_eq!(r["mode"], "absolute");
|
||
s.execute("selection.set", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"column": "A"})).unwrap();
|
||
// Pinned absolute: it stays put even though its row moved.
|
||
assert_eq!(image_cell(&s, id), Some(CellRef::parse("A2").unwrap()));
|
||
// A bad mode is rejected, not silently ignored.
|
||
assert!(s.execute("object.setAnchorMode", json!({"kind": "image", "id": id, "mode": "sideways"})).is_err());
|
||
}
|
||
|
||
/// A sort moves only objects anchored inside the sorted block on both axes: a picture beside
|
||
/// the block (same rows, other columns) stays where it is.
|
||
#[test]
|
||
fn sort_leaves_objects_outside_the_block_alone() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Name", "Score"], ["b", 2], ["c", 3], ["a", 1]]})).unwrap();
|
||
let beside = add_image(&mut s, "Z3", AnchorMode::MoveAndSize);
|
||
let inside = add_image(&mut s, "B3", AnchorMode::MoveAndSize);
|
||
s.execute("selection.set", json!({"range": "A1:B4"})).unwrap();
|
||
s.execute("data.sortAscending", json!({"header": true, "column": "A"})).unwrap();
|
||
assert_eq!(image_cell(&s, beside), Some(CellRef::parse("Z3").unwrap()));
|
||
// "c" moved from row 3 to row 4, taking the picture in B3 with it.
|
||
assert_eq!(image_cell(&s, inside), Some(CellRef::parse("B4").unwrap()));
|
||
}
|
||
|
||
/// Inserted pictures default to Excel's "Move but don't size with cells".
|
||
#[test]
|
||
fn inserted_pictures_move_but_do_not_size() {
|
||
let mut s = s();
|
||
let b64 = crate::io::base64_encode(&tiny_png());
|
||
let id = s.execute("insert.picture", json!({"base64": b64, "at": "C3"})).unwrap()["image"].as_u64().unwrap() as u32;
|
||
let mode = |s: &Session| s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id).unwrap().anchor.mode;
|
||
assert_eq!(mode(&s), gridcraft_model::AnchorMode::MoveOnly);
|
||
let b64 = crate::io::base64_encode(&tiny_png());
|
||
let id2 = s.execute("insert.picture", json!({"base64": b64, "mode": "absolute"})).unwrap()["image"].as_u64().unwrap() as u32;
|
||
let m2 = s.doc().unwrap().wb.active().unwrap().images.iter().find(|i| i.id == id2).unwrap().anchor.mode;
|
||
assert_eq!(m2, gridcraft_model::AnchorMode::Absolute);
|
||
}
|
||
|
||
/// `object.setAnchorMode` needs a real object kind.
|
||
#[test]
|
||
fn set_anchor_mode_rejects_unknown_kind() {
|
||
use gridcraft_model::AnchorMode;
|
||
let mut s = s();
|
||
let id = add_image(&mut s, "A2", AnchorMode::MoveAndSize);
|
||
for kind in [json!(""), json!("widget"), serde_json::Value::Null] {
|
||
assert!(s.execute("object.setAnchorMode", json!({"kind": kind, "id": id, "mode": "absolute"})).is_err());
|
||
}
|
||
let mode = |s: &Session| s.doc().unwrap().wb.active().unwrap().images[0].anchor.mode;
|
||
assert_eq!(mode(&s), AnchorMode::MoveAndSize);
|
||
s.execute("object.setAnchorMode", json!({"kind": "image", "id": id, "mode": "moveOnly"})).unwrap();
|
||
assert_eq!(mode(&s), AnchorMode::MoveOnly);
|
||
}
|
||
|
||
fn original_cell_picture() -> Vec<u8> {
|
||
let image = image::RgbaImage::from_fn(4, 2, |x, _| if x < 2 { image::Rgba([240, 60, 40, 255]) } else { image::Rgba([20, 100, 240, 128]) });
|
||
let mut png = Vec::new();
|
||
image::DynamicImage::ImageRgba8(image).write_to(&mut std::io::Cursor::new(&mut png), image::ImageFormat::Png).unwrap();
|
||
png
|
||
}
|
||
|
||
fn insert_cell_picture(s: &mut Session, at: &str, alt: &str) {
|
||
s.execute("insert.picture", json!({"placement": "cell", "at": at, "base64": crate::io::base64_encode(&original_cell_picture()), "alt": alt}))
|
||
.unwrap();
|
||
}
|
||
|
||
fn cell_picture(s: &Session, at: &str) -> Option<std::sync::Arc<gridcraft_model::CellPicture>> {
|
||
s.doc().unwrap().wb.active().unwrap().cell_pictures.get(&CellRef::parse(at).unwrap()).cloned()
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_insert_validates_content_preserves_style_and_replaces_with_undo() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "old"})).unwrap();
|
||
s.execute("home.bold", json!({"range": "B2"})).unwrap();
|
||
for bytes in [b"not an image".as_slice(), b"GIF89a", &original_cell_picture()[..24]] {
|
||
assert!(s.execute("insert.picture", json!({"placement": "cell", "at": "B2", "base64": crate::io::base64_encode(bytes)})).is_err());
|
||
assert_eq!(v(&s, "B2"), Value::from("old"));
|
||
}
|
||
insert_cell_picture(&mut s, "B2", "Original picture");
|
||
assert_eq!(v(&s, "B2"), Value::Error(gridcraft_core::CellError::Value));
|
||
let state = s.execute("cell.get", json!({"cell": "B2"})).unwrap();
|
||
assert_eq!(state["type"], "picture");
|
||
assert_eq!(state["text"], "#VALUE!");
|
||
assert_eq!(state["input"], "");
|
||
assert_eq!(state["picture"]["alt"], "Original picture");
|
||
assert!(state["picture"].get("data").is_none());
|
||
assert_eq!(state["style"]["font"]["bold"], true);
|
||
assert!(s.doc().unwrap().wb.active().unwrap().images.is_empty());
|
||
s.execute("cell.set", json!({"cell": "B2", "input": "=2+3"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
assert_eq!(v(&s, "B2"), Value::Number(5.0));
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(cell_picture(&s, "B2").unwrap().alt, "Original picture");
|
||
s.execute("range.setValues", json!({"range": "B2", "values": [[7]]})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
let mut jpeg = Vec::new();
|
||
image::DynamicImage::ImageRgb8(image::RgbImage::from_pixel(2, 1, image::Rgb([60, 80, 100])))
|
||
.write_to(&mut std::io::Cursor::new(&mut jpeg), image::ImageFormat::Jpeg)
|
||
.unwrap();
|
||
s.execute("insert.picture", json!({"placement": "cell", "at": "D2", "base64": crate::io::base64_encode(&jpeg), "mime": "wrong/client-mime"}))
|
||
.unwrap();
|
||
assert_eq!(cell_picture(&s, "D2").unwrap().mime, "image/jpeg");
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_clipboard_clear_and_structural_edits_keep_complete_payload() {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "moves with the row");
|
||
let original = cell_picture(&s, "B2").unwrap();
|
||
s.execute("edit.copy", json!({"range": "B2"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "values", "at": "D2"})).unwrap();
|
||
assert!(std::sync::Arc::ptr_eq(&original, &cell_picture(&s, "D2").unwrap()));
|
||
s.execute("home.bold", json!({"range": "C1"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "C1"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "formats", "at": "D2"})).unwrap();
|
||
assert_eq!(cell_picture(&s, "D2").unwrap().alt, original.alt);
|
||
s.execute("edit.clearFormats", json!({"range": "D2"})).unwrap();
|
||
assert!(cell_picture(&s, "D2").is_some());
|
||
s.execute("edit.clearContents", json!({"range": "D2"})).unwrap();
|
||
assert!(cell_picture(&s, "D2").is_none());
|
||
s.execute("cell.set", json!({"cell": "C1", "input": "3"})).unwrap();
|
||
s.execute("edit.copy", json!({"range": "B2"})).unwrap();
|
||
s.execute("edit.pasteSpecial", json!({"what": "values", "at": "C1", "operation": "add"})).unwrap();
|
||
assert!(cell_picture(&s, "C1").is_none());
|
||
assert_eq!(v(&s, "C1"), Value::Error(gridcraft_core::CellError::Value));
|
||
s.execute("home.insertRows", json!({"rows": "2:2"})).unwrap();
|
||
s.execute("home.insertColumns", json!({"cols": "B:B"})).unwrap();
|
||
assert_eq!(cell_picture(&s, "C3").unwrap().alt, original.alt);
|
||
s.execute("edit.cut", json!({"range": "C3"})).unwrap();
|
||
s.execute("home.insertSheet", json!({"name": "Destination"})).unwrap();
|
||
s.execute("edit.paste", json!({"at": "E4"})).unwrap();
|
||
assert_eq!(cell_picture(&s, "E4").unwrap().alt, original.alt);
|
||
assert!(s.doc().unwrap().wb.sheet(0).unwrap().cell(CellRef::parse("C3").unwrap()).is_none());
|
||
s.execute("home.deleteColumns", json!({"cols": "E:E"})).unwrap();
|
||
assert!(cell_picture(&s, "E4").is_none());
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert_eq!(cell_picture(&s, "E4").unwrap().data, original.data);
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_follows_sort_filter_and_blocks_formula_spills() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["Rank", "Picture"], [2], [1]]})).unwrap();
|
||
insert_cell_picture(&mut s, "B2", "rank two");
|
||
insert_cell_picture(&mut s, "B3", "rank one");
|
||
s.execute("data.sort", json!({"range": "A1:B3", "header": true, "keys": [{"column": "A", "order": "asc"}]})).unwrap();
|
||
assert_eq!(cell_picture(&s, "B2").unwrap().alt, "rank one");
|
||
assert_eq!(cell_picture(&s, "B3").unwrap().alt, "rank two");
|
||
s.execute("selection.set", json!({"range": "A1:B3"})).unwrap();
|
||
s.execute("data.filter", json!({})).unwrap();
|
||
s.execute("data.filterBy", json!({"column": "A", "values": ["1"]})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().is_row_hidden(2));
|
||
assert!(cell_picture(&s, "B3").is_some());
|
||
insert_cell_picture(&mut s, "D2", "spill obstruction");
|
||
s.execute("cell.set", json!({"cell": "D1", "input": "=SEQUENCE(2)"})).unwrap();
|
||
assert_eq!(v(&s, "D1"), Value::Error(gridcraft_core::CellError::Spill));
|
||
s.execute("edit.clearContents", json!({"range": "D2"})).unwrap();
|
||
assert_eq!(v(&s, "D1"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "D2"), Value::Number(2.0));
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_json_save_retains_content_and_pdf_draws_without_error_text() {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "original pixels");
|
||
let saved = s.execute("file.saveBytes", json!({"format": "json"})).unwrap();
|
||
s.execute("file.open", json!({"name": "pictures.json", "base64": saved["base64"]})).unwrap();
|
||
assert_eq!(cell_picture(&s, "B2").unwrap().data, original_cell_picture());
|
||
let pdf = s.execute("file.exportPdf", json!({"range": "A1:C3"})).unwrap();
|
||
let data = crate::io::base64_decode(pdf["base64"].as_str().unwrap()).unwrap();
|
||
let pdf_text = String::from_utf8_lossy(&data);
|
||
assert!(pdf_text.contains("/Subtype /Image"));
|
||
assert!(!pdf_text.contains("(#VALUE!) Tj"));
|
||
s.execute("home.hideRows", json!({"rows": "2:2"})).unwrap();
|
||
let pdf = s.execute("file.exportPdf", json!({"range": "A1:C3"})).unwrap();
|
||
let data = crate::io::base64_decode(pdf["base64"].as_str().unwrap()).unwrap();
|
||
assert!(!String::from_utf8_lossy(&data).contains("/Subtype /Image"));
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_side_map_follows_fill_shift_merge_and_undo() {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "shared pixels");
|
||
let original = cell_picture(&s, "B2").unwrap();
|
||
s.execute("edit.fillDown", json!({"range": "B2:B4"})).unwrap();
|
||
for at in ["B2", "B3", "B4"] {
|
||
assert!(std::sync::Arc::ptr_eq(&original, &cell_picture(&s, at).unwrap()));
|
||
}
|
||
s.execute("edit.autoFill", json!({"source": "A2", "target": "A2:B2", "mode": "formats"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_some());
|
||
s.execute("edit.autoFill", json!({"source": "A3", "target": "A3:B3", "mode": "copy"})).unwrap();
|
||
assert!(cell_picture(&s, "B3").is_none());
|
||
s.execute("home.insertCells", json!({"range": "B2", "shift": "down"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
assert!(cell_picture(&s, "B3").is_some());
|
||
assert!(cell_picture(&s, "B5").is_some());
|
||
s.execute("home.deleteCells", json!({"range": "B3", "shift": "up"})).unwrap();
|
||
assert!(cell_picture(&s, "B3").is_none());
|
||
assert!(cell_picture(&s, "B4").is_some());
|
||
s.execute("home.mergeCells", json!({"range": "A4:B4"})).unwrap();
|
||
assert!(cell_picture(&s, "B4").is_none());
|
||
s.execute("edit.undo", json!({})).unwrap();
|
||
assert!(cell_picture(&s, "B4").is_some());
|
||
s.execute("edit.clearAll", json!({"range": "A1:C5"})).unwrap();
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell_pictures.is_empty());
|
||
insert_cell_picture(&mut s, "XFD1048576", "grid edge");
|
||
assert!(s.execute("home.insertRows", json!({"rows": "1048576:1048576"})).is_err());
|
||
assert_eq!(cell_picture(&s, "XFD1048576").unwrap().alt, "grid edge");
|
||
}
|
||
|
||
#[test]
|
||
fn cell_picture_cut_uses_live_source_after_edit() {
|
||
for clear in [false, true] {
|
||
let mut s = s();
|
||
insert_cell_picture(&mut s, "B2", "original");
|
||
s.execute("edit.cut", json!({"range": "B2"})).unwrap();
|
||
if clear {
|
||
s.execute("edit.clearContents", json!({"range": "B2"})).unwrap();
|
||
} else {
|
||
insert_cell_picture(&mut s, "B2", "replacement");
|
||
}
|
||
s.execute("edit.paste", json!({"at": "D2"})).unwrap();
|
||
assert!(cell_picture(&s, "B2").is_none());
|
||
if clear {
|
||
assert!(cell_picture(&s, "D2").is_none());
|
||
assert_eq!(v(&s, "D2"), Value::Empty);
|
||
} else {
|
||
assert_eq!(cell_picture(&s, "D2").unwrap().alt, "replacement");
|
||
assert_eq!(v(&s, "D2"), Value::Error(gridcraft_core::CellError::Value));
|
||
}
|
||
}
|
||
}
|
||
|
||
fn ymd(y: i64, m: i64, d: i64) -> Value {
|
||
Value::Number(gridcraft_core::date::serial_from_ymd(gridcraft_core::DateSystem::D1900, y, m, d).unwrap())
|
||
}
|
||
|
||
fn series_date(seed: &str, range: &str, unit: &str) -> Session {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": seed})).unwrap();
|
||
s.execute("edit.fillSeries", json!({"range": range, "direction": "columns", "type": "date", "dateUnit": unit})).unwrap();
|
||
s
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_month_clamps_to_month_end() {
|
||
let s = series_date("2026-01-31", "A1:A4", "month");
|
||
assert_eq!(v(&s, "A1"), ymd(2026, 1, 31));
|
||
assert_eq!(v(&s, "A2"), ymd(2026, 2, 28));
|
||
assert_eq!(v(&s, "A3"), ymd(2026, 3, 31));
|
||
assert_eq!(v(&s, "A4"), ymd(2026, 4, 30));
|
||
// Mid-month seeds are untouched.
|
||
let s = series_date("2026-01-15", "A1:A4", "month");
|
||
assert_eq!(v(&s, "A4"), ymd(2026, 4, 15));
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_month_leap_year() {
|
||
let s = series_date("2028-01-31", "A1:A3", "month");
|
||
assert_eq!(v(&s, "A2"), ymd(2028, 2, 29));
|
||
assert_eq!(v(&s, "A3"), ymd(2028, 3, 31));
|
||
let s = series_date("1996-01-31", "A1:A3", "month");
|
||
assert_eq!(v(&s, "A2"), ymd(1996, 2, 29));
|
||
}
|
||
|
||
#[test]
|
||
fn fill_series_year_clamps_leap_day() {
|
||
let s = series_date("2028-02-29", "A1:A5", "year");
|
||
assert_eq!(v(&s, "A2"), ymd(2029, 2, 28));
|
||
assert_eq!(v(&s, "A5"), ymd(2032, 2, 29));
|
||
}
|
||
|
||
#[test]
|
||
fn autofill_month_pattern_clamps_to_month_end() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [["2026-01-31"], ["2026-03-31"]]})).unwrap();
|
||
s.execute("edit.autoFill", json!({"source": "A1:A2", "target": "A1:A6"})).unwrap();
|
||
assert_eq!(v(&s, "A3"), ymd(2026, 5, 31));
|
||
assert_eq!(v(&s, "A4"), ymd(2026, 7, 31));
|
||
assert_eq!(v(&s, "A5"), ymd(2026, 9, 30));
|
||
assert_eq!(v(&s, "A6"), ymd(2026, 11, 30));
|
||
}
|
||
|
||
#[test]
|
||
fn notes_comments_and_links_survive_a_json_save() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "x"})).unwrap();
|
||
s.execute("review.newNote", json!({"cell": "A1", "text": "note", "author": "Example"})).unwrap();
|
||
s.execute("review.newComment", json!({"cell": "B2", "text": "comment", "author": "Example"})).unwrap();
|
||
s.execute("insert.link", json!({"cell": "C3", "target": "Sheet1!A1", "tooltip": "jump"})).unwrap();
|
||
let wb = &s.doc().unwrap().wb;
|
||
let bytes = crate::io::save_bytes(wb, "book.json").unwrap();
|
||
let (back, _) = crate::io::open_bytes("book.json", &bytes).unwrap();
|
||
let (before, after) = (wb.active().unwrap(), back.active().unwrap());
|
||
assert_eq!((before.comments.len(), before.hyperlinks.len()), (2, 1));
|
||
assert_eq!(after.comments, before.comments);
|
||
assert_eq!(after.hyperlinks, before.hyperlinks);
|
||
assert_eq!(after.cells, before.cells);
|
||
}
|
||
|
||
#[test]
|
||
fn vertical_alignment_commands_and_roundtrip() {
|
||
let mut s = s();
|
||
s.execute("cell.set", json!({"cell": "A1", "input": "top"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A2", "input": "middle"})).unwrap();
|
||
s.execute("cell.set", json!({"cell": "A3", "input": "bottom"})).unwrap();
|
||
|
||
s.execute("selection.set", json!({"range": "A1"})).unwrap();
|
||
s.execute("home.alignTop", json!({})).unwrap();
|
||
|
||
s.execute("selection.set", json!({"range": "A2"})).unwrap();
|
||
s.execute("home.alignMiddle", json!({})).unwrap();
|
||
|
||
s.execute("selection.set", json!({"range": "A3"})).unwrap();
|
||
s.execute("home.alignBottom", json!({})).unwrap();
|
||
|
||
let style_of = |s: &Session, cell: &str| {
|
||
let d = s.doc().unwrap();
|
||
d.wb.styles.get(d.wb.active().unwrap().style_id(CellRef::parse(cell).unwrap())).clone()
|
||
};
|
||
|
||
assert_eq!(style_of(&s, "A1").align.v, gridcraft_model::VAlign::Top);
|
||
assert_eq!(style_of(&s, "A2").align.v, gridcraft_model::VAlign::Center);
|
||
assert_eq!(style_of(&s, "A3").align.v, gridcraft_model::VAlign::Bottom);
|
||
|
||
let d = s.doc().unwrap();
|
||
let bytes = gridcraft_xlsx::write_xlsx(&d.wb).unwrap();
|
||
let (reopened, _) = gridcraft_xlsx::read_xlsx(&bytes).unwrap();
|
||
let reopen_style = |cell: &str| reopened.styles.get(reopened.active().unwrap().style_id(CellRef::parse(cell).unwrap())).clone();
|
||
assert_eq!(reopen_style("A1").align.v, gridcraft_model::VAlign::Top);
|
||
assert_eq!(reopen_style("A2").align.v, gridcraft_model::VAlign::Center);
|
||
assert_eq!(reopen_style("A3").align.v, gridcraft_model::VAlign::Bottom);
|
||
}
|
||
|
||
/// Icon-set thresholds as read from a file (one per icon, the first the lower bound) decide the
|
||
/// icon; a rule without thresholds uses Excel's defaults (percent 33 and 67) (#235).
|
||
#[test]
|
||
fn icon_set_thresholds_from_files_pick_the_icon() {
|
||
use gridcraft_model::{CfRule, CfValueKind, CondFormat};
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[0], [10], [20], [30], [100]]})).unwrap();
|
||
s.execute("home.conditionalFormat", json!({"range": "A1:A5", "rule": {"type": "iconSet", "set": "3Arrows"}})).unwrap();
|
||
let icon = |s: &Session, a: &str| {
|
||
let wb = &s.doc().unwrap().wb;
|
||
crate::cf::CfCache::new().look(wb, 0, CellRef::parse(a).unwrap()).and_then(|l| l.icon).map(|(_, i)| i)
|
||
};
|
||
// Defaults: percent of the 0..100 span, so 30 is still the lowest icon.
|
||
assert_eq!([icon(&s, "A1"), icon(&s, "A4"), icon(&s, "A5")], [Some(0), Some(0), Some(2)]);
|
||
let sh = std::sync::Arc::make_mut(&mut s.doc_mut().unwrap().wb).sheet_mut(0).unwrap();
|
||
sh.cond_formats = vec![CondFormat {
|
||
ranges: vec![gridcraft_core::RangeRef::parse("A1:A5").unwrap()],
|
||
rule: CfRule::IconSet {
|
||
set: "3Arrows".into(),
|
||
thresholds: vec![CfValueKind::Percent(0.0), CfValueKind::Number(10.0), CfValueKind::Number(25.0)],
|
||
reverse: false,
|
||
show_value: true,
|
||
},
|
||
priority: 1,
|
||
stop_if_true: false,
|
||
}];
|
||
assert_eq!([icon(&s, "A1"), icon(&s, "A2"), icon(&s, "A3"), icon(&s, "A4")], [Some(0), Some(1), Some(1), Some(2)]);
|
||
}
|
||
|
||
#[test]
|
||
fn row_height_and_column_width_take_a_list_of_areas() {
|
||
// Issue #341: header drags on a multi-area selection size every selected line in one step.
|
||
let mut s = s();
|
||
s.execute("home.columnWidth", json!({"cols": "B:B,D:E", "width": 120})).unwrap();
|
||
s.execute("home.rowHeight", json!({"rows": "2:2,4:5", "height": 40})).unwrap();
|
||
let widths: Vec<f32> = (0..6).map(|c| s.doc().unwrap().wb.active().unwrap().col_width(c)).collect();
|
||
let heights: Vec<f32> = (0..6).map(|r| s.doc().unwrap().wb.active().unwrap().row_height(r)).collect();
|
||
for c in [1, 3, 4] {
|
||
assert_eq!(widths[c], 120.0, "column {c}");
|
||
}
|
||
for c in [0, 2, 5] {
|
||
assert_ne!(widths[c], 120.0, "column {c}");
|
||
}
|
||
for r in [1, 3, 4] {
|
||
assert_eq!(heights[r], 40.0, "row {r}");
|
||
}
|
||
for r in [0, 2, 5] {
|
||
assert_ne!(heights[r], 40.0, "row {r}");
|
||
}
|
||
assert!(s.execute("home.columnWidth", json!({"cols": "B:B,nope", "width": 50})).is_err());
|
||
assert_eq!(s.doc().unwrap().wb.active().unwrap().col_width(1), 120.0, "a bad list changes nothing");
|
||
}
|
||
|
||
#[test]
|
||
fn copying_areas_that_share_rows_or_columns_pastes_them_as_one_block() {
|
||
// Issue #348: Excel slides lined-up areas together; formulas travel as their values.
|
||
let mut s = s();
|
||
s.execute(
|
||
"range.setValues",
|
||
json!({"range": "A1", "values": [["a1", "b1", "c1", "d1"], [1, 2, 3, 4], ["a3", "b3", "c3", "d3"], ["a4", "b4", "c4", "d4"]]}),
|
||
)
|
||
.unwrap();
|
||
s.execute("cell.set", json!({"cell": "C2", "input": "=A2+B2"})).unwrap();
|
||
|
||
// Same rows, selected right to left: pasted left to right, B left out.
|
||
s.execute("selection.set", json!({"range": "C1:C2,A1:A2"})).unwrap();
|
||
let copied = s.execute("edit.copy", json!({})).unwrap();
|
||
assert_eq!(copied["text"], "a1\tc1\n1\t3\n");
|
||
s.execute("edit.paste", json!({"at": "F1"})).unwrap();
|
||
assert_eq!(v(&s, "F1"), Value::text("a1"));
|
||
assert_eq!(v(&s, "G1"), Value::text("c1"));
|
||
assert_eq!(v(&s, "F2"), Value::Number(1.0));
|
||
assert_eq!(v(&s, "G2"), Value::Number(3.0));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("G2").unwrap()).unwrap().formula.is_none());
|
||
assert!(v(&s, "H1").is_empty());
|
||
assert_eq!(s.doc().unwrap().selection.current().a1(), "F1:G2");
|
||
// The source is untouched.
|
||
assert_eq!(v(&s, "B1"), Value::text("b1"));
|
||
assert!(s.doc().unwrap().wb.active().unwrap().cell(CellRef::parse("C2").unwrap()).unwrap().formula.is_some());
|
||
|
||
// Same columns: stacked, row 2 left out.
|
||
s.execute("selection.set", json!({"range": "A1:B1,A3:B4"})).unwrap();
|
||
assert_eq!(s.execute("edit.copy", json!({})).unwrap()["text"], "a1\tb1\na3\tb3\na4\tb4\n");
|
||
s.execute("edit.paste", json!({"at": "F5"})).unwrap();
|
||
for (cell, want) in [("F5", "a1"), ("G5", "b1"), ("F6", "a3"), ("G7", "b4")] {
|
||
assert_eq!(v(&s, cell), Value::text(want), "{cell}");
|
||
}
|
||
assert!(v(&s, "F8").is_empty());
|
||
|
||
// Whole columns are trimmed to the used rows like a single-area copy.
|
||
s.execute("edit.undo", json!({"steps": 2})).unwrap();
|
||
s.execute("selection.set", json!({"range": "B:B,D:D"})).unwrap();
|
||
assert_eq!(s.execute("edit.copy", json!({})).unwrap()["text"], "b1\td1\n2\t4\nb3\td3\nb4\td4\n");
|
||
}
|
||
|
||
#[test]
|
||
fn copying_areas_that_do_not_line_up_is_refused_with_a_message() {
|
||
let mut s = s();
|
||
s.execute("range.setValues", json!({"range": "A1", "values": [[1, 2, 3], [4, 5, 6], [7, 8, 9]]})).unwrap();
|
||
s.execute("selection.set", json!({"range": "A1"})).unwrap();
|
||
s.execute("edit.copy", json!({})).unwrap();
|
||
for (range, cut) in [("A1:A2,C2:C3", false), ("A1:A2,C1:D3", false), ("A1:A2,A2:A3", false), ("A1:A2,A1:A2", false), ("A1:A2,C1:C2", true)] {
|
||
s.execute("selection.set", json!({"range": range})).unwrap();
|
||
let e = s.execute(if cut { "edit.cut" } else { "edit.copy" }, json!({})).unwrap_err().to_string();
|
||
assert!(e.contains("This action won't work on multiple selections."), "{range}: {e}");
|
||
assert_eq!(s.clipboard.as_ref().map(|c| c.range.a1()), Some("A1".into()), "{range}: the earlier copy stays");
|
||
}
|
||
// Paste Link can't point at a slid-together block.
|
||
s.execute("selection.set", json!({"range": "A1:A2,C1:C2"})).unwrap();
|
||
s.execute("edit.copy", json!({})).unwrap();
|
||
assert!(s.execute("edit.pasteSpecial", json!({"what": "all", "link": true, "at": "E1"})).is_err());
|
||
assert!(v(&s, "E1").is_empty());
|
||
}
|