gridcraft

daniel543x/gridcraft

0 Fork 0

mirror of https://github.com/storytold/gridcraft.git synced 2026-11-04 01:28:59 +00:00

Files

T

History

Hector VillarrealandClaude Opus 5.5 2caf435a38 #2012 : split a parsed sheet-qualified name at the last !, sheet as is

Addresses review comments 4455115540 and 4455115557. The parser stores
`'Sheet'!Name` as `Sheet!Name` with the sheet already unquoted:

- Evaluator::name split it at the first `!`, so a series named
  `'a!b'!Title` showed #NAME?.
- chart_name unquoted it again, trimming spaces, so a chart reference
  to `' Sales '!Data` was saved as `Sales!Data`.

Both now split at the last `!` and look the sheet up as is.

Tests: chart tests::a_series_named_by_a_name_on_a_sheet_with_a_bang_resolves,
xlsx tests::chart_book_names::chart_names_keep_spaces_around_a_quoted_sheet_name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-11-03 07:21:22 -06:00

calc

#2012 : split a parsed sheet-qualified name at the last !, sheet as is

2026-11-03 07:21:22 -06:00

chart

#2012 : split a parsed sheet-qualified name at the last !, sheet as is

2026-11-03 07:21:22 -06:00

core

Merge PR #3173

2026-11-02 22:33:26 -05:00

engine

Protection: authorize the sheet a column move changes, and refuse edits that unlock locked cells (#3196 )