mirror of
https://github.com/storytold/gridcraft.git
synced 2026-10-13 15:09:05 +00:00
lloydandClaude Opus 5.5
e893621d76
Every edit goes through cmd::commit, which read std::time::Instant::now() up front for GRIDCRAFT_PROFILE timing, whether profiling was on or not. wasm32-unknown-unknown has no clock: Instant::now panics there, and with panic=abort the browser reports `RuntimeError: unreachable`. So in the web app, typing 1 into A1 and pressing Enter trapped (#118). The native apps and the CLI have a clock and were unaffected. commit now reads the clock only when GRIDCRAFT_PROFILE is set, and never on wasm. The other clock reads (NOW(), the current year for typed dates, the UI's frame timer) already skip wasm. Native tests can't see this trap, so clippy.toml now disallows Instant::now and SystemTime::now. A clock read has to be gated off wasm and allowed at the call, and `cargo clippy -D warnings` fails on the old commit code. The existing, already-gated reads and the native-only perf example allow it. Checked by building the engine for wasm32-unknown-unknown into a small cdylib that runs cell.set A1=1 on a new workbook, and running it in Node: before the fix it traps with `RuntimeError: unreachable`, after it returns normally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
13 lines
579 B
TOML
13 lines
579 B
TOML
allow-unwrap-in-tests = true
|
|
allow-expect-in-tests = true
|
|
allow-panic-in-tests = true
|
|
allow-indexing-slicing-in-tests = true
|
|
|
|
# The web app (wasm32-unknown-unknown) has no clock: these trap (`RuntimeError: unreachable`)
|
|
# instead of returning. Read the clock only off wasm (`cfg(not(target_arch = "wasm32"))` or
|
|
# `cfg!`) and allow the lint at that call.
|
|
disallowed-methods = [
|
|
{ path = "std::time::Instant::now", reason = "traps on wasm; read the clock only off wasm" },
|
|
{ path = "std::time::SystemTime::now", reason = "traps on wasm; read the clock only off wasm" },
|
|
]
|