mirror of
https://github.com/storytold/gridcraft.git
synced 2026-11-20 09:07:00 +00:00
FORMULATEXT and the in-cell editor keep Hidden formulas hidden (#3298)
* FORMULATEXT and the cell editor keep a hidden formula's source hidden * address review: recalculate formulas when sheet protection changes * address review: skip the full recalculation for a no-op unprotect * address review: recalculate on protect/unprotect without marking the edit structural
This commit is contained in:
1 parent
e14f783503
commit
bc2dabc7ea
5 files changed
+56
-6
No files matched your search
@@ -6480,6 +6480,23 @@ fn clearing_links_and_notes_keeps_allow_edit_ranges() {
|
||||
assert!(sh.hyperlinks.is_empty() && sh.comments.is_empty());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn formulatext_does_not_reveal_a_hidden_formula() {
|
||||
let mut s = s();
|
||||
s.execute("cell.set", json!({"cell": "A1", "input": "=1+1"})).unwrap();
|
||||
s.execute("home.formatCells", json!({"range": "A1", "style": {"protection": {"locked": false, "hidden": true}}})).unwrap();
|
||||
s.execute("home.formatCells", json!({"range": "B1", "style": {"protection": {"locked": false}}})).unwrap();
|
||||
s.execute("cell.set", json!({"cell": "B1", "input": "=FORMULATEXT(A1)"})).unwrap();
|
||||
assert_eq!(v(&s, "B1"), Value::from("=1+1"), "not protected yet");
|
||||
s.execute("review.protectSheet", json!({})).unwrap();
|
||||
// Without entering the formula again: protecting recalculates what reads the protection.
|
||||
assert_eq!(v(&s, "B1"), Value::Error(gridcraft_core::CellError::NA));
|
||||
s.execute("cell.set", json!({"cell": "B1", "input": "=FORMULATEXT(A1)"})).unwrap();
|
||||
assert_eq!(v(&s, "B1"), Value::Error(gridcraft_core::CellError::NA));
|
||||
s.execute("review.unprotectSheet", json!({})).unwrap();
|
||||
assert_eq!(v(&s, "B1"), Value::from("=1+1"), "unprotecting shows it again without re-entering");
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn protected_sheet_refuses_layout_commands_its_permissions_do_not_allow() {
|
||||
let mut s = s();
|
||||
|
||||
Reference in new issue
Block a user