Review feedback on #246:
- Gate the install to dev runs: a debug build, or a release run with
FILMCRAFT_DEV_DESKTOP_ENTRY set (the documented cargo run --release flow);
never when APPIMAGE or FLATPAK_ID is set — an AppImage mounts at a fresh
/tmp/.mount_* each launch, so its Exec path changes every time, and packaged
installs ship their own entry and must not write into the profile.
- Escape Exec for both desktop-entry layers exactly like
packaging/linux/install.sh: shell layer first (` " $ \ get a backslash),
then the file-value layer (every backslash doubled), always double-quoted.
Binary paths with =, % or control characters are rejected instead of written
(install.sh rejects them for the same reason).
- Compare the Exec path exactly: parse the first Exec argument through both
layers instead of a substring contains, so /a/filmcraft-old no longer
counts as ours and a stale entry is rewritten.
- eprintln -> log::warn for the skip message (the logging module landed meanwhile).
🤖 Generated with [Kimi Code](https://github.com/storyteller/kimi-code)
Co-Authored-By: Kimi <noreply@storyteller.dev>