mirror of
https://github.com/storytold/figcraft.git
synced 2026-11-15 23:02:36 +00:00
* fix(ui): SVG and PDF export rows offer no size (#256) The size picker (1x, 2x, 512w…) showed on every export row, but SVG and PDF are vector and their export ignores it (export_bytes_with). It now shows for PNG, JPG and WebP only, and the suffix field takes its width. Refs #256 ("exporting to SVG is offered in different resolutions, although this should not be the case"). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(ui): export size field as an Option; test WebP too (#256) From review: the size field's width is an Option instead of a negative width, and the test checks WebP as well as JPG. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
79 lines
3.5 KiB
Rust
79 lines
3.5 KiB
Rust
//! The Export section's Preview row: a slice paints nothing itself, so its preview must show the
|
|
//! page content under it — the same thing exporting the slice writes — and not a blank
|
|
//! transparency checkerboard next to a correct export. And its setting rows: a size only for
|
|
//! images.
|
|
|
|
use figcraft_doc::{Document, NodeId};
|
|
use figcraft_engine::Session;
|
|
use serde_json::{Value, json};
|
|
|
|
use crate::assets_panel::thumbnail_pixmap;
|
|
|
|
/// Run `commands`, returning the document and the id each one made.
|
|
fn doc_after(commands: &[(&str, Value)]) -> (Document, Vec<NodeId>) {
|
|
let mut s = Session::new();
|
|
let ids = commands.iter().map(|(cmd, params)| NodeId(s.execute(cmd, params).unwrap()["id"].as_u64().unwrap())).collect();
|
|
(s.doc().unwrap().clone(), ids)
|
|
}
|
|
|
|
/// Whether the pixmap paints anything (any pixel not fully transparent).
|
|
fn paints(pix: &figcraft_render::Pixmap) -> bool {
|
|
figcraft_render::to_rgba8(pix).as_chunks::<4>().0.iter().any(|p| p.get(3).copied().unwrap_or(0) > 0)
|
|
}
|
|
|
|
#[test]
|
|
fn a_slice_previews_the_content_under_it() {
|
|
let (doc, ids) = doc_after(&[
|
|
("shape.rectangle", json!({"x": 0, "y": 0, "width": 200, "height": 100})),
|
|
("node.create", json!({"type": "slice", "x": 0, "y": 0, "width": 200, "height": 100})),
|
|
]);
|
|
let slice = ids[1];
|
|
let pix = thumbnail_pixmap(&doc, slice, 200.0).expect("the slice previews");
|
|
assert_eq!([pix.width(), pix.height()], [200, 100], "the slice's area, not an empty node");
|
|
assert!(paints(&pix), "the rectangle under the slice shows");
|
|
}
|
|
|
|
#[test]
|
|
fn a_slice_with_nothing_under_it_is_blank() {
|
|
let (doc, ids) = doc_after(&[("node.create", json!({"type": "slice", "x": 0, "y": 0, "width": 200, "height": 100}))]);
|
|
let pix = thumbnail_pixmap(&doc, ids[0], 200.0).expect("the preview still has the slice's area");
|
|
assert_eq!([pix.width(), pix.height()], [200, 100]);
|
|
assert!(!paints(&pix), "nothing under it stays transparent");
|
|
}
|
|
|
|
#[test]
|
|
fn other_layers_preview_themselves() {
|
|
let (doc, ids) = doc_after(&[
|
|
("shape.rectangle", json!({"x": 0, "y": 0, "width": 200, "height": 100})),
|
|
("node.create", json!({"type": "slice", "x": 0, "y": 0, "width": 200, "height": 100})),
|
|
]);
|
|
let pix = thumbnail_pixmap(&doc, ids[0], 200.0).expect("the rectangle previews");
|
|
assert_eq!([pix.width(), pix.height()], [200, 100], "the layer's own area");
|
|
assert!(paints(&pix));
|
|
}
|
|
|
|
/// SVG and PDF are vector: their export rows offer no size, which their export ignores (#256).
|
|
#[test]
|
|
fn export_rows_offer_a_size_for_images_only() {
|
|
let mut s = Session::new();
|
|
let r = crate::present_tests::id(&s.execute("shape.rectangle", &json!({"x": 0, "y": 0, "width": 100, "height": 80})).unwrap());
|
|
s.execute("select.set", &json!({"ids": [r]})).unwrap();
|
|
s.execute("export.add", &json!({"ids": [r]})).unwrap();
|
|
let mut u = crate::layers_drag_tests::Ui::new(s);
|
|
let size_menu = |u: &crate::layers_drag_tests::Ui| u.ctx.read_response(egui::Id::new(("export_size", 0)).with("menu")).is_some();
|
|
u.frame(vec![]);
|
|
assert!(size_menu(&u), "PNG has sizes");
|
|
for format in ["svg", "pdf"] {
|
|
u.app.run("export.update", json!({"ids": [r], "index": 0, "format": format}));
|
|
u.frame(vec![]);
|
|
u.frame(vec![]);
|
|
assert!(!size_menu(&u), "{format} is vector: no size");
|
|
}
|
|
for format in ["jpg", "webp"] {
|
|
u.app.run("export.update", json!({"ids": [r], "index": 0, "format": format}));
|
|
u.frame(vec![]);
|
|
u.frame(vec![]);
|
|
assert!(size_menu(&u), "{format} has sizes again");
|
|
}
|
|
}
|