mirror of
https://github.com/storytold/figcraft.git
synced 2026-11-07 11:03:15 +00:00
a7a0d12a85
* M7: a file tab's menu and the board bar's shape menu read in the light theme Both open on the theme's popup, white in the light theme, but painted what is in them with `menu_text`, which is white in both themes because it belongs to the dark in-app menus (#972 was the same mistake in the panel dropdowns): - A file tab's right-click menu drew Open in new window with the menu bar's row (`menus::item`), so it showed only while hovered. It now uses `right::context_popup` and `right::menu_item`, like the tab strip's overflow menus: the theme's text, white on the green highlight. - The board bar's shape menu outlined every shape but the picked one in white. They now take the theme's icon colour, white only on the green highlight. The in-app menus (main menu, right-click on the canvas) stay dark in both themes, as decided on #843. Tests (menu_contrast_tests.rs): a file tab's menu opened with a right click and the board bar's shape menu opened from its button, headless in both themes: the label at 4.5:1 and every shape's outline at 3:1 against the popup. Without the fix both fail at 1.00:1 in the light theme. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * M8: contributor credits: a real name for aleksei-suholita Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Oleksii Sukholita <oleksii.sukholita@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Brandon Thomas <echelon@gmail.com>