Review of the fix for #1094:
- A path that can't be made absolute is refused instead of going on to be
resolved.
- A name on the way that can't be looked at for a reason other than nothing
being there (no permission, for one) is refused: it may be a link that
resolving would follow. Only "not found", "not a directory" and "invalid
filename" count as nothing there.
- Tests: the link part of the Windows test is its own test, so the spelling
and device checks no longer share a test with a part that is skipped where
links can't be made; the timing assertion is gone (the messages tell the
cases apart); link chains of 39, 40 and 41 links; a root on a share against
every network spelling, in both of the root's spellings; devices for read
and write; `..` after a link; paths that aren't UTF-8.
- Docs brought in line with the code.
On Windows, Roots::check resolved every path (canonicalize opens it) before
comparing it with the roots, so `\server\share\x` contacted the server, and
could send it the user's credentials, before it was refused. Now the path as
given and made absolute is classified by its spelling with craft_docpath
first: another computer that no root's share is on, a device path, or a DOS
device name anywhere in it is refused, and so is a link on the way that
leads to one (followed by its target's spelling, up to 40 links).
Fixes#1094
Figma holds a US registration for DEV MODE (US 7574348). Display text only: the view.devMode label, Inspect tab, shortcut row, refusal messages, CLI help, docs and all locale catalogs now say Developer Mode. Command ids, preference keys and saved fields are unchanged; "Dev Mode" stays a search alias in the Actions palette. Adds a naming guard test.
Drops the "Figma-class" self-description from the MCP instructions and the "Accessibility at Figma" aside from pref.uiScaleUp help. Help text only; ids and preference keys unchanged. Adds a display-name guard over mcp/src and engine/src/cmd string literals.
Found while testing crates/engine/src/dev/tailwind.rs:300 (the "font-family" arm, via arb at :103)
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
ljkx
skylar taylor-barrick
FredApps
bflatastic
Trevor Brown
NetterSilverandClaude Haiku 5.5