* Dependencies: take craft-libs main at 3af2280ee3
Every craft-libs crate in the workspace now comes from one commit,
3af2280ee3434a2c860012df2f440652621c2c81. They were on five revisions:
e11f9d9a, d13ac58a, 976eb51c, e9829954 (craft-update) and fd5e2fef
(craft-web-api and craft-web-host). Cargo.lock now holds one craft-zip
instead of two.
No FigCraft code changes. The new craft-font-store adds cap-primitives
and its dependencies to Cargo.lock.
* Dependencies: drop pin comments the craft-libs move made untrue
craft-update now uses the same craft-libs rev as the other crates, and
craft-window comes from craft-libs main. Remove the comment that says
craft-update is pinned separately and the comment that says craft-window
is pinned to an unmerged branch.
* Tests: look up craft-fig with cargo metadata filtered to the host
The i18n key test finds the craft-fig sources with `cargo metadata
--offline`. Since craft-font-store depends on cap-primitives, the graph
holds winx, which only Windows uses. Without a platform filter, cargo
metadata needs every platform's sources and failed on Linux CI with
"failed to download `winx v0.36.4`". The query now passes
`--filter-platform` with the host triple from `rustc -vV`.
* Dependencies: take craft-libs main at 453b0da782
Every craft-libs crate in the workspace moves from 3af2280ee3 to
craft-libs main at 453b0da782, and craft-sketch moves from ff142b3ad5
to the same commit. Cargo.lock now holds one craft-figma-rest and one
craft-zip instead of two of each; no other package changes.
* Dependencies: drop the design-file pin comment that no longer holds
craft-penpot, listed above the design-file crates, uses the same
craft-zip as craft-fig and craft-figcraft-format, and every craft-libs
crate is now on one rev, so the comment's reason for a separate rev is
removed.
inserts_and_detaches_count_per_style_and_variable_in_the_period returned
as soon as detachments reached 2, then asserted layers == 0. Asset-action
reports can arrive before the usage snapshot, so CI saw layers still at 1.
The wait now requires both.
Sonar on the same-repo vehicle (#2451) evaluated the coverage gate at
79.74% of 232 new lines (one line under 80%). A unit test covers grow's
branch that drops a new key once peaks are already at MAX_REPORTED.
Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
CodeRabbit's majors on #1735: evicting a file from the capped usage list
dropped asset_peaks, so a later identical report was counted twice.
Retention now includes asset_updated, and the file just heard from is
kept even when timestamps tie. The document keeps up to 1000 asset
counts, but each wire message is still capped at 250, so reports are
sent in batches an older server will accept.
Tests: evicting_capped_usage_rows_keeps_asset_peaks_so_a_repeat_report_is_not_counted_twice
and asset_action_reports_cover_every_count_past_the_message_cap.
Signed-off-by: FredApps <153173854+FredApps@users.noreply.github.com>
counting_links compared library_links, which walked every node, so applying or
detaching a library style or variable on an instance or a layer in it counted,
while duplicating that instance counts only its component. library_links now
walks the pages and skips instances with what they hold, as count_inserted does.
Test: library_asset_counts_tests::applying_and_detaching_inside_an_instance_counts_nothing
(an instance, its layer, a nested instance and its layer). The server test waits
for the detachments too, not only the insertions.
Applying a style or variable, or copying or duplicating content that uses it,
inserts it; the Detach button detaches it; an instance counts as its component
alone. Show usage and library.usage give them over the chosen period.
Rust 1.100 marks `ExitCode` as must-use and extends `needless_bool`,
so `cargo clippy --workspace --all-targets -- -D warnings` fails on main:
- `crates/ui-egui/src/shortcuts.rs`: the end of `key_event` returns the
condition directly instead of `if ... { return true; } false`.
- `apps/figcraft-cli/src/files.rs`: three script tests now assert the exit
code that `run_script` returns (`SUCCESS` for the two scripts that run,
1 for the script whose step fails) instead of dropping it.
The desktop app built eframe without its `links` feature, so egui-winit dropped every
`ctx.open_url` with only a log warning: the update prompt's What's new link and Download
button, the About and Credits links, Terms in Live and the link in the Dev Mode panel did
nothing on click. The feature adds no crate: `webbrowser` is already a dependency of the app.
DeckCraft's desktop app builds eframe with it too.
`links_in_the_interface_open_in_the_browser` fails without the feature.
Co-authored-by: Oleksii Sukholita <oleksii.sukholita@gmail.com>
FigCraft draws its own title bar on Windows and opens undecorated windows, but winit 0.30 still gives them WS_CAPTION | WS_BORDER. On some systems the desktop compositor reserves that caption, so the content is drawn about 30 px low (a black band above it) while clicks keep the client coordinates and land above what is drawn. Fixes#1343; the same report as #1422 and #2233.
A per-frame step (apps/figcraft/src/window_frame.rs, run from raw_input_hook) clears WS_CAPTION and WS_BORDER from every winit window of the process (the main window and the other windows alike), keeps WS_THICKFRAME and the window buttons so edge resizing and snap work, and calls SetWindowPos(SWP_FRAMECHANGED) only when a style changed. It uses safe winsafe calls (no unsafe), Windows only; other platforms and the browser are unchanged. The maximize-to-work-area trim of DesignCraft's fix is left for a later change.
Ports the fix of DesignCraft #2139 and PhotoCraft #2401. Tests: the style arithmetic (caption and border cleared, thick frame and buttons kept, a clean style unchanged) and the per-frame hook (runs every frame, a no-op when unset).
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Model-Effort: Opus 5.5 drove; Opus 5.5 briefed; Sonnet 5.5 wrote at medium
Figma holds a US registration for DEV MODE (US 7574348). Display text only: the view.devMode label, Inspect tab, shortcut row, refusal messages, CLI help, docs and all locale catalogs now say Developer Mode. Command ids, preference keys and saved fields are unchanged; "Dev Mode" stays a search alias in the Actions palette. Adds a naming guard test.
craft-update moves to a craft-libs branch that merges storytold/craft-libs#687 and #696.
- The check result window shows for every status but idle and stays
closed while the startup prompt is open, so the first start after an
update reports that it installed or why it failed. Restart to Update
calls Updater::restart_to_update.
- on_exit calls Updater::start_pending_update before the process ends,
which starts the install of an update waiting for the app to close.
inspect is docInspect under its earlier name, and openFile calls the crate's execute with file.open, so a call the app does not answer within 30 seconds rejects and a request the app has not started is cancelled.
request, execute, commands and screenshot move onto the shared crate (storytold/craft-libs#413): a timeout on every call, one data field for the screenshot's PNG, and docInspect and uiInspect beside them. A call the page gave up on cancels its request if the app has not started it, so the app skips it. openFile, captureDownloads, files, readFile and inspect stay FigCraft's own, on the same object.
The previous fix made a local share's `link` follow the code shown, but its
top-level `url`, the session's WebSocket URL, still carried the edit token:
`collab.join {link: url}` from a view-only share joined with edit access and
the edit reached the host. The link layer now hands over the view way in as a
link and its URL (`SessionInfo::view`, a `WayIn`, in place of `view_link`), and
`collab.peers` gives a local share's `link` and `url` from the way in for the
code shown (`Live::invite`). Online shares are unchanged.
Regression test: `code_tests::a_local_view_share_s_link_and_url_only_let_people_look`
joins through the `link` and then the `url` over loopback; both are welcomed as
viewers whose edits never reach the host.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LvG6E2VLhC9d5v8VSsf4ng
The session the app hosts for a local network share now has two secrets:
the edit code and a view-only code (same address and port, a 44-bit secret
of its own). Whoever joins with the view code is welcomed as a viewer: they
see every change and presence, the app makes the file read-only for them,
and the session refuses their batches, as a server does for view links.
Share > Local network offers Can edit / Can view before sharing starts (the
edit code then never shows) and while sharing. collab.share {via: "local",
access: "view"} does the same; share in collab.peers lists both codes and
links. There is still no comment code on the local network.
Next::Stop boxes its event: SessionInfo grew past clippy's
large_enum_variant threshold, and it only ever carries a status or an end.
Tests: loopback_tests::a_view_token_lets_people_look_and_not_edit,
code_tests::a_local_view_code_lets_people_look_and_not_edit,
live_share_tests::a_local_share_can_start_for_looking_only, and the local
share tests that asserted edit-only codes. Docs: collab-protocol.md,
collaboration-parity.md.
In page host mode a plain Save of a .figcraft the host opened used the document's internal name, so the host got a different file name with saveAs true instead of an update to the file it opened. Services gains host_file(); Save uses it for a .figcraft host file, Save As keeps the document name, and a missing, .json or .fig host file stays a Save As.
The transports, the message types and the origin checks come from the shared crate (storytold/craft-libs#420); FigCraft keeps what is its own: which saved files become the document, the open size limit and the author.
A page that embeds the web build can hand it a file and get every save back instead of a browser download, and hears about unsaved changes: ?host=parent for a same-origin iframe (postMessage, the protocol the GridCraft, PdfCraft, WordCraft and CADCraft bridges use) and data-host="page" on the canvas for a page that loads the module into its own document (non-bubbling CustomEvents on the canvas). The bridge holds a Transport (Parent or Page) with one send; the pure rules are unit-tested; the hosting guide documents both modes.
A session you joined could end for reasons that pass, or after about 85 s of
retries, and its tab then looked like an unsaved local file. Work done there
reached no one, with only a 3 s toast to say so.
A live connection now reconnects until you leave, pausing a minute after each
12 attempts. Only refusals that are for good stop it, so "too many messages",
"busy" and the like retry. Messages queued while offline go out paced so a long
queue can't trip the server's rate limit. A session that ended stays on its tab:
the tab shows a red mark and a strip across the canvas offers Retry now or Try
again, Save a copy and Dismiss. Joining again uses the same tab, and what changed
offline opens beside it as an unsaved copy. A session that gets out of step
joins again by itself.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The .online note beside a recovery copy holds the secret the client resumes
its identity with, but it was written with the default mode while the copy
itself was created 0600. Both now go through one owner-only writer, which
also narrows a note that already existed.
* M3: library analytics list how each style and variable is used
A file reports how many of its layers use each of a team library's styles and
variables, and Show usage lists them by a Type choice with their layers and
files. Layers in instances count for their component. Also ignores plugins/target.
* M3: the style analytics test waits for the instance report too