daniel543x/figcraft
1
0 Fork 0
mirror of https://github.com/storytold/figcraft.git synced 2026-11-13 13:52:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2117 from Silvertree2010/fix/h11295-node-reparent-silently-turns-a-n

Browse Source 
Reject negative or fractional index in node.reparent
This commit is contained in:
BFlat authored and GitHub committed 2026-11-12 09:20:42 +07:00
2 parents 0fd45a2eb2 10d97e2716
commit f2c593ff6e
2 files changed
+17 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

crates/engine/src/cmd/edit/props.rs
+1 -1
View File
@@ -245,7 +245,7 @@ pub(super) fn stroke_brush(s: &mut Session, p: &Value) -> Result<Value> {
pub(super) fn reparent(s: &mut Session, p: &Value) -> Result<Value> {
let ids = req_targets("node.reparent", s, p)?;
let parent = req_id("node.reparent", p, "parent")?;
let index = num(p, "index").map(|i| i.max(0.0) as usize);
let index = opt_index("node.reparent", p, "index")?;
let doc = s.doc_mut()?;
let ids = z_sorted(doc, &roots(doc, &ids));
// `index` is where the first moved layer ends up among the parent's children (bottom first),