0 Fork 0

mirror of https://github.com/storytold/effectcraft.git synced 2026-11-13 13:52:16 +00:00

Files

T

Altynzhan KarybaiandClaude Sonnet 5.5 4035d18132 SVG: support static pattern fills and strokes (#2732 )

* fix(svg): support static SVG patterns

* fix(svg): cache patterns per viewport

* fix(svg): share cached pattern content

* fix(svg): harden pattern cache keys

* fix(svg): harden pattern inheritance and caching

* Preserve SVG pattern fallback paint

* Format SVG pattern fallback conversion

* Harden SVG pattern resource bounds

* Fix SVG pattern test formatting

* fix(svg): bound hostile path and raster work

* Bound SVG ellipse expansion

* fix(ui-egui): suppress clippy warnings on wasm target

Rename unused `frame` parameter to `_frame` in draw_inner since
pointer_wrap::finish_native is cfg'd out on wasm32. Guard State::disabled
field with #[cfg(any(not(target_arch = "wasm32"), test))] so it only
exists where it's read (finish_frame on native + tests).

* fix: resolve clippy warnings blocking CI

- Rename unused `frame` parameter to `_frame` in draw_inner (wasm target)
- Guard State::disabled field with cfg(native + test) (wasm target)
- Replace chunks_exact(2) with as_chunks::<2>() in SVG polyline/polygon parsing

* fix(svg): budget raster work by affected region and report refusals

Address review on #2732: the finite-work guards charged the whole canvas,
dropping valid sparse art (8x8 image scaled to 1px on 2049x2049, 2x2 rect
under a 1,028-element clip on 512x512, one of six 2x2 rects sharing a 1x1
pattern on 3840x2160).

- Build fill/stroke/image/clip coverage over the device region only and
  charge that region; remaining whole-canvas passes are charged to a
  render-wide pixel budget (caps are not raised).
- Add try_rasterize/try_rasterize_with returning RasterError; rasterize
  keeps its signature. media layered decode now surfaces refusals.
- Pattern content reached through href inherits styles from the owning
  pattern; device_region falls back to the full canvas on non-finite input.
- Document new items and the limits in the svg README; regression tests.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>

2026-11-12 21:12:42 +01:00

src

SVG: support static pattern fills and strokes (#2732 )

2026-11-12 21:12:42 +01:00

tests/fixtures

IO-2/SHP-5/PRV-2: PSD import, SVG import + vector/text conversions, persistent disk cache

2026-10-02 22:10:48 -04:00

Cargo.toml

SVG: support static pattern fills and strokes (#2732 )

2026-11-12 21:12:42 +01:00

README.md

SVG: support static pattern fills and strokes (#2732 )

2026-11-12 21:12:42 +01:00

README.md

effectcraft-svg

SVG import for EffectCraft: .svg files import as footage (rasterised at any scale, so Continuously Rasterize stays sharp) and Layer ▸ Create ▸ Create Shapes from Vector Layer turns them into editable shape layers.

Implemented from the W3C Scalable Vector Graphics (SVG) 1.1 (Second Edition) recommendation (16 August 2011) and the SVG 2 candidate recommendation (4 October 2018) for the parts listed here, plus CSS Color Module Level 3 for colour keywords and functions:

document: svg (width/height, viewBox, preserveAspectRatio), nested svg, g, defs, use (x/y, href / xlink:href), symbol (through use), title/desc/metadata ignored;
shapes: path (all path data commands incl. elliptical arcs), rect (rx/ry), circle, ellipse, line, polyline, polygon;
transform lists (matrix, translate, scale, rotate with centre, skewX, skewY);
painting: fill, fill-rule, fill-opacity, stroke, stroke-width, stroke-linecap, stroke-linejoin, stroke-miterlimit, stroke-dasharray, stroke-dashoffset, stroke-opacity, opacity, display, visibility, color/currentColor;
linearGradient and radialGradient (with fx/fy focal point), gradientUnits, gradientTransform, spreadMethod, href inheritance of stops and attributes;
static (non-animated) <pattern> fill/stroke with patternUnits, patternContentUnits, patternTransform, tile x/y/width/height, local href/xlink:href inheritance and solid paints on supported shape/group children;
styling through presentation attributes, the style attribute and <style> sheets with type, class, id and universal selectors (simple selectors and selector lists).

Pattern viewBox, external pattern references, nested paint servers and non-shape pattern content are unsupported; invalid patterns use a url(...) fallback when present. Local pattern href chains are depth-limited and cycles are rejected. Tiles render once and are sampled across the painted area; both live surfaces and aggregate tile work are bounded. Pattern paints are rasterised in SVG footage; editable shape layers retain geometry and convert only a supplied url(...) fallback to solid fill/stroke. Path expansion and gradient resolution have per-import work limits. The rasterizer also caps live surface memory and cumulative pattern, clip-coverage, and source-image work. Over-budget imports return an error; over-budget raster operations are skipped, using a paint fallback where available.

rasterize/rasterize_with drop content refused by a budget and return the image drawn so far (an empty image if the canvas itself is refused). try_rasterize/try_rasterize_with return Err(RasterError) instead (SurfaceLimit for memory, WorkLimit for work). Budgets per render: 512 MiB of live offscreen surfaces, 512 MiB of pattern tiles, 256 Mi units each of pattern render work, clip-path rasterisation work and image sampling work, and 2^31 pixels touched across all passes.

For SVG input, text, images, filters, clip paths, masks, markers and animation (including pattern animation) are unsupported and ignored. The PDF importers' documents do use clip, mask, blend and image nodes, which the rasterizer renders under the same budgets. XML parsing uses roxmltree (MIT/Apache-2.0). Test fixtures are original work (see tests/fixtures/*.attribution).