Commit Graph
4231 Commits
Author SHA1 Message Date
arnav-hiwarkar 9bb0db0207 Merge upstream main into fix/3460-gaussian-blur-range
Keeps both the Gaussian Blur (#3460) and CC Power Pin (#3492) rows in
the engine range test and the effects parity log.
2026-11-17 16:55:18 +05:30
ash 6c36ad1e17 Merge pull request #3818 from arnav-hiwarkar/fix/3585-effect-controls-up-down
Effect Controls: Up and Down select the previous and next effect (#3585)
2026-11-17 16:52:09 +05:30
arnav-hiwarkar 969286ae76 #3460: review: name the open follow-up for SLIDERS_0_24, use the shared pixel budget in the test
The table holds only Gaussian Blur's row; the ranges changed since 0.24.1
by other work are tracked in #3815. The 30000 render test checks the
buffer against crate::pixel_budget instead of a copied constant.
2026-11-17 16:52:08 +05:30
arnav-hiwarkar 14d5866190 #3585: say where the gap revealed above an effect header comes from 2026-11-17 16:17:48 +05:30
arnav-hiwarkar 4d318a5347 #3585: scroll the effect Up / Down picks into view
Effect Controls scrolls its list so the header Down / Up selected is in
view, as a long effect stack would otherwise move the selection off
screen. The key handler leaves the effect to reveal for the panel's next
pass, which knows where the header is laid out.
2026-11-17 16:11:18 +05:30
arnav-hiwarkar 9b47fcf92f #3585: Up and Down select the previous and next effect in Effect Controls
With an effect header selected in a focused, on-screen Effect Controls,
plain Down / Up now select the next / previous effect in the stacking
order (After Effects), going on from the lowest / highest selected one
and stopping at the last / first without nudging the layer. It is a
selection change only: no undo step, no document or time change.

The arrows reuse the Left / Right collapse path and now act on the layer
the panel shows, so a locked panel's effects answer to them too.
Modified arrows, hidden panels, text fields, menus, dialogs, viewer text
editing and parameter-only selections keep their existing behaviour.
2026-11-17 16:10:22 +05:30
arnav-hiwarkar 12480ab94e #3492: say when crossed Expansion sides flip the CC Power Pin source
The source rectangle flips when two opposite sides add up to less than
-100 %, not when one side alone does.
2026-11-17 16:09:32 +05:30
arnav-hiwarkar ef7dd7f3d1 #3460: Gaussian Blur: Blurriness takes After Effects' range 0..30000
After Effects records Blurriness as valid from 0 to 30000; the hard range
was 0..3000, so prop.set and the value editors clamped 4000 to 3000. The
default (0) and the 0..50 slider stay as they were. Padding stays within
the effect pixel budget at the new maximum, on the CPU and the GPU.

Tests: the engine round trip (prop.set, undo/redo, save/reopen, older
projects) gets a row, the aep guard drops its known-narrower row, and the
CPU and GPU render at 30000 is checked bounded, finite and matching.
2026-11-17 16:06:36 +05:30
arnav-hiwarkar 8d603d9db8 #3460: GPU box passes count repeated edge pixels instead of visiting them
Each box-pass thread started its running sum by reading all 2r+1 pixels
of its window, even past the end of the line. At Gaussian Blur's
Blurriness 30000 the radius is about 15000 px, so most of those reads were
the same edge pixel or zero. Sum the pixels inside the line once and add
the repeated edges times their count, as the CPU pass does.

Apple M5 (Metal), 4096 x 4096, three passes per axis, repeated edges:
r = 15000 went from about 185 ms to 75 ms; r = 1500 is unchanged (80 ms).
2026-11-17 16:06:36 +05:30
arnav-hiwarkar 4b4d273086 #3460: legacy Roto Brush keys hash Gaussian Blur's 0.24 Blurriness range
Roto Brush Input Keys saved by 0.22-0.24 hashed each effect above the
brush through its derived Debug text, UI hints included. Opening a project
replaces an instance's hints with the current spec's, so widening a range
would stop those keys matching and drop the frozen matte. The legacy text
now puts back the slider range 0.24 shipped for parameters listed in
SLIDERS_0_24, starting with Gaussian Blur's Blurriness.
2026-11-17 16:06:36 +05:30
arnav-hiwarkar 9e3cfa639a #3492: test CC Power Pin below -100 % Expansion on CPU and GPU
Below -100 % an Expansion edge crosses the opposite one and the source
rectangle flips. Pin that geometry, check that the extremes (including
a zero-size source and Unstretch) keep the buffer size and render
finite pixels, and compare CPU and GPU at the new minimum.
2026-11-17 16:04:45 +05:30
arnav-hiwarkar cfea5b4bf9 #3492: CC Power Pin Expansion takes After Effects' -200 minimum
Top, Left, Right and Bottom Expansion had a hard range of -100..1000, so
prop.set and the value editors stored -100 for After Effects' valid
-200..-100. The hard minimum is now -200; the 1000 maximum, the default
and the 0..100 slider are unchanged. The engine range table covers both
ends through prop.set, undo/redo, save/reopen and an older project's
stored range, and the four rows leave the aep KNOWN_NARROWER list.
2026-11-17 16:04:44 +05:30
Dylan M. Taylor bb54263240 Merge remote-tracking branch 'origin/main' into refactor/shared-svg-transform 2026-11-17 02:16:32 -05:00
Dylan M. Taylor ed7b40ab4d Merge shared CSS integration while retaining transform compatibility 2026-11-17 00:05:47 -05:00
Dylan M. Taylor 69b4115b36 Merge remote-tracking branch 'origin/main' into refactor/shared-svg-colors 2026-11-17 00:04:44 -05:00
Dylan M. Taylor 9953ca314d svg: consume shared compatibility transform-list parser 2026-11-16 23:22:52 -05:00
Dylan M. Taylor f65ad2a42d Merge current main and retain CSS plus prefix-path shared APIs 2026-11-16 23:10:13 -05:00
Dylan M. Taylor d0cbc53494 Merge remote-tracking branch 'origin/main' into HEAD
# Conflicts:
#	Cargo.lock
#	Cargo.toml
2026-11-16 23:02:54 -05:00
Dylan M. Taylor 41da144555 Shape operators: cap each expanding operator's output (#2948) 2026-11-16 21:58:09 -05:00
Dylan M. Taylor defa16a26f svg: use shared bounded prefix path parsing (#3800) 2026-11-16 21:58:04 -05:00
Dylan M. Taylor d5755f5dd9 Merge remote-tracking branch 'origin/main' into refactor/shared-svg-colors 2026-11-16 21:49:57 -05:00
Dylan M. Taylor ca5ca106fa Merge remote-tracking branch 'origin/main' into refactor/shared-svg-stylesheet 2026-11-16 21:09:59 -05:00
Dylan M. Taylor 6d908d1301 Merge pull request #3215 from vangel76/cc-ball-action-params-3197
Ball Grid effect has all of After Effects' CC Ball Action controls, including flat balls without shading
2026-11-16 20:39:25 -05:00
Dylan M. Taylor 22dbd1612f Merge pull request #3246 from vangel76/waveform-reversed-3238
The Timeline waveform shows what is really heard for reversed layers and the Backwards effect
2026-11-16 20:37:23 -05:00
Dylan M. Taylor a9d53efbb5 svg: route paint colours through shared floating-point compatibility parser 2026-11-16 19:51:35 -05:00
Dylan M. Taylor 3972e5181b svg: delegate stylesheet parsing and matching to craft-svg 2026-11-16 19:38:19 -05:00
vangel76 fa542829e9 #3793: build the OCIO test's expected LUT path from its parts
join("luts/grade.cube") keeps the forward slash on Windows, while the code
resolves the config's LUT as luts\grade.cube, so the test's text lookup in the
read log missed there. The code under test is unchanged.
2026-11-16 22:05:56 +01:00
Dylan M. Taylor e2cbc0861f Merge branch 'main' into refactor/interchange-shared-preflight 2026-11-16 13:15:45 -05:00
Dylan M. Taylor a163fa3fcb Merge pull request #3773 from storytold/refactor/interchange-current-shared-film
interchange: stage current shared Film format dependency cutover
2026-11-16 13:14:50 -05:00
Dylan M. Taylor b6d2598b3f interchange: delegate lexical depth preflight to craft-timeline 2026-11-16 11:27:30 -05:00
Dylan M. Taylor e9d5f37561 test: use valid encoded PCE layout for AAC downmix parity 2026-11-16 11:09:24 -05:00
Dylan M. Taylor b842402a83 interchange: retain EDL guessed-path bounds with current Film metadata 2026-11-16 11:04:56 -05:00
Dylan M. Taylor 9da73e9cf3 psd: delegate ZIP prediction reversal with budgeted scratch 2026-11-16 09:47:19 -05:00
Dylan M. Taylor adb120c327 interchange: update test fixtures and adopt merged shared AAF route 2026-11-16 09:41:59 -05:00
FredApps ed8811d2d8 psd: parse linked files with craft-psd and pin past #1845
Repin only craft-psd to craft-libs main e836b6fd (includes #1845).
lnk2 / lnkD / lnk3 / lnkE records come from craft_psd::smart::linked_files;
payload ranges are shifted from the block back into the document bytes.
is_linked_layer_key is the deferral predicate.

Descriptors, placed objects, and pixel decode stay local until
craft-libs#1887 (parse_prefix) and #1885 (PackBits recovery) are on main.
2026-11-16 14:55:09 +01:00
Dylan M. Taylor cb29f77eaf interchange: adapt export to current Film media and marker APIs 2026-11-16 08:42:06 -05:00
FredApps 4edbd480fb Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 14:20:51 +01:00
FredApps 5d5be53bef Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 13:55:36 +01:00
FredApps dfa9584993 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-reader-craft-psd 2026-11-16 13:55:36 +01:00
Dylan M. Taylor b617ea08e5 Merge pull request #3745 from storytold/extract/shared-sony-luts
effects: cut SPI3D and SPIMTX parsing over to craft-cms
2026-11-16 07:33:27 -05:00
FredApps 7311b6574c psd: rustfmt write.rs to the workspace style
The previous commit had been formatted without rustfmt.toml
(use_small_heuristics = "Max"), so cargo fmt --check failed on the gate.
2026-11-16 13:30:21 +01:00
FredApps f8aa110655 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-reader-craft-psd 2026-11-16 13:30:21 +01:00
FredApps 2fdf6f4912 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 13:30:10 +01:00
ash 7b4138e2fb Merge pull request #2047 from arnav-hiwarkar/perf/timeline-drag-adaptive
Fast Previews: Adaptive Resolution applies while dragging in the Timeline
2026-11-16 17:31:17 +05:30
FredApps 952918aa02 psd: keep finite 32-bit color samples outside 0..1
Integer depths are still clamped. NaN and infinities use the same
mapping as the reader.
2026-11-16 12:59:44 +01:00
FredApps 105cd87f42 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-reader-craft-psd 2026-11-16 12:57:55 +01:00
FredApps 12746e0dd1 Merge remote-tracking branch 'upstream/main' into onee/i786-psd-writer-craft-psd 2026-11-16 12:57:46 +01:00
ash 5300531387 Merge pull request #2042 from arnav-hiwarkar/perf/close-project-frees-caches
Close, New and Open Project free the closed project's memory
2026-11-16 17:27:13 +05:30
Dylan M. Taylor 9fa8a069da Merge current main and pin merged shared Sony LUT readers 2026-11-16 06:51:41 -05:00
FredApps 7f9f0bc489 psd: record stray leading bytes before the layer block check, use craft-psd's long-length keys 2026-11-16 12:31:10 +01:00