Commit Graph
4492 Commits
Author SHA1 Message Date
vangel76 98ada1e8ff Watch Folder renders take the host's memory budget; docs and test comment (#3941 review) 2026-11-19 10:37:00 +01:00
vangel76 0d9c69563f Exports, the Render Queue and command-line renders use the memory budget (#3941)
The command-line tool reads the system's memory once at start, so its caches
share the budget of the installed RAM instead of the budget for unknown RAM.
A Render Queue run's two layer caches and a one-off export's own caches take
the session's layer cache budget instead of a fixed 512 MiB; they are in the
memory accountant, which keeps them within the common budget together with the
other caches. In the browser each gets half the layer cache's cap.
2026-11-19 10:29:54 +01:00
vangel76 6bea5fa6ae Merge upstream/main into cache-defaults-3298 2026-11-19 10:21:55 +01:00
Dylan M. Taylor 665bfac0b3 export: cut over exr_out to craft-exr (#3937)
* export: cut over exr_out to craft-exr

* fix(export): keep exr in dev-dependencies for tests
2026-11-18 21:55:05 -05:00
FredApps c6eb66b937 Merge pull request #3940 from FredApps/fix/786-psd-hue-level-adapter
psd: share hue and levels writer framing
2026-11-19 08:47:16 +07:00
FredApps 686fb3fa04 Merge pull request #3922 from FredApps/fix/786-psd-fixed-writer-adapter
psd: delegate raw brightness and exposure writers
2026-11-19 07:24:22 +07:00
nicolafalcier99andNicola Falcier f6ed0b2500 #3391: a Views 1 | 2 | 4 switch in the Composition viewer's control row (#3848)
* contributors: Nicola Falcier

* #3391: a Views 1 | 2 | 4 switch in the Composition viewer's control row

---------

Co-authored-by: Nicola Falcier <298941634+nicolafalcier99@users.noreply.github.com>
2026-11-18 18:12:26 -06:00
FredApps 27ce4e9fa2 psd: share hue and levels writer framing 2026-11-19 01:02:42 +01:00
FredApps 85dc8d90e2 Merge descriptor parser and preserve shared writer pin 2026-11-19 00:45:53 +01:00
FredApps 4139f5db59 Remove unused PSD reader after shared parser integration 2026-11-18 23:39:26 +01:00
FredApps 851642f6ec Merge pull request #3921 from FredApps/fix/786-psd-tagged-descriptor-adapter
psd: share recovering descriptor-block headers
2026-11-19 04:29:05 +07:00
FredApps b7c311d106 Merge main preserving scalar reader integration 2026-11-18 21:27:47 +01:00
FredApps a089c3f312 Delegate raw adjustment writers to craft-psd 2026-11-18 21:23:52 +01:00
FredApps f3ba7a5cd2 psd: share recovering descriptor-block headers 2026-11-18 20:38:43 +01:00
FredApps 9a58ca6bd3 Merge main preserving scalar and section regression modules 2026-11-18 20:29:34 +01:00
FredApps f9e81b8a0f Merge pull request #3907 from FredApps/fix/786-psd-tysh-adapter
psd: share bounded TySh text-prefix reading
2026-11-19 02:14:16 +07:00
FredApps c6017db502 Merge vector cutover and pin combined shared PSD readers 2026-11-18 19:33:43 +01:00
FredApps 5ff845951c Merge vector cutover and pin combined shared PSD readers 2026-11-18 19:33:39 +01:00
FredApps 5f621b3f69 Merge remote-tracking branch 'origin/main' into fix/786-psd-scalar-blocks 2026-11-18 19:31:24 +01:00
FredApps 57ae4ceeff psd: read scalar layer blocks through shared views 2026-11-18 19:31:24 +01:00
FredApps 450d21647c Merge main preserving Unicode and vector regression modules 2026-11-18 18:34:41 +01:00
FredApps e97a6390ac psd: share bounded type-layer text prefix 2026-11-18 17:42:55 +01:00
FredApps 723f47a3b4 Merge remote-tracking branch 'origin/main' into fix/786-psd-section-adapter 2026-11-18 17:40:03 +01:00
Dylan M. Taylor a6c46ec7c5 Drop the now-unused WAV probe re-export 2026-11-18 10:41:47 -05:00
FredApps d0693d9dcb psd: share recovering section-divider framing 2026-11-18 16:39:11 +01:00
FredApps 7edb6b154a Merge pull request #3898 from FredApps/fix/786-psd-fixed-adjustments
psd: share fixed-binary adjustment readers
2026-11-18 22:05:40 +07:00
Dylan M. Taylor c89395d5d7 Merge pull request #3743 from storytold/extract/shared-wav-markers
media: cut WAV cue, adtl, RF64 and XMP markers over to craft-libs
2026-11-18 09:47:41 -05:00
Dylan M. Taylor 292313f2a1 Merge pull request #3774 from storytold/cutover/shared-psd-packbits
psd: cut over recovery PackBits decoding to craft-psd
2026-11-18 09:13:46 -05:00
Dylan M. Taylor e3cf168119 Merge remote-tracking branch 'origin/main' into pr-3743 2026-11-18 09:12:54 -05:00
FredApps 1d823a01a1 psd: share fixed-binary adjustment readers 2026-11-18 15:12:01 +01:00
FredApps 67e6e27fa7 psd: share Unicode layer-name record framing 2026-11-18 14:27:17 +01:00
Dylan M. Taylor 47384980a4 psd: cover the shared PackBits row-limit error mapping
The recovery wrapper maps every non-decompress failure to Error::Invalid so a
limit refusal is never reported as truncated data. That arm had no test, which
left the changed lines under the coverage gate.
2026-11-18 07:44:01 -05:00
FredApps 82cf1b5c5e psd: align vector fixtures with fixed-size chunk lint 2026-11-18 13:39:15 +01:00
FredApps c149bb513f psd: read vector mask records through craft-psd 2026-11-18 13:19:34 +01:00
vangel76 cc639b9cd6 OpenEXR limit: the decode that let planes go no longer keeps them for its waiters, and an entry with planes let go but still in use is kept (#3750 review) 2026-11-18 13:19:05 +01:00
vangel76 51bb54efde Merge branch 'plane-store-on-craft-exr' into decode-cap-on-craft-exr 2026-11-18 13:17:20 +01:00
vangel76 f6a867a951 Disk cache: an entry larger than the cache is skipped before it is sealed (#3750 review) 2026-11-18 13:17:19 +01:00
vangel76 3c48ddc72c OpenEXR limit: planes let go that are still in memory count toward the limit, so a request is refused for now rather than read beside them (#3750 review) 2026-11-18 13:07:17 +01:00
vangel76 0f872a46a6 Merge branch 'plane-store-on-craft-exr' into decode-cap-on-craft-exr 2026-11-18 13:03:28 +01:00
vangel76 c2c40200f6 Caching: the test of a still cached twice checks that its memory goes once nobody holds it (#3750 review) 2026-11-18 13:03:27 +01:00
vangel76 596a5ac55d Merge branch 'plane-store-on-craft-exr' into decode-cap-on-craft-exr 2026-11-18 13:03:07 +01:00
vangel76 9bbc0847ad Caching: a still cached both whole and as a frame can be let go, and a plane entry without memory to seal it is skipped (#3750 review) 2026-11-18 12:57:37 +01:00
ash 3f1cd00745 Merge pull request #3843 from arnav-hiwarkar/fix/3830-3831-ocio-lut-limits
OCIO: cap the .3dl mesh and rows before cubing them (#3830)
2026-11-18 17:20:01 +05:30
FredApps 8a4a29b227 Merge pull request #3779 from FredApps/onee/i786-psd-descriptors-placed
psd: parse descriptors and placed layers with craft-psd
2026-11-18 18:36:59 +07:00
arnav-hiwarkar c6612da798 #3830: tell a 3-entry .3dl mesh apart by the row count alone 2026-11-18 15:46:04 +05:30
arnav-hiwarkar bf31b65271 #3830: keep four .3dl tokens and a spare mesh row at small limits 2026-11-18 15:38:08 +05:30
arnav-hiwarkar 648ae78591 #3830: test the .3dl cap through an injectable limit; drop the local .spi3d precheck (#3831 belongs in craft-cms) 2026-11-18 15:27:36 +05:30
Sean Hawkey 67942cda7b Expressions: a layer parameter left at None is the layer it sits on (#3601)
Fixes #3601.

### What

A layer parameter left at None (a Layer Control, or an effect's layer parameter) now stands for the layer it sits on, as in After Effects (values observed in AE 26.3 are in #3601). Before, its value was `null`. The property was still truthy, so a rig's `L ? L.sourceRectAtTime(t) : 0` went down the wrong branch and stopped with "not a callable function".

The change is one line in `Prop.__wrap` (`crates/expr/src/prelude.js`).

### Tested

- **`an_empty_layer_control_stands_for_its_own_layer`** in `crates/expr/src/tests.rs`: truthiness, `name`, `index`, the `L ? L.transform.position[0] : -1` pattern, and `sourceRectAtTime`. It fails without the change.
- **Suites:** `cargo test -p effectcraft-expr` (167 passed) and `cargo test -p effectcraft-script` pass. clippy and fmt are clean.
- **Not covered here:** calling the empty parameter like a layer (`L("ADBE Transform Group")`). That depends on #3554, and works with both applied.
2026-11-18 16:25:57 +07:00
JCleanCode 981981632c Fix #1986 Cmd+A ("select all") doesn't work in "Import multiple files…
Fixes #1986

**Cause.** On macOS the open panel has no key equivalents of its own. Cmd+A (and C/V/X/Z) work
because the menu bar sends `selectAll:`, `copy:` and so on down the responder chain to the key
window. EffectCraft's Edit items are custom muda items, so while the sheet was up Cmd+A ran
Edit > Select All on the Project panel behind it.

**Fix.** The native file dialogs on screen are counted (`native_dialogs`). While one is open on
macOS, Undo / Redo / Cut / Copy / Paste / Select All become macOS predefined items, which send
the real actions to the dialog. The other `edit.*` items are disabled. The UI is repainted when
a dialog opens so the menu is rebuilt before the next key.

**Tests.** `edit_menu_is_disabled_while_a_file_dialog_is_open`,
`edit_text_commands_are_predefined_while_a_file_dialog_is_open`. Checked by hand on macOS:
Cmd+A in "Import multiple files" selects the files.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
  * On macOS, Edit menu commands are disabled while a native file dialog is open and return to their appropriate enabled state when it closes or is canceled.
  * While a dialog is open, Undo, Redo, Cut, Copy, Paste, and Select All appear as native macOS menu commands with their current labels.
  * Opening a file dialog now triggers an immediate interface refresh, helping the menu update before the next key event.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-11-18 16:25:06 +07:00
FredApps 49170cdf18 fix(psd): surface unsupported modern placements at import boundary 2026-11-18 09:43:01 +01:00