Commit Graph
1833 Commits
Author SHA1 Message Date
ash 7b4138e2fb Merge pull request #2047 from arnav-hiwarkar/perf/timeline-drag-adaptive
Fast Previews: Adaptive Resolution applies while dragging in the Timeline
2026-11-16 17:31:17 +05:30
ash 5300531387 Merge pull request #2042 from arnav-hiwarkar/perf/close-project-frees-caches
Close, New and Open Project free the closed project's memory
2026-11-16 17:27:13 +05:30
FredApps b8fb20d3ac Merge pull request #3221 from vangel76/rotation-tool-drag-2769
The Rotation tool turns a layer by exactly the angle you drag from the press point
2026-11-16 10:30:40 +01:00
FredApps 7c3a9ffe15 Merge pull request #3218 from vangel76/graph-flat-segments-2720
Graph Editor curves pass through every keyframe and show Hold steps as vertical jumps
2026-11-16 10:29:41 +01:00
FredApps 2bfb8bad3b Merge pull request #3254 from vangel76/effect-controls-alt-expression-1460
Alt-click on a stopwatch in Effect Controls adds or removes an expression, as in After Effects, instead of toggling keyframes
2026-11-16 10:28:40 +01:00
FredApps 2881f048f1 Merge pull request #3343 from dotCooCoo/fix/update-outcome-at-start
Updates: the first start after an update shows how it ended
2026-11-16 10:23:06 +01:00
FredApps 4e80f99d2f Merge pull request #3344 from dotCooCoo/fix/update-restart-unsaved
Updates: Restart to Update with unsaved changes opens the save prompt
2026-11-16 10:22:13 +01:00
FredApps 3338a45379 Merge pull request #3690 from ZIDAN44/fix/3367-negative-field-edit
Angles: typing into a negative angle's degrees replaces its minus sign (#3367)
2026-11-16 10:19:25 +01:00
Dylan M. Taylor 218b94224a test(ui): serialize GPU picker integration 2026-11-15 23:57:08 -05:00
Dylan M. Taylor ac1c1d9202 encoding: reuse shared Base64 writers across four consumers 2026-11-15 13:19:05 -05:00
.CooCoo 7cbefaf70f Import: VectorCraft documents import through the PDF they carry (#2901)
* Import: VectorCraft documents import through the PDF they carry

File > Import reads a .vectorcraft file through the PDF that VectorCraft
saves in it with Create PDF-Compatible File, one page per artboard, as
footage or as a composition with one layer per PDF layer. The PDF is read
with craft-doc from craft-libs (plain or compressed files, the PDF inline
or after the JSON). A PDF after the JSON may be as large as a PDF file
EffectCraft imports (512 MiB). A document saved without that option gives
an import error that names it.

craft-doc, craft-vectorcraft-format (tests only) and craft-ecproj-format
are pinned to craft-libs fa1a6574; craft-ecproj-format is unchanged
between ca1b5e2e and that commit.

* Import: show file errors returned by the import dialog

* Keep dropped-file import errors alongside local drop errors

* Import: preserve every file error across background jobs and UI notices

* Import: queue pending errors with bounded notification details

* Import: a damaged VectorCraft preview no longer stops the carried PDF

The importer read every rendition with craft_doc::renditions and then
picked the PDF, so a preview whose base64 was invalid or whose data lay
past the end of the file made the whole import fail. It now reads only
the PDF with craft_doc::rendition, from storytold/craft-libs#546, and
never decodes the preview. A document without a PDF still reports
NoCarriedPdf.

* Import: dismissing a picked import's error status acknowledges its details

A picked or menu import queued its error details with the status
report_import_errors set ("first (and 1 more)"), and show_result_errors
then replaced that status with "first; second". The two never matched,
so clicking the status left the details queued and they showed again.
Import commands now move the queued details to the status that replaces
it, also when After Effects project errors lead it. Other commands'
statuses never take over an import's details.
2026-11-15 03:45:56 -05:00
Zinadin Zidan 3fd1448482 Merge remote-tracking branch 'origin/main' into fix/3367-negative-field-edit 2026-11-15 03:15:04 +06:00
vangel76 0a3d74fb54 ui-egui tests: the file.import dialog answers carry paths as Ok, as DialogAnswer.paths is a Result now (#3304 met the tests of #3103 on main) 2026-11-14 19:54:13 +01:00
vangel76 2780a50302 ui-egui tests: the file.import dialog answers carry paths as Ok, as DialogAnswer.paths is a Result now (#3304 met the tests of #3103 on main) 2026-11-14 19:54:13 +01:00
vangel76 c1f3a03a9d ui-egui tests: the file.import dialog answers carry paths as Ok, as DialogAnswer.paths is a Result now (#3304 met the tests of #3103 on main) 2026-11-14 19:54:12 +01:00
vangel76 c1191503c2 Merge upstream/main into rotation-tool-drag-2769 2026-11-14 19:25:29 +01:00
vangel76 3bc37b0b8b Drop the duplicate expression_toggled that the merge brought in from main 2026-11-14 19:18:45 +01:00
FredApps 4bb4c71583 Wrap the line rustfmt would wrap 2026-11-14 18:20:47 +01:00
FredApps 3968433f75 Tests: import dialog tests answer with a Result of paths
DialogAnswer.paths became a Result in #3304; three import tests merged
since still passed a plain Vec, so the test build of effectcraft-ui-egui
did not compile on main.
2026-11-14 18:20:27 +01:00
vangel76 82733a4cdb Merge upstream/main into graph-flat-segments-2720 2026-11-14 18:14:09 +01:00
vangel76 29ea97fed7 Merge upstream/main into effect-controls-alt-expression-1460 2026-11-14 18:14:01 +01:00
Zinadin Zidan ab18109b2a Merge main into fix/3367-negative-field-edit
angle_field. The degrees field gets the signed remainder, the sign is painted
only for a positive one, and a typed step goes from the signed remainder.
2026-11-14 23:03:20 +06:00
FredApps f029bbadb2 Merge pull request #3251 from vangel76/tests-pin-english-3244
Tests: Match System resolves to English in ui-egui test builds
2026-11-14 17:30:28 +01:00
FredApps afaa9cced3 Merge pull request #3304 from vangel76/macos-open-panel-3084
File dialogs: a dialog that can't be created is an error, not a crash (#3084)
2026-11-14 17:30:08 +01:00
FredApps 38cd374bae Merge pull request #3236 from vangel76/number-field-math-3195
Number fields: typed arithmetic (960/2, (3+4)*2) and a leading *, / or + applied to the value
2026-11-14 17:29:47 +01:00
FredApps 829706de6f Merge pull request #3232 from vangel76/project-drag-new-folder-3196
Project panel: items dropped on New Folder go into a new folder, as After Effects
2026-11-14 17:29:26 +01:00
FredApps da611b2540 Merge pull request #3226 from vangel76/waveform-peaks-1722
Timeline waveform: read keyframed Audio Levels at layer time
2026-11-14 17:28:05 +01:00
FredApps f89dd51bcf Merge pull request #3235 from vangel76/effect-controls-lock-3193
Effect Controls: lock the panel to the layer it shows
2026-11-14 17:27:24 +01:00
FredApps 94a8e5cabf Merge pull request #3214 from vangel76/effect-rename-select-3198
Effect Controls: renaming an effect opens with the whole name selected
2026-11-14 17:26:51 +01:00
FredApps c3cdaecdc6 Merge pull request #3240 from vangel76/shift-snap-axis-3229
Viewer: a Shift-constrained drag snaps only along its axis
2026-11-14 17:25:59 +01:00
FredApps ee31dd170d Merge pull request #3225 from vangel76/graph-theme-3202
Graph Editor: follow the theme (plot, bar buttons, grid, keys, handles, curves)
2026-11-14 17:25:26 +01:00
FredApps 987be06ec3 Merge pull request #3243 from vangel76/timeline-convert-bezier-menu-3237
Timeline: Convert To Bezier Path in the context menu of a parametric shape path
2026-11-14 17:25:06 +01:00
Zinadin Zidan 02e304a19b Angles: typing into a negative angle's degrees replaces its minus sign (#3367)
The degrees field of an angle (Rotation, an effect's angle) showed the
remainder's size, with the minus sign painted beside it, and a typed
number was taken as a size that kept the sign: 50 typed into 0x-20.0
gave -50. The minus sign is now part of the degrees' text, so it is
selected with the rest when typing starts, and a typed number is the
new remainder with its sign: 50 gives +50, -50 gives -50. A positive
remainder still shows its + beside the field.

Fixes #3367
2026-11-14 22:18:48 +06:00
FredApps 88bb97b839 Merge pull request #3258 from vangel76/cryptomatte-select-tool-2839
Cryptomatte: the Selection tool picks IDs while the effect is selected
2026-11-14 16:58:44 +01:00
FredApps a7c6d6a8fb Merge pull request #3249 from vangel76/stopwatch-expression-alt-3192
Timeline: Add Expression from the stopwatch's right-click menu
2026-11-14 16:55:14 +01:00
vangel76 fcef7db85a Merge remote-tracking branch 'upstream/main' into tests-pin-english-3244
# Conflicts:
#	Cargo.lock
2026-11-14 00:11:28 +01:00
dotCooCoo d943341ad0 Merge main into fix/update-restart-unsaved 2026-11-13 11:38:34 -08:00
dotCooCoo fb885ce91a Merge main into fix/update-outcome-at-start 2026-11-13 11:38:27 -08:00
vangel76 b53b18366d Merge upstream/main into effect-controls-lock-3193 2026-11-13 19:05:57 +01:00
8f21de0a0c ci: limit concurrent GPU tests in nextest (#3323)
Co-authored-by: skylartaylor <skylartaylor@users.noreply.github.com>
Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
2026-11-12 23:06:17 -05:00
Altynzhan KarybaiandClaude Sonnet 5.5 4035d18132 SVG: support static pattern fills and strokes (#2732)
* fix(svg): support static SVG patterns

* fix(svg): cache patterns per viewport

* fix(svg): share cached pattern content

* fix(svg): harden pattern cache keys

* fix(svg): harden pattern inheritance and caching

* Preserve SVG pattern fallback paint

* Format SVG pattern fallback conversion

* Harden SVG pattern resource bounds

* Fix SVG pattern test formatting

* fix(svg): bound hostile path and raster work

* Bound SVG ellipse expansion

* fix(ui-egui): suppress clippy warnings on wasm target

Rename unused `frame` parameter to `_frame` in draw_inner since
pointer_wrap::finish_native is cfg'd out on wasm32. Guard State::disabled
field with #[cfg(any(not(target_arch = "wasm32"), test))] so it only
exists where it's read (finish_frame on native + tests).

* fix: resolve clippy warnings blocking CI

- Rename unused `frame` parameter to `_frame` in draw_inner (wasm target)
- Guard State::disabled field with cfg(native + test) (wasm target)
- Replace chunks_exact(2) with as_chunks::<2>() in SVG polyline/polygon parsing

* fix(svg): budget raster work by affected region and report refusals

Address review on #2732: the finite-work guards charged the whole canvas,
dropping valid sparse art (8x8 image scaled to 1px on 2049x2049, 2x2 rect
under a 1,028-element clip on 512x512, one of six 2x2 rects sharing a 1x1
pattern on 3840x2160).

- Build fill/stroke/image/clip coverage over the device region only and
  charge that region; remaining whole-canvas passes are charged to a
  render-wide pixel budget (caps are not raised).
- Add try_rasterize/try_rasterize_with returning RasterError; rasterize
  keeps its signature. media layered decode now surfaces refusals.
- Pattern content reached through href inherits styles from the owning
  pattern; device_region falls back to the full canvas on non-finite input.
- Document new items and the limits in the svg README; regression tests.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-12 21:12:42 +01:00
arnav-hiwarkar 9046c8d39a #2042: read the Project panel thumbnail through panels::project::cached_thumbnail
ui_large_project::comp_thumbnail_renders_off_the_ui_thread read the thumbnail cache by its old
storage type, (u64, TextureHandle), which the purge change replaced with a private newtype, so
it never saw the texture land. It now asks cached_thumbnail.
2026-11-12 20:03:35 +05:30
arnav-hiwarkar 8bde3dc53f Merge upstream main into perf/close-project-frees-caches 2026-11-12 19:19:40 +05:30
arnav-hiwarkar 8b481f3811 #2047: a layer's audio counts when something draws it
Compare the comp exactly as the frame cache does: a layer's Audio
switch, Audio group and audio effects are pixels when a layer picks
its audio or an expression reads audio, before or after the edit.
Scrubbing Audio Levels read by an expression now draws a draft;
with nothing drawing the audio it keeps Full.
2026-11-12 19:18:24 +05:30
arnav-hiwarkar 6633708571 #2042: a cache purge drops the Project panel's thumbnails
Event::PurgeCaches (Close / New / Open Project, Edit > Purge, footage reloads) now also removes
the Project panel's thumbnail textures and the renders awaited for them. They were keyed by item
id only: the closed project's textures stayed in memory, and an item of the next project with a
closed one's id showed the closed project's picture until its own render landed.
2026-11-12 19:12:26 +05:30
ash fbfeed2974 Merge pull request #2875 from arnav-hiwarkar/fix/issue-2869-effect-arrow-disclosure
Fix Effect Controls arrow-key collapse and expand (#2869)
2026-11-12 19:11:21 +05:30
arnav-hiwarkar 9ed7954a97 #2047: markers no expression reads don't drop the resolution
Compare the comp the way the frame cache does (#1083): markers count
as pixels only when an expression reads them, so dragging a marker
keeps Full. Tighten the click and Fast Previews Off tests so they
prove the gesture reached the app.
2026-11-12 19:08:18 +05:30
arnav-hiwarkar 724865e340 #2047: Fast Previews: any frame-changing Timeline drag draws a draft
One rule instead of a flag per gesture: DragWatch snapshots the active
comp and its current frame when the Timeline (and the Properties panel)
starts its pass, and after the pass, while the primary button drags
past a click, a new frame or a comp that no longer draws the same
pixels sets property_interacting until release. This covers the
playhead and timecode, layer moves and trims, slips, key drags and
alt-scale, Quick Offset, the In/Out/Duration cells, property scrubs and
the Graph Editor, and any gesture added later. Clicks, scrolling,
zooming, the work area and selection keep Full. It replaces the
prop.set-only check in apply_actions.
2026-11-12 19:00:04 +05:30
arnav-hiwarkar 550aeb0ac9 #2047: tests for Adaptive Resolution during Timeline and Properties drags
Drag/release tests for the playhead, timecode, layer bar, In trim,
source slip, key drag, the In/Out/Duration cells and a Properties
scrub: a draft while held, Full on the first frame after release.
A click, a work-area drag (same pixels) and Fast Previews off keep
Full.
2026-11-12 19:00:04 +05:30
arnav-hiwarkar 0c0113f6e5 #2047: merge main into perf/timeline-drag-adaptive
Conflicts in crates/ui-egui/src/panels/timeline.rs: main split `show`
into helpers, so main's version is taken as is and the Timeline drag
hook is redone on top of the split in the following commits. The UI
test moves to tests/it/ (one integration binary).
2026-11-12 18:46:29 +05:30