* Import: VectorCraft documents import through the PDF they carry
File > Import reads a .vectorcraft file through the PDF that VectorCraft
saves in it with Create PDF-Compatible File, one page per artboard, as
footage or as a composition with one layer per PDF layer. The PDF is read
with craft-doc from craft-libs (plain or compressed files, the PDF inline
or after the JSON). A PDF after the JSON may be as large as a PDF file
EffectCraft imports (512 MiB). A document saved without that option gives
an import error that names it.
craft-doc, craft-vectorcraft-format (tests only) and craft-ecproj-format
are pinned to craft-libs fa1a6574; craft-ecproj-format is unchanged
between ca1b5e2e and that commit.
* Import: show file errors returned by the import dialog
* Keep dropped-file import errors alongside local drop errors
* Import: preserve every file error across background jobs and UI notices
* Import: queue pending errors with bounded notification details
* Import: a damaged VectorCraft preview no longer stops the carried PDF
The importer read every rendition with craft_doc::renditions and then
picked the PDF, so a preview whose base64 was invalid or whose data lay
past the end of the file made the whole import fail. It now reads only
the PDF with craft_doc::rendition, from storytold/craft-libs#546, and
never decodes the preview. A document without a PDF still reports
NoCarriedPdf.
* Import: dismissing a picked import's error status acknowledges its details
A picked or menu import queued its error details with the status
report_import_errors set ("first (and 1 more)"), and show_result_errors
then replaced that status with "first; second". The two never matched,
so clicking the status left the details queued and they showed again.
Import commands now move the queued details to the status that replaces
it, also when After Effects project errors lead it. Other commands'
statuses never take over an import's details.
DialogAnswer.paths became a Result in #3304; three import tests merged
since still passed a plain Vec, so the test build of effectcraft-ui-egui
did not compile on main.
angle_field. The degrees field gets the signed remainder, the sign is painted
only for a positive one, and a typed step goes from the signed remainder.
The degrees field of an angle (Rotation, an effect's angle) showed the
remainder's size, with the minus sign painted beside it, and a typed
number was taken as a size that kept the sign: 50 typed into 0x-20.0
gave -50. The minus sign is now part of the degrees' text, so it is
selected with the rest when typing starts, and a typed number is the
new remainder with its sign: 50 gives +50, -50 gives -50. A positive
remainder still shows its + beside the field.
Fixes#3367
* fix(svg): support static SVG patterns
* fix(svg): cache patterns per viewport
* fix(svg): share cached pattern content
* fix(svg): harden pattern cache keys
* fix(svg): harden pattern inheritance and caching
* Preserve SVG pattern fallback paint
* Format SVG pattern fallback conversion
* Harden SVG pattern resource bounds
* Fix SVG pattern test formatting
* fix(svg): bound hostile path and raster work
* Bound SVG ellipse expansion
* fix(ui-egui): suppress clippy warnings on wasm target
Rename unused `frame` parameter to `_frame` in draw_inner since
pointer_wrap::finish_native is cfg'd out on wasm32. Guard State::disabled
field with #[cfg(any(not(target_arch = "wasm32"), test))] so it only
exists where it's read (finish_frame on native + tests).
* fix: resolve clippy warnings blocking CI
- Rename unused `frame` parameter to `_frame` in draw_inner (wasm target)
- Guard State::disabled field with cfg(native + test) (wasm target)
- Replace chunks_exact(2) with as_chunks::<2>() in SVG polyline/polygon parsing
* fix(svg): budget raster work by affected region and report refusals
Address review on #2732: the finite-work guards charged the whole canvas,
dropping valid sparse art (8x8 image scaled to 1px on 2049x2049, 2x2 rect
under a 1,028-element clip on 512x512, one of six 2x2 rects sharing a 1x1
pattern on 3840x2160).
- Build fill/stroke/image/clip coverage over the device region only and
charge that region; remaining whole-canvas passes are charged to a
render-wide pixel budget (caps are not raised).
- Add try_rasterize/try_rasterize_with returning RasterError; rasterize
keeps its signature. media layered decode now surfaces refusals.
- Pattern content reached through href inherits styles from the owning
pattern; device_region falls back to the full canvas on non-finite input.
- Document new items and the limits in the svg README; regression tests.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
ui_large_project::comp_thumbnail_renders_off_the_ui_thread read the thumbnail cache by its old
storage type, (u64, TextureHandle), which the purge change replaced with a private newtype, so
it never saw the texture land. It now asks cached_thumbnail.
Compare the comp exactly as the frame cache does: a layer's Audio
switch, Audio group and audio effects are pixels when a layer picks
its audio or an expression reads audio, before or after the edit.
Scrubbing Audio Levels read by an expression now draws a draft;
with nothing drawing the audio it keeps Full.
Event::PurgeCaches (Close / New / Open Project, Edit > Purge, footage reloads) now also removes
the Project panel's thumbnail textures and the renders awaited for them. They were keyed by item
id only: the closed project's textures stayed in memory, and an item of the next project with a
closed one's id showed the closed project's picture until its own render landed.
Compare the comp the way the frame cache does (#1083): markers count
as pixels only when an expression reads them, so dragging a marker
keeps Full. Tighten the click and Fast Previews Off tests so they
prove the gesture reached the app.
One rule instead of a flag per gesture: DragWatch snapshots the active
comp and its current frame when the Timeline (and the Properties panel)
starts its pass, and after the pass, while the primary button drags
past a click, a new frame or a comp that no longer draws the same
pixels sets property_interacting until release. This covers the
playhead and timecode, layer moves and trims, slips, key drags and
alt-scale, Quick Offset, the In/Out/Duration cells, property scrubs and
the Graph Editor, and any gesture added later. Clicks, scrolling,
zooming, the work area and selection keep Full. It replaces the
prop.set-only check in apply_actions.
Drag/release tests for the playhead, timecode, layer bar, In trim,
source slip, key drag, the In/Out/Duration cells and a Properties
scrub: a draft while held, Full on the first frame after release.
A click, a work-area drag (same pixels) and Fast Previews off keep
Full.
Conflicts in crates/ui-egui/src/panels/timeline.rs: main split `show`
into helpers, so main's version is taken as is and the Timeline drag
hook is redone on top of the split in the following commits. The UI
test moves to tests/it/ (one integration binary).