Commit Graph
4128 Commits
Author SHA1 Message Date
FredApps 2bfb8bad3b Merge pull request #3254 from vangel76/effect-controls-alt-expression-1460
Alt-click on a stopwatch in Effect Controls adds or removes an expression, as in After Effects, instead of toggling keyframes
2026-11-16 10:28:40 +01:00
FredApps 583a8a02db Merge pull request #3147 from dotCooCoo/fix/plugin-library-file-url-unc
Plug-in Library: a file URL cannot name a network path
2026-11-16 10:26:13 +01:00
FredApps af069369fc Merge pull request #3148 from dotCooCoo/fix/plugin-library-release-urls
Plug-in Library: a package downloads only release assets of its repository
2026-11-16 10:25:12 +01:00
FredApps 3a7999f5cd Merge pull request #3763 from storytold/codex/effectcraft-gif-webp-decode-shared
media: decode animated GIF and WebP through craft-gif and craft-webp (#778)
2026-11-16 10:23:11 +01:00
FredApps 2881f048f1 Merge pull request #3343 from dotCooCoo/fix/update-outcome-at-start
Updates: the first start after an update shows how it ended
2026-11-16 10:23:06 +01:00
FredApps 4e80f99d2f Merge pull request #3344 from dotCooCoo/fix/update-restart-unsaved
Updates: Restart to Update with unsaved changes opens the save prompt
2026-11-16 10:22:13 +01:00
FredApps 432ef4dab6 Merge pull request #3521 from dotCooCoo/fix/font-substitute-test-checks-installed
Fonts: substitute test checks whether the original family is installed
2026-11-16 10:21:11 +01:00
FredApps 3338a45379 Merge pull request #3690 from ZIDAN44/fix/3367-negative-field-edit
Angles: typing into a negative angle's degrees replaces its minus sign (#3367)
2026-11-16 10:19:25 +01:00
FredApps bf8a9b9256 Merge remote-tracking branch 'upstream/main' into codex/effectcraft-gif-webp-decode-shared
# Conflicts:
#	Cargo.lock
2026-11-16 09:50:24 +01:00
FredApps 58f64cdc09 Merge pull request #3653 from storytold/codex/effectcraft-eps-shared-cutover
Use shared EPS font block scanner
2026-11-16 09:47:31 +01:00
FredApps da6e5b874c fix(media): refuse an oversized GIF canvas before scanning its frames 2026-11-16 09:45:16 +01:00
FredApps f6fdd27f36 Merge pull request #3671 from storytold/codex/gif-writer-consumer
export: write animated GIFs with the shared craft-gif writer (#778)
2026-11-16 09:36:06 +01:00
FredApps 3f27fbe217 test(pdf): check the PDFDocEncoding ActualText label end to end 2026-11-16 09:18:04 +01:00
FredApps 9e27d5a0a5 fix(media): keep every decoded GIF and WebP frame past the probe frame count 2026-11-16 09:14:28 +01:00
FredApps 089c35759b test(export): share write_tone between the export integration tests 2026-11-16 09:04:07 +01:00
FredApps 843deea4d6 pdf: decode PDFDocEncoding text strings and bound logical text labels
text_string decoded strings without a byte-order mark as Latin-1, so an
/ActualText with byte 0x80 became U+0080 instead of a bullet. It now maps
PDFDocEncoding's 0x18-0x1F and 0x80-0xA0. Each paint inside an annotation
carries its own copy of the label, so begin_text keeps at most 256 characters
of it.
2026-11-16 08:30:38 +01:00
FredApps 790b065d53 Merge remote-tracking branch 'upstream/main' into codex/effectcraft-eps-shared-cutover
# Conflicts:
#	Cargo.toml
2026-11-16 08:28:12 +01:00
FredApps dd850f92a9 Merge remote-tracking branch 'upstream/main' into codex/effectcraft-gif-webp-decode-shared
# Conflicts:
#	Cargo.toml
#	crates/media/Cargo.toml
2026-11-16 08:25:10 +01:00
FredApps 737322678c Merge pull request #3744 from storytold/extract/shared-spi1d
effects: cut SPI1D parsing over to craft-cms
2026-11-16 08:24:45 +01:00
FredApps 11ac2ad295 Merge remote-tracking branch 'upstream/main' into codex/gif-writer-consumer
# Conflicts:
#	Cargo.toml
2026-11-16 08:21:08 +01:00
FredApps b68b840245 Merge pull request #3646 from storytold/codex/effectcraft-exr-shared-consumer
refactor(exr): decode channels with shared craft-exr
2026-11-16 08:20:17 +01:00
Dylan M. Taylor 186661829a media: decode animated GIF and WebP through craft-gif and craft-webp frames
Carved out of #3649. craft_gif::frames and craft_webp::frames replace the
image crate's animation decoders in gif_anim and webp_anim, with the same
frame, byte and canvas limits and the same damaged-tail behaviour (frames
decoded before the damage are kept). craft-gif and craft-webp are pinned to
craft-libs main 948b5c23 with the frames feature.
2026-11-16 08:18:00 +01:00
FredApps 07250580e2 test(export): share the GIF render and decode setup between the GIF tests
Split the byte-parity check against the former gif 0.13 encoder into its own
test, with the reference encode in a helper.
2026-11-16 08:07:56 +01:00
FredApps 2e8938ca61 Merge remote-tracking branch 'upstream/main' into codex/gif-writer-consumer 2026-11-16 07:59:37 +01:00
FredApps 18adb1ec7a Merge pull request #3643 from storytold/codex/effectcraft-dotlottie-container
Use shared ZIP codec for dotLottie archives
2026-11-16 07:58:45 +01:00
FredApps e9e826bd25 Merge upstream/main into codex/effectcraft-eps-shared-cutover
Pin craft-pdf, craft-ps and the hayro parsers to one craft-libs main revision
(808730f4) so the pdf-deps validator accepts them, and drop the craft-eps
workspace pin that nothing uses after the craft-ps cutover.
2026-11-16 07:56:43 +01:00
FredApps bb0058444b Merge remote-tracking branch 'upstream/main' into extract/shared-spi1d
# Conflicts:
#	Cargo.lock
2026-11-16 07:48:25 +01:00
FredApps 234273d9b8 docs(exr): note the shared decoder's all-channel data-window bound 2026-11-16 07:44:53 +01:00
FredApps 286f2d0661 Merge remote-tracking branch 'upstream/main' into codex/effectcraft-exr-shared-consumer 2026-11-16 07:35:45 +01:00
Dylan M. Taylor cc09cdd4f3 Merge remote-tracking branch 'origin/main' into fix/dotlottie-scope-only 2026-11-16 01:17:52 -05:00
Dylan M. Taylor 45e2fe0506 Merge remote-tracking branch 'origin/main' into fix/gpu-picker-test-lock 2026-11-16 01:17:32 -05:00
Dylan M. Taylor 600db3717f Merge remote-tracking branch 'origin/main' into fix/effect-gpu-integrated 2026-11-16 00:32:26 -05:00
Dylan M. Taylor 218b94224a test(ui): serialize GPU picker integration 2026-11-15 23:57:08 -05:00
Dylan M. Taylor f0a5783a82 fix(gpu): preserve CSP shaper channels on software Vulkan 2026-11-15 23:56:13 -05:00
Dylan M. Taylor 3678cc9bec fix(gpu): bound inverse LUT search and write transfer components explicitly 2026-11-15 23:25:31 -05:00
Dylan M. Taylor 5a7b4e903f test(gpu): isolate inverse LUT and profile readbacks 2026-11-15 23:03:51 -05:00
Dylan M. Taylor 3b4f35eba4 Keep dotLottie cutover separate from coverage PR 3654 2026-11-15 22:13:24 -05:00
Dylan M. Taylor 963fbb1345 Merge commit 'df79630f6f2e00d099c07def39b0230cb759e328' into fix/effect3643-coverage 2026-11-15 20:02:51 -05:00
Dylan M. Taylor 7a179a0efd Merge remote-tracking branch 'origin/main' into fix/effect3643-coverage 2026-11-15 20:02:51 -05:00
Dylan M. Taylor de68d5c300 Pin shared reencoded glyph fallback and test accented EPS 2026-11-15 14:59:50 -05:00
Dylan M. Taylor df3083222a Preserve graphics state across logical text annotations 2026-11-15 14:53:02 -05:00
Dylan M. Taylor 85903800dd Account selected EXR planes per part and skip unused parts 2026-11-15 14:46:37 -05:00
Dylan M. Taylor 70c140f027 Merge main and preserve isolated shared EPS parser suite 2026-11-15 14:27:32 -05:00
Dylan M. Taylor e1fc3ba0dc Merge main while isolating shared GIF writer revision 2026-11-15 14:13:01 -05:00
Dylan M. Taylor d2d3f47d92 Merge main and isolate shared EXR decoder revision 2026-11-15 14:08:54 -05:00
Dylan M. Taylor d7d6007970 effects: use shared SPI1D table reader 2026-11-15 13:49:50 -05:00
Dylan M. Taylor ac1c1d9202 encoding: reuse shared Base64 writers across four consumers 2026-11-15 13:19:05 -05:00
Dylan M. Taylor 8fdbbc604c Refresh shared dotLottie cutover and propagate archive errors 2026-11-15 10:24:25 -05:00
.CooCoo d6c9ad6643 Cineon Converter: Gamma 1 gives linear output and saved projects keep their render (#2312)
## Behavior

A new Cineon Converter opens with Gamma 1.7. Its Version parameter is 2 by default. A converter saved before Version existed opens as version 1, retaining its Gamma value, keyframes, and expression text and rendering on its original scale. Reset keeps the instance's Version.

In version 2:

- Log to Linear raises the exposure to `1 / gamma` before subtracting the black offset and normalizing: `(E^(1/g) - O^(1/g)) / (1 - O^(1/g))`, with `E = 10^((code - white) * 0.002 / 0.6)` and `O` the exposure at the black point. Gamma 1 gives linear output, and a larger Gamma lightens the midtones. Highlight Rolloff then applies as before, and Linear to Log is the inverse.
- Log to Log returns code values unchanged at Gamma 1 and raises the normalized code value to `1 / gamma` at other values. With custom black or white points, the code values first go through the Gamma 1 conversion.

The CPU and GPU paths match. Version 1 instances render as before, and Interpret Footage ▸ Cineon Settings keeps its existing formula, which agrees with the version 2 Converter at Gamma 1.

The public Cineon Converter documentation (https://helpx.adobe.com/after-effects/using/utility-effects.html) describes Gamma as a midtone control and gives no defaults or formula. The default, the Log to Linear curve and the Log to Log behavior come from running and scripting After Effects 26.5 on my own machine and reading back the rendered pixels. In After Effects, choosing Log to Log also sets Gamma to 1 and Highlight Rolloff to 0; EffectCraft does not do that yet, because no command sets one parameter from another.

Animation preset format 3 records `cineonVersion` for a saved Gamma property and stores effect key times relative to the first key. Presets in formats 1 and 2 without that tag contain version 1 Gamma values; format 2 already has relative effect key times. Applying a whole old Cineon Converter also gives it version 1. Exposed Essential Properties Gamma values convert to the target converter version where their target is unambiguous (the conversion keeps the linear point; other Gamma values follow each version's own curve); enabled expressions on another scale are skipped instead of rewriting their source.

A saved Gamma records the Version its converter has at the current time. Applied to a converter whose Version is keyframed, a Gamma preset keeps those keys: the Gamma is converted to the one version they hold, or skipped when they hold several or an expression sets the Version. A preset that also holds the Version sets it from that property.

The project schema remains 2. `docs/architecture.md` describes the behavior above.

## Validation

Effect tests check version 2 Log to Linear at Gamma 1.7 (codes 95 to 685) and Gamma 2.2 (codes 180 to 620), and Log to Log at Gamma 1 (Rolloff 0 and 20) and Gamma 1.7, against the measured 8-bit values within one or two codes, plus round trips, version 1 rendering and the Interpret Footage agreement at Gamma 1. GPU tests compare the version 2 paths with the CPU. Engine tests cover old projects, Reset, presets, keyframes, and Essential Properties.

Commands run on `74d398c2`:

- `cargo fmt --all -- --check`
- `cargo clippy -p effectcraft-effects -p effectcraft-gpu -p effectcraft-project -p effectcraft-engine --all-targets -- -D warnings`
- `cargo test -p effectcraft-effects`: 546 passed (including `effects_doc_is_current`, so `docs/effects.md` needs no change), 1 ignored, plus 6
- `cargo test -p effectcraft-project`: 47 passed
- `cargo test -p effectcraft-gpu`: 253 passed, 1 ignored
- `cargo test -p effectcraft-engine`: 1,007 passed, 5 ignored, plus 27
2026-11-15 12:11:07 +01:00
Dylan M. Taylor 26fa70007a fix(gpu): serialize readback mapping cleanup 2026-11-15 09:21:33 +00:00