mirror of
https://github.com/storytold/effectcraft.git
synced 2026-11-10 20:41:25 +00:00
Scripting: After Effects match names for 14 effects and Casts Shadows (#3122)
* #3113: use After Effects' effect match names in scripting Checked every row of crates/script/src/matchnames.rs against After Effects 26.2 (app.effects, canAddProperty and the layer property trees). Fourteen effect names were wrong: twelve did not exist (Pixel Motion Blur is ADBE OFMotionBlur, Shadow/Highlight is ADBE ShadowHighlight, Ellipse is ADBE ELLIPSE, ...), and Noise and Photo Filter pointed at After Effects' hidden obsolete versions (now ADBE Noise2 and ADBE PhotoFilterPS). A light's Casts Shadows is ADBE Casts Shadows. The old names stay accepted for lookup (addProperty, property(), and parameters such as "ADBE Noise-0001"), so existing scripts keep working; .matchName emits only the After Effects name. A names-only fixture of After Effects' first-party match names backs the new test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Scripting: match names that changed only in case still find effects and parameters property("ADBE Ellipse") and "ADBE Grow Bounds-0001" found nothing after the names became ADBE ELLIPSE / ADBE GROW BOUNDS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
9408d70da0
commit
fee50dbfd1
4 files changed
+490
-17
No files matched your search
@@ -451,6 +451,9 @@ fn find_child<'a>(l: &'a Layer, g: &'a PropGroup, k: &str, depth: u8) -> Option<
|
||||
g.children
|
||||
.iter()
|
||||
.find(|n| chain_of(n) == k)
|
||||
.or_else(|| matchnames::current_name(k).and_then(|m| g.children.iter().find(|n| chain_of(n) == m)))
|
||||
// Match names that changed only in case (`ADBE Ellipse` is now `ADBE ELLIPSE`, #3113).
|
||||
.or_else(|| g.children.iter().find(|n| chain_of(n).eq_ignore_ascii_case(k)))
|
||||
.or_else(|| g.children.iter().find(|n| n.name() == k))
|
||||
.or_else(|| g.children.iter().find(|n| n.match_id() == k))
|
||||
.or_else(|| g.children.iter().find(|n| n.name().eq_ignore_ascii_case(k)))
|
||||
|
||||
Reference in new issue
Block a user