From 2a6cece4ea6c4a9ffa6145d2e2b0a48a7a30b4ff Mon Sep 17 00:00:00 2001 From: zitann2020 Date: Thu, 29 Oct 2026 22:04:20 +0900 Subject: [PATCH 1/2] =?UTF-8?q?i18n(ja):=20the=20Generate=20effect=20categ?= =?UTF-8?q?ory=20is=20=E6=8F=8F=E7=94=BB?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit JAPANESE_CATEGORIES had 20 of the 21 the Simplified table carries, so the Generate group in the Effect menu drew its English name. AE calls it 描画. Co-Authored-By: DeepSeek V4.1 Flash --- crates/ui-egui/src/i18n/effects.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/ui-egui/src/i18n/effects.rs b/crates/ui-egui/src/i18n/effects.rs index 162300f9c..29a850260 100644 --- a/crates/ui-egui/src/i18n/effects.rs +++ b/crates/ui-egui/src/i18n/effects.rs @@ -490,6 +490,7 @@ const JAPANESE_CATEGORIES: &[(&str, &str)] = &[ ("Color Correction", "カラー補正"), ("Distort", "ディストーション"), ("Expression Controls", "式制御"), + ("Generate", "描画"), ("Immersive Video", "イマーシブビデオ"), ("Keying", "キーイング"), ("Matte", "マット"), From 373112b38b274e84f5180a48cd1ca3512e16b5e5 Mon Sep 17 00:00:00 2001 From: zitann2020 Date: Fri, 30 Oct 2026 01:26:44 +0900 Subject: [PATCH 2/2] i18n(ja): Paint and Generate must not draw the same category name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Generate row added here drew 描画, which Paint already used, so the Effect menu showed the same category name twice. 描画 is Adobe's name for Generate, so Paint becomes ペイント, and a test now rejects two categories sharing a Japanese name. Found by the review bot on this PR. Co-Authored-By: DeepSeek V4.1 Flash --- crates/ui-egui/src/i18n/effects.rs | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/crates/ui-egui/src/i18n/effects.rs b/crates/ui-egui/src/i18n/effects.rs index 29a850260..cbcc192da 100644 --- a/crates/ui-egui/src/i18n/effects.rs +++ b/crates/ui-egui/src/i18n/effects.rs @@ -496,7 +496,7 @@ const JAPANESE_CATEGORIES: &[(&str, &str)] = &[ ("Matte", "マット"), ("Noise & Grain", "ノイズ＆グレイン"), ("Obsolete", "旧バージョン"), - ("Paint", "描画"), + ("Paint", "ペイント"), ("Perspective", "遠近"), ("Simulation", "シミュレーション"), ("Stylize", "スタイライズ"), @@ -1002,3 +1002,21 @@ mod tests { assert!(!matches("ec.blur.gaussian", "Gaussian Blur", "高斯")); } } + +#[cfg(test)] +mod japanese_category_tests { + use super::*; + use std::collections::HashMap; + + /// Two categories drawing the same Japanese name would make the Effect menu show one name twice and + /// leave the user unable to tell them apart. `描画` was both `Generate` and `Paint` before #2583. + #[test] + fn no_two_categories_share_a_japanese_name() { + let mut seen: HashMap<&str, &str> = HashMap::new(); + for (english, japanese) in JAPANESE_CATEGORIES { + if let Some(other) = seen.insert(japanese, english) { + panic!("`{english}` and `{other}` both draw as `{japanese}`"); + } + } + } +}