From ce11fbf75f4ffa2906534637bfb8fd44671e1881 Mon Sep 17 00:00:00 2001 From: arnav-hiwarkar Date: Thu, 12 Nov 2026 18:40:39 +0530 Subject: [PATCH] #2869: prove Left still collapses once viewer text editing ends --- crates/ui-egui/tests/it/ui_effect_controls.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/crates/ui-egui/tests/it/ui_effect_controls.rs b/crates/ui-egui/tests/it/ui_effect_controls.rs index ff76a1cb7..8f2910e43 100644 --- a/crates/ui-egui/tests/it/ui_effect_controls.rs +++ b/crates/ui-egui/tests/it/ui_effect_controls.rs @@ -194,7 +194,7 @@ fn effect_header_arrows_work_wherever_effect_controls_is_on_screen() { h.state_mut().toggle_maximize(PanelKind::Composition); assert_eq!(h.state().ui.maximized, Some(PanelKind::Composition), "the frame was maximized from its Composition tab"); } - // The moved tab is the front one; clicking it focuses it. + // The moved tab is the front one; focus it as a click on it would. h.state_mut().ui.focused = PanelKind::EffectControls; h.state_mut().session.state.selected_props = vec![(lid, fx)]; h.run_steps(3); @@ -259,6 +259,9 @@ fn effect_header_arrows_leave_viewer_text_editing_alone() { assert!(h.state().session.state.text_edit.is_some(), "the text is still being edited"); header_arrow_key(&mut h, egui::Key::ArrowLeft, egui::Modifiers::NONE); assert!(h.state().ui.fx_closed.is_empty(), "the text edit owns the arrows"); + h.state_mut().session.state.text_edit = None; + header_arrow_key(&mut h, egui::Key::ArrowLeft, egui::Modifiers::NONE); + assert_eq!(h.state().ui.fx_closed.iter().copied().collect::>(), vec![fx], "with the edit over, Left collapses the effect"); } #[test]