Footage cache (#3271): review fixes

- A covered batch is served before a remembered failure; failures are kept per request, so a
  broken part or too many channels never hides the picture; a picture too large with its
  effects' channels is read alone.
- Hostile headers: parts whose data window or uncompressed block is out of bounds are refused
  before any decoder sees them (index, reader and the image crate's whole-file path, import).
- Seek and read errors are transient (Stopped), not remembered; the copy path notes its file.
- The index drops the headers' other attributes and previews, is bounded by bytes and checks
  the file's identity before it is reused.
- A picture read alone isn't kept twice (plane store and frame cache).
- A waiter whose decodes keep being called off decodes a copy; rounds are bounded.
- The Cryptomatte probe asks with its own effect's need; animated parameters are found in
  nested groups.
- Test hooks and caps are keyed by path; new tests: data window offsets, failures per request,
  too large with channels, the file bound, hostile data windows, damaged files, rows and levels
  on every compression and on tiles.
This commit is contained in:
vangel76 committed 2026-11-08 02:43:58 +01:00
1 parent 63d32fa33e
commit bf48ec8b8e
14 files changed
+636 -174

No files matched your search

+10 -2
View File
@@ -17,7 +17,6 @@
//! the object name reinterpreted as a float with the exponent nudged off 0 and 255, and the
//! manifest maps names to hashes.
/// Depth written where nothing was rendered.
pub const BACKGROUND_DEPTH: f32 = 1.0e10;
@@ -624,7 +623,16 @@ mod tests {
/// the planes; a set holding only some channels keeps listing every Cryptomatte layer.
#[test]
fn needs_resolve_as_the_effects_look_up() {
let all = named(&["A.CryptoAsset00.R", "A.CryptoAsset00.G", "B.CryptoObject00.R", "B.CryptoObject00.G", "Image.R", "depth.Z", "zz.Custom00.R", "zz.Custom00.G"]);
let all = named(&[
"A.CryptoAsset00.R",
"A.CryptoAsset00.G",
"B.CryptoObject00.R",
"B.CryptoObject00.G",
"Image.R",
"depth.Z",
"zz.Custom00.R",
"zz.Custom00.G",
]);
let need = AuxNeed::Lookups(vec![
AuxLookup::Name(" image.r ".into()),
AuxLookup::find(&DEPTH_NAMES),