mirror of
https://github.com/storytold/effectcraft.git
synced 2026-11-20 00:55:43 +00:00
Footage cache (#3271): review fixes
- A covered batch is served before a remembered failure; failures are kept per request, so a broken part or too many channels never hides the picture; a picture too large with its effects' channels is read alone. - Hostile headers: parts whose data window or uncompressed block is out of bounds are refused before any decoder sees them (index, reader and the image crate's whole-file path, import). - Seek and read errors are transient (Stopped), not remembered; the copy path notes its file. - The index drops the headers' other attributes and previews, is bounded by bytes and checks the file's identity before it is reused. - A picture read alone isn't kept twice (plane store and frame cache). - A waiter whose decodes keep being called off decodes a copy; rounds are bounded. - The Cryptomatte probe asks with its own effect's need; animated parameters are found in nested groups. - Test hooks and caps are keyed by path; new tests: data window offsets, failures per request, too large with channels, the file bound, hostile data windows, damaged files, rows and levels on every compression and on tiles.
This commit is contained in:
1 parent
63d32fa33e
commit
bf48ec8b8e
14 files changed
+636
-174
No files matched your search
@@ -520,7 +520,14 @@ impl CryptoProbe {
|
||||
reads: None,
|
||||
};
|
||||
let params = effectcraft_effects::flatten_params(g, &mut |pr| ctx.value(layer, pr));
|
||||
let aux = r.layer_aux(&ctx, layer).ok_or(NO_CRYPTO)?;
|
||||
// The channels the layer's effects read and this effect's (it may be switched off).
|
||||
let own = match &g.kind {
|
||||
effectcraft_project::GroupKind::Effect { effect } => effectcraft_effects::aux_needs(effect, ¶ms),
|
||||
_ => None,
|
||||
};
|
||||
let need =
|
||||
r.layer_aux_need(&ctx, layer).union(own.map_or(effectcraft_raster::channels3d::AuxNeed::All, effectcraft_raster::channels3d::AuxNeed::Lookups));
|
||||
let aux = r.layer_aux_with(&ctx, layer, &need).ok_or(NO_CRYPTO)?;
|
||||
if !live() {
|
||||
return Ok(None);
|
||||
}
|
||||
@@ -540,7 +547,7 @@ impl CryptoProbe {
|
||||
}
|
||||
|
||||
/// Whether a property in `g` other than `skip` changes over time (keyframes or an expression).
|
||||
fn moves(g: &PropGroup, skip: Option<Uid>) -> bool {
|
||||
pub(crate) fn moves(g: &PropGroup, skip: Option<Uid>) -> bool {
|
||||
g.children.iter().any(|c| match c {
|
||||
effectcraft_project::Node::Prop(p) => Some(p.uid) != skip && (p.is_animated() || p.has_expression()),
|
||||
effectcraft_project::Node::Group(g) => moves(g, skip),
|
||||
|
||||
Reference in new issue
Block a user