From a08240155ccec5977a384af0c6dd735d97783860 Mon Sep 17 00:00:00 2001 From: arnav-hiwarkar Date: Thu, 12 Nov 2026 15:47:14 +0530 Subject: [PATCH] #3474: Radial Wipe: Feather takes After Effects' range Feather takes 0..32000, After Effects' recorded valid range in the same units. The CPU and GPU renderers evaluate the feather per pixel in closed form (a Gaussian of the distance to the wedge, radial_wipe_alpha), so a wide feather costs the same and stays finite. Default and slider are unchanged. --- crates/aep/src/export/fx_defs.rs | 1 - crates/effects/src/misc.rs | 2 +- crates/engine/src/tests/effect_ranges.rs | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/aep/src/export/fx_defs.rs b/crates/aep/src/export/fx_defs.rs index 7f1bd8c21..a741397ff 100644 --- a/crates/aep/src/export/fx_defs.rs +++ b/crates/aep/src/export/fx_defs.rs @@ -736,7 +736,6 @@ mod tests { ("ec.distort.turbulentdisplace", "evolutionOptions/randomSeed", 3470), ("ec.distort.transform", "scaleHeight", 3471), ("ec.distort.transform", "scaleWidth", 3471), - ("ec.transition.radialwipe", "feather", 3474), ("ec.generate.beam", "startThickness", 3475), ("ec.generate.beam", "endThickness", 3475), ("ec.stylize.scatter", "amount", 3477), diff --git a/crates/effects/src/misc.rs b/crates/effects/src/misc.rs index a1037c693..9c7131657 100644 --- a/crates/effects/src/misc.rs +++ b/crates/effects/src/misc.rs @@ -919,7 +919,7 @@ pub fn specs() -> Vec { p("startAngle", "Start Angle", num(0.0), ParamUi::Angle), p("center", "Wipe Center", Value::Vec2([0.5, 0.5]), ParamUi::Point), p("wipe", "Wipe", Value::Enum(0), popup(&["Clockwise", "Counterclockwise", "Both"])), - p("feather", "Feather", num(0.0), slider(0.0, 360.0, 0.0, 50.0, 1)), + p("feather", "Feather", num(0.0), slider(0.0, 32000.0, 0.0, 50.0, 1)), ], radial_wipe, ), diff --git a/crates/engine/src/tests/effect_ranges.rs b/crates/engine/src/tests/effect_ranges.rs index 73cb0e5db..3ba91dc5f 100644 --- a/crates/engine/src/tests/effect_ranges.rs +++ b/crates/engine/src/tests/effect_ranges.rs @@ -53,6 +53,7 @@ const ROWS: &[(u32, &str, &str, f64, f64)] = &[ (3476, "ec.generate.grid", "border", 0.0, 2000.0), (3472, "ec.transition.venetian", "width", 1.0, 32000.0), (3473, "ec.transition.venetian", "feather", 0.0, 32000.0), + (3474, "ec.transition.radialwipe", "feather", 0.0, 32000.0), ]; fn path(effect: &str, param: &str) -> String {