From 85f47ec072ce70bc5958d42929f313587d394e2c Mon Sep 17 00:00:00 2001 From: arnav-hiwarkar Date: Thu, 12 Nov 2026 15:47:14 +0530 Subject: [PATCH] #3476: Grid: Border takes After Effects' range Border takes 0..2000, After Effects' recorded valid range in the same units (pixels). The CPU and GPU renderers compute the border per pixel in closed form, so a wider border costs the same; one wider than the cells covers them. Default and slider are unchanged. --- crates/aep/src/export/fx_defs.rs | 1 - crates/effects/src/generate.rs | 2 +- crates/engine/src/tests/effect_ranges.rs | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/aep/src/export/fx_defs.rs b/crates/aep/src/export/fx_defs.rs index 865d1fef2..d65448651 100644 --- a/crates/aep/src/export/fx_defs.rs +++ b/crates/aep/src/export/fx_defs.rs @@ -741,7 +741,6 @@ mod tests { ("ec.transition.radialwipe", "feather", 3474), ("ec.generate.beam", "startThickness", 3475), ("ec.generate.beam", "endThickness", 3475), - ("ec.generate.grid", "border", 3476), ("ec.stylize.scatter", "amount", 3477), ("ec.time.pixelmotionblur", "shutterAngle", 3481), ("ec.time.pixelmotionblur", "shutterSamples", 3482), diff --git a/crates/effects/src/generate.rs b/crates/effects/src/generate.rs index 47a6d6314..d8d47a7c7 100644 --- a/crates/effects/src/generate.rs +++ b/crates/effects/src/generate.rs @@ -391,7 +391,7 @@ pub fn specs() -> Vec { p("corner", "Corner", pt(0.1, 0.1), ParamUi::Point), p("width", "Width", num(64.0), slider(1.0, 4000.0, 1.0, 400.0, 1)), p("height", "Height", num(64.0), slider(1.0, 4000.0, 1.0, 400.0, 1)), - p("border", "Border", num(2.0), slider(0.0, 400.0, 0.0, 40.0, 1)), + p("border", "Border", num(2.0), slider(0.0, 2000.0, 0.0, 40.0, 1)), p("feather/featherWidth", "Width", num(0.0), slider(0.0, 1000.0, 0.0, 50.0, 1)), p("feather/featherHeight", "Height", num(0.0), slider(0.0, 1000.0, 0.0, 50.0, 1)), p("invertGrid", "Invert Grid", Value::Bool(false), ParamUi::Checkbox), diff --git a/crates/engine/src/tests/effect_ranges.rs b/crates/engine/src/tests/effect_ranges.rs index 08a57fa3b..76d7610d3 100644 --- a/crates/engine/src/tests/effect_ranges.rs +++ b/crates/engine/src/tests/effect_ranges.rs @@ -50,6 +50,7 @@ const ROWS: &[(u32, &str, &str, f64, f64)] = &[ (3483, "ec.noise.noisehlsauto", "saturation", 0.0, 1000.0), (3484, "ec.noise.noisehlsauto", "grainSize", 0.0, 100.0), (3480, "ec.color.changecolor", "hueTransform", -1800.0, 1800.0), + (3476, "ec.generate.grid", "border", 0.0, 2000.0), ]; fn path(effect: &str, param: &str) -> String {