mirror of
https://github.com/storytold/effectcraft.git
synced 2026-11-16 15:22:43 +00:00
Plug-in Library: a package with an unreadable repo URL downloads nothing
When a package names a `repo` that isn't a GitHub repository URL (`https://github.com/<owner>/<repo>`, a trailing `/` or `.git` allowed, or a folder in one, `.../tree/<ref>/<path>`), Install, Update and Preview now refuse its release URLs with an error naming the package. Before, such a `repo` skipped the repository check and any GitHub release asset was downloaded. A package without a `repo` keeps any repository's release asset. The example catalog's schema now holds `repo` and release `url` to the same forms, and `scripts/validate.sh` checks that every release is an asset of the package's `repo` before it downloads anything.
This commit is contained in:
1 parent
75fed052e3
commit
5dfcadd09b
6 files changed
+117
-29
No files matched your search
+4
-2
@@ -375,8 +375,10 @@ package can't read files, open the network or crash the app.
|
||||
catalog gives one) against the catalog and loads it. Downloads use the system's `curl`,
|
||||
`https://` only and starting on GitHub's hosts (redirects stay on `https://`; the SHA-256 check
|
||||
is what guarantees the file). A package's `url` must be a release asset
|
||||
(`https://github.com/<owner>/<repo>/releases/download/…`), in the package's `repo` when that is
|
||||
a GitHub repository URL. A catalog other than the community one is read only when
|
||||
(`https://github.com/<owner>/<repo>/releases/download/…`). When the package names a `repo`, the
|
||||
asset must be in that repository. A `repo` that isn't `https://github.com/<owner>/<repo>` (with
|
||||
an optional trailing `/` or `.git`) or a folder in one (`https://github.com/<owner>/<repo>/tree/<ref>/…`)
|
||||
makes Install and Preview refuse every release of the package. A catalog other than the community one is read only when
|
||||
`library.refresh {catalog}` names it: an `index.json` on GitHub's hosts over `https://`, or a
|
||||
local `file://` path.
|
||||
* **Where it goes.** `<Plug-ins>/Library/<id>/<version>/<id>.wasm` (the `Plug-ins` folder next to
|
||||
|
||||
Reference in new issue
Block a user