mirror of
https://github.com/storytold/effectcraft.git
synced 2026-11-16 15:22:43 +00:00
Merge pull request #3147 from dotCooCoo/fix/plugin-library-file-url-unc
Plug-in Library: a file URL cannot name a network path
This commit is contained in:
3 files changed
+72
-15
No files matched your search
+2
-1
@@ -388,7 +388,8 @@ package can't read files, open the network or crash the app.
|
||||
[`storytold/effectcraft-plugins`](https://github.com/storytold/effectcraft-plugins) repository;
|
||||
packages are added by pull request and reviewed there. The app has no field for another
|
||||
catalog; `library.refresh {catalog}` (for plug-in authors testing an entry) takes an `index.json`
|
||||
on GitHub or a local file, and the page then says it shows a test catalog until Refresh.
|
||||
on GitHub or a local file, and the page then says it shows a test catalog until Refresh. A file
|
||||
URL that names a network path (`file:////server/share/…`) is refused.
|
||||
* **Nothing is downloaded until you ask.** Fetch Catalog (`library.refresh`) reads the catalog;
|
||||
Install (`library.install`) downloads the package's `.wasm`, checks its SHA-256 (and its size, when the
|
||||
catalog gives one) against the catalog and loads it. Downloads use the system's `curl`,
|
||||
|
||||
@@ -226,7 +226,9 @@ Make a folder with an `index.json` that holds only your package:
|
||||
```
|
||||
|
||||
File URLs are absolute: `file:///home/me/glow-rings/index.json` on Linux and macOS,
|
||||
`file:///C:/Users/me/glow-rings/index.json` on Windows. Write a space as `%20`.
|
||||
`file:///C:/Users/me/glow-rings/index.json` on Windows. Write a space as `%20`. Separate folders
|
||||
with `/`: a file URL that holds a `\` or a percent-encoded `/` or `\`, or names a network path
|
||||
(`file:////server/share/…`), is refused.
|
||||
|
||||
Use a separate settings folder, so the test doesn't touch your real installation:
|
||||
|
||||
|
||||
Reference in new issue
Block a user