mirror of
https://github.com/storytold/effectcraft.git
synced 2026-11-20 09:05:51 +00:00
Disk cache: Reload Footage drops the entries of its files, docs
File > Reload Footage now deletes the frame and layer entries whose file lists name the reloaded item's files (DiskCache::drop_files), so a file replaced by one with the same size and modification time, which the check on hit can't tell apart, is read again. The index knows keys, not files: the writer thread reads the files section at the start of each frame and layer entry (not the pixels) after the writes queued before it, and deletes the entries that list one of the files. Until it is done, an entry made of one of them is a miss and frames aren't linked to new keys. The entries are gone for good, so they don't come back after a restart. Automatic reloads don't drop anything: they follow a changed stamp, which the check on hit catches. The browser needs nothing (its file identities are content hashes). Removed: disk_cache::seal, which steps 2 and 3 left without callers (the tests use seal_format). Updated the module, seal_format and forget_media docs, and docs/architecture.md / docs/web.md describe the final design: what is cached, keys from memory, file lists checked on hit, nothing scans the project, incomplete lists stay in memory, Reload Footage drops entries, edits keep the frames they can't change. Tests: render unit tests (same size and time passes the check but not the drop; other files' entries stay; an entry queued before the drop is dropped; a layer entry too; written again afterwards it is used; the drop survives a restart; a pending drop is a miss), and an engine test through file.reloadFootage. Closes #3184. Part of #1492. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
642fcb7bcb
commit
0bf8bf2b5e
5 files changed
+297
-43
No files matched your search
+5
-3
@@ -334,9 +334,11 @@ Settings ▸ Disk ▸ Disk Cache works in the browser, backed by the **Origin Pr
|
||||
(`src/diskcache.rs`): viewer frames are kept under `effectcraft-cache/v1/frames/<32 hex>.ecc`
|
||||
between visits, in the desktop cache's format (`disk_cache::frame_entry`: the source files the
|
||||
frame read with their size and content hash, then 8-bit premultiplied RGBA, LZ4, a checksum),
|
||||
keyed by the same content hash (the comp and everything it uses as held in memory, frame, scale,
|
||||
view, render options). The page reads an entry only while the files it lists are unchanged; a
|
||||
frame whose files can't all be named is not stored.
|
||||
keyed by the same content hash (from memory: the comp, everything it can draw and what its
|
||||
expressions can read, frame, scale, view, render options; see
|
||||
[architecture.md](architecture.md)). The page reads an entry only while the files it lists are
|
||||
unchanged; a frame whose files can't all be named is not stored. Reload Footage has nothing to
|
||||
drop here: the file table's identities are content hashes, so a replaced file never matches.
|
||||
|
||||
- A render request to a frame worker carries the frame's disk key; the worker posts the frame,
|
||||
then writes the entry with a **synchronous access handle** into a temporary file moved into
|
||||
|
||||
Reference in new issue
Block a user