From 6b9c47fdb2a514a1a00829e17f24e8699cf7d6ae Mon Sep 17 00:00:00 2001 From: "autocraft-bot[bot]" <354215646+autocraft-bot[bot]@users.noreply.github.com> Date: Thu, 12 Nov 2026 05:37:36 +0000 Subject: [PATCH] Apply review fixes - crates/ui-egui/src/app/clipboard.rs - docs/egui-037-migration-plan.md --- crates/ui-egui/src/app/clipboard.rs | 2 +- docs/egui-037-migration-plan.md | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/crates/ui-egui/src/app/clipboard.rs b/crates/ui-egui/src/app/clipboard.rs index bff5156f7..a50aff456 100644 --- a/crates/ui-egui/src/app/clipboard.rs +++ b/crates/ui-egui/src/app/clipboard.rs @@ -59,7 +59,7 @@ impl DesignApp { if !typing && !ours && !copied_here - && text.is_none_or(is_bare_address) + && text.is_none_or(|t| t.trim().is_empty() || is_bare_address(t)) && let Some(image) = self.services.clipboard_image.as_mut().and_then(|f| f()) { return Pasted::Image(image); diff --git a/docs/egui-037-migration-plan.md b/docs/egui-037-migration-plan.md index 165db7892..dc77c55e7 100644 --- a/docs/egui-037-migration-plan.md +++ b/docs/egui-037-migration-plan.md @@ -494,9 +494,8 @@ Clipboard: freshness, owner/seat changes, empty/absent offers, self-paste, canceled/slow transfers, password exclusion and no unchanged-selection reclaim on wlroots/KWin/Mutter. Native capability evidence is still required; compile-only is not acceptance. -- `Event::PasteImage` is new but DesignCraft has no image-paste contract. Leave it - unhandled rather than inventing a placement path. Add a test that it does not panic and - does not leak into text paste. +- `Event::PasteImage` (an image on the clipboard with no text) pastes through `edit.pasteImage`: in the + selected empty frame, else centered in the view, and never into text being edited. Keyboard layouts: after the fork pin, `RawInput::keyboard_layout_is_latin` and `RawInput::latin_layout_chars` (E19) must preserve tool and command shortcuts on Russian,