Keep both sets of import state: the rollback's kept-chart key log and main's
chart decode budget (rejected_kept, chart_decode_bytes). A capture refused by
the retained-byte check records no key; chart decode work stays charged across
a rollback.
* M1951: document the PPTX slide-list import limit
* M1951: expose the slide-list limit in public API docs
---------
Co-authored-by: cloutier <1014864+cloutier@users.noreply.github.com>
* PPTX: evaluate a custom geometry's guide lists once per coordinate space
* address review: exempt guide-free geometries from the space cap
* address review: budget guide-name bytes cached across coordinate spaces
* Apply review fixes
- crates/pptx/src/custgeom.rs
* fix(pptx): warn when custom geometry paths are left out for the guide-cache limits
---------
Co-authored-by: autocraft-bot[bot] <354215646+autocraft-bot[bot]@users.noreply.github.com>
Review fixes: an entry's size, weight and colour are read from its
paragraph (a:p) first and from a:lstStyle only where the paragraph
sets none, as DrawingML inherits them; the writer keeps sizes to the
reader's 1-400 pt, so a size reads back as written; and the legend
draws an entry at its own size up to 400 pt rather than up to 8 times
the legend's.
A c:legendEntry can give one legend entry its own text (c:txPr), as
decks do to make legend text white on a dark chart. It was never read,
so every entry drew in the legend's text. The chart model keeps each
entry's size, bold and colour (Chart::legend_entries); the reader
takes them from the entry's c:txPr, the legend draws each name, key
and row at its entry's size and in its weight and colour, and a chart
rebuilt after an edit writes them back before c:overlay, in schema
order. Entries that set none of the three are not kept.
Fixes#2067
* PPTX export: stop adding chart series once a group's caches pass a point budget
* address review: size chart exports from the caches each group writes
* address review: cut each chart data cache at a cap far above Excel's 32,000 points per series, so the first series is bounded without failing export
* PPTX: charge repeated chart decodes and sidecar copies to presentation-wide budgets
* address review: count all chart vectors and relationship strings; reject a chart that crosses the presentation limit
* address review: charge chart part names/content types, roll back rejected capture
* address review: bound chart decode work across rejected and repeated references, cache refused sidecar captures
* address review: keep a chart past the presentation chart limits as its original part and closure, so a save writes it back
* pptx: preserve SmartArt node text when dgm:cxnLst has no parent-child connections
* fix(pptx): apply unconnected-point SmartArt outline fallback when type="doc" point is absent
* fix(pptx): restrict SmartArt pt_order fallback to empty parOf graphs and preserve cached Picture/Connector children
* fix(pptx): convert default rect geometry to line for connectors in diagram drawings
* docs(pptx): note flat ptLst order fallback on dgm::outline
When a slide has an associated notes slide with no text, PPTX export
previously omitted both the notes slide part and its relationship,
treating notes slides without text runs as removable.
Track whether a slide has an associated notes slide (`has_notes_slide`).
Import marks it when reading a notes slide relationship, and export keeps
the notes slide part, its slide relationship, and notes master linkage
even when its text body is empty. Native serialization preserves the
presence flag, and setting notes via `slide.notes` also enables it.
Regression test in `crates/pptx/tests/it/notes.rs` verifies that a slide
with an empty notes slide retains its notes part and relationship across
multiple import and export roundtrips.