From 65ddd8ad517e15032195059c73f54c690e5d2dbf Mon Sep 17 00:00:00 2001
From: aiongg <67543387+aiongg@users.noreply.github.com>
Date: Wed, 4 Nov 2026 20:55:43 +0000
Subject: [PATCH] Apply review fixes

- crates/render/src/placed.rs
---
 crates/render/src/placed.rs | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/crates/render/src/placed.rs b/crates/render/src/placed.rs
index bde0fa157..483db41bc 100644
--- a/crates/render/src/placed.rs
+++ b/crates/render/src/placed.rs
@@ -160,16 +160,6 @@ fn place(out: &mut Placed, rctx: &Ctx, fields: &SlideFields, s: &Shape, parent:
 fn place_text(out: &mut Placed, rctx: &Ctx, fields: &SlideFields, owner: ShapeId, s: &Shape, body: &TextBody, tr: Rect, m: Affine) {
     let layout = deckcraft_text::layout(rctx, s, body, &Opts { rect: tr, fields, prompt_color: None, no_shrink: false });
     let m = crate::text_transform(m, tr, layout.rotation);
-    // Text hyperlinks: one box per line segment of a linked run.
-    for run in layout.runs.iter().filter(|r| r.link && !r.glyphs.is_empty()) {
-        let Some(link) = run_link(body, run.para, run.chars.0) else { continue };
-        let Some(line) = layout.lines.iter().find(|l| l.para == run.para && l.start <= run.chars.0 && run.chars.0 <= l.end) else { continue };
-        // The run's visual extent (right-to-left runs run from right to left).
-        let first = run.glyphs.first().map(|g| g.1).unwrap_or(0.0);
-        let (x0, x1) = line.span(run.chars.0, run.chars.1).unwrap_or((first, first));
-        let r = Rect::new(x0, line.top, x1, line.bottom);
-        out.links.push(PlacedLink { rect: m.transform_rect_bbox(r), link, shape: owner, text: true });
-    }
     // Field runs carry their saved text (`‹#›`); the layout drew their values, so the body that
     // goes with it (character offsets, text layer) must hold the same values.
     let mut placed = body.clone();
@@ -185,6 +175,16 @@ fn place_text(out: &mut Placed, rctx: &Ctx, fields: &SlideFields, owner: ShapeId
             }
         }
     }
+    // Text hyperlinks: one box per line segment of a linked run.
+    for run in layout.runs.iter().filter(|r| r.link && !r.glyphs.is_empty()) {
+        let Some(link) = run_link(&placed, run.para, run.chars.0) else { continue };
+        let Some(line) = layout.lines.iter().find(|l| l.para == run.para && l.start <= run.chars.0 && run.chars.0 <= l.end) else { continue };
+        // The run's visual extent (right-to-left runs run from right to left).
+        let first = run.glyphs.first().map(|g| g.1).unwrap_or(0.0);
+        let (x0, x1) = line.span(run.chars.0, run.chars.1).unwrap_or((first, first));
+        let r = Rect::new(x0, line.top, x1, line.bottom);
+        out.links.push(PlacedLink { rect: m.transform_rect_bbox(r), link, shape: owner, text: true });
+    }
     out.texts.push(PlacedText { layout, transform: m, body: placed });
 }