From 653f59695888a73725110a7944ce67c100208b24 Mon Sep 17 00:00:00 2001
From: "Dylan M. Taylor" <dylan@dylanmtaylor.com>
Date: Thu, 12 Nov 2026 06:28:30 -0500
Subject: [PATCH] Chart render: budget category-by-series cells

* Chart render: budget category-by-series cells before drawing

* fix(render): chart cell budget is Excel's 255 series x 32,000 points
---
 crates/render/src/chart.rs | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/crates/render/src/chart.rs b/crates/render/src/chart.rs
index 9eaf637cc..443ae8e02 100644
--- a/crates/render/src/chart.rs
+++ b/crates/render/src/chart.rs
@@ -250,7 +250,24 @@ fn axis_ticks((lo, hi, st): (f64, f64, f64)) -> impl Iterator<Item = f64> {
     (0..=n).map(move |k| lo + k as f64 * st)
 }
 
+/// Most category-by-series cells one chart draws: Excel's 255 series x 32,000 points per series
+/// (8,160,000); ordinary charts hold a few hundred.
+const MAX_CHART_CELLS: usize = 255 * 32_000;
+
+/// Whether the independent category and series lists make the drawing loops multiply past the budget.
+fn over_cell_budget(c: &Chart) -> bool {
+    let ncat = c.categories.len().max(c.series.iter().map(|s| s.values.len()).max().unwrap_or(0));
+    cells_over_budget(ncat, c.series.len())
+}
+
+fn cells_over_budget(categories: usize, series: usize) -> bool {
+    categories.saturating_mul(series.max(1)) > MAX_CHART_CELLS
+}
+
 pub fn draw(ctx: &mut RenderContext, rctx: &Ctx, c: &Chart, m: Affine, w: f64, h: f64) {
+    if over_cell_budget(c) {
+        return;
+    }
     match c.kind {
         // Histograms and Pareto charts are drawn as the column (and line) chart of their bins.
         ChartType::Histogram | ChartType::Pareto => {
@@ -1437,6 +1454,16 @@ mod tests {
 
     const AREA: Rect = Rect::new(0.0, 0.0, 400.0, 300.0);
 
+    #[test]
+    fn category_by_series_cells_are_budgeted() {
+        assert!(!over_cell_budget(&Chart::sample(ChartType::Column)));
+        // Excel's maximum chart (255 series x 32,000 points) is within the budget; one more point is not.
+        assert_eq!(MAX_CHART_CELLS, 8_160_000);
+        assert!(!cells_over_budget(32_000, 255));
+        assert!(cells_over_budget(32_001, 255));
+        assert!(cells_over_budget(usize::MAX, 2));
+    }
+
     #[test]
     fn tiny_data_gets_several_ticks() {
         let sc = deckcraft_model::chart::axis_scale(1e-13, 5e-13, None, None, None, 8, true);