diff --git a/Cargo.lock b/Cargo.lock index f23074246..414a49d9d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -868,7 +868,7 @@ name = "craft-deckcraft-format" version = "0.1.0" source = "git+https://github.com/storytold/craft-libs?rev=254e9a409b410dc93c0e06ff66cd1e767893ac32#254e9a409b410dc93c0e06ff66cd1e767893ac32" dependencies = [ - "craft-zip", + "craft-zip 0.1.0 (git+https://github.com/storytold/craft-libs?rev=254e9a409b410dc93c0e06ff66cd1e767893ac32)", "serde", "serde_json", "thiserror 2.0.21", @@ -932,6 +932,17 @@ dependencies = [ "encoding_rs", ] +[[package]] +name = "craft-opc" +version = "0.1.0" +source = "git+https://github.com/storytold/craft-libs?rev=ea24422ae9859dc5da398d0462bc87f8e02e0d10#ea24422ae9859dc5da398d0462bc87f8e02e0d10" +dependencies = [ + "craft-xml", + "craft-zip 0.1.0 (git+https://github.com/storytold/craft-libs?rev=ea24422ae9859dc5da398d0462bc87f8e02e0d10)", + "log", + "thiserror 2.0.21", +] + [[package]] name = "craft-pdf" version = "0.1.0" @@ -1046,6 +1057,16 @@ dependencies = [ "zip 9.1.0", ] +[[package]] +name = "craft-zip" +version = "0.1.0" +source = "git+https://github.com/storytold/craft-libs?rev=ea24422ae9859dc5da398d0462bc87f8e02e0d10#ea24422ae9859dc5da398d0462bc87f8e02e0d10" +dependencies = [ + "flate2", + "thiserror 2.0.21", + "zip 9.1.0", +] + [[package]] name = "crc32fast" version = "1.5.2" @@ -1280,6 +1301,7 @@ dependencies = [ name = "deckcraft-pptx" version = "0.19.0" dependencies = [ + "craft-opc", "craft-xml", "deckcraft-color", "deckcraft-engine", diff --git a/Cargo.toml b/Cargo.toml index cb0c188bb..1d0a505ab 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -11,6 +11,8 @@ rust-version = "1.95" repository = "https://github.com/storytold/deckcraft" [workspace.dependencies] +# OPC part-name primitives; relationship admission stays app-local. +craft-opc = { git = "https://github.com/storytold/craft-libs", rev = "ea24422ae9859dc5da398d0462bc87f8e02e0d10", version = "0.1.0" } # XML writer primitives; parser admission and OOXML policy stay app-local. craft-xml = { git = "https://github.com/storytold/craft-libs", rev = "ea24422ae9859dc5da398d0462bc87f8e02e0d10", version = "0.1.0" } # internal diff --git a/crates/pptx/Cargo.toml b/crates/pptx/Cargo.toml index fd9a6fc4e..419c39bad 100644 --- a/crates/pptx/Cargo.toml +++ b/crates/pptx/Cargo.toml @@ -9,6 +9,7 @@ description = "DeckCraft PPTX: Office Open XML (PresentationML/DrawingML) import workspace = true [dependencies] +craft-opc.workspace = true craft-xml.workspace = true deckcraft-model = { workspace = true } deckcraft-geom = { workspace = true } diff --git a/crates/pptx/src/opc.rs b/crates/pptx/src/opc.rs index 807443b91..f8e582438 100644 --- a/crates/pptx/src/opc.rs +++ b/crates/pptx/src/opc.rs @@ -255,46 +255,11 @@ pub fn sidecar_part(name: &str) -> bool { } pub fn dir_of(part: &str) -> String { - let p = part.trim_start_matches('/'); - match p.rfind('/') { - Some(i) => p.get(..i).unwrap_or("").to_string(), - None => String::new(), - } + craft_opc::dir_of(part).to_owned() } -pub fn file_of(part: &str) -> &str { - part.rsplit('/').next().unwrap_or(part) -} - -pub fn rels_path(part: &str) -> String { - let p = part.trim_start_matches('/'); - let dir = dir_of(p); - let file = file_of(p); - if dir.is_empty() { format!("_rels/{file}.rels") } else { format!("{dir}/_rels/{file}.rels") } -} - -fn percent_decode(s: &str) -> String { - let b = s.as_bytes(); - let mut out = Vec::with_capacity(b.len()); - let mut i = 0; - while i < b.len() { - let c = b.get(i).copied().unwrap_or(0); - if c == b'%' - && let Some(h) = b - .get(i + 1..i + 3) - .filter(|h| h.iter().all(u8::is_ascii_hexdigit)) - .and_then(|h| std::str::from_utf8(h).ok()) - .and_then(|h| u8::from_str_radix(h, 16).ok()) - { - out.push(h); - i += 3; - continue; - } - out.push(c); - i += 1; - } - String::from_utf8_lossy(&out).into_owned() -} +use craft_opc::percent_decode; +pub use craft_opc::{file_of, rels_path}; /// Resolve a relative target against a base directory into a part name. pub fn resolve(base: &str, target: &str) -> String { @@ -469,6 +434,27 @@ impl PackageOut { mod tests { use super::*; + #[test] + fn shared_names_preserve_relationship_wire_policy() { + for (part, dir, file, rels) in [ + ("", "", "", "_rels/.rels"), + ("/", "", "", "_rels/.rels"), + ("///ppt/slides/slide1.xml", "ppt/slides", "slide1.xml", "ppt/slides/_rels/slide1.xml.rels"), + ("ppt/", "ppt", "", "ppt/_rels/.rels"), + ("é/😀.xml", "é", "😀.xml", "é/_rels/😀.xml.rels"), + ] { + assert_eq!(dir_of(part), dir); + assert_eq!(file_of(part), file); + assert_eq!(rels_path(part), rels); + } + assert_eq!(percent_decode("a+b%20c%2Fd%23e"), "a+b c/d#e"); + assert_eq!(percent_decode("% %1 %zz %+1 %ff"), "% %1 %zz %+1 �"); + // Keep Deck's policy: strip the raw fragment first, then decode percent escapes once. + assert_eq!(resolve("ppt/slides", "../media/a%23b.png#ignored"), "ppt/media/a#b.png"); + assert_eq!(resolve("ppt/slides", "%252e%252e/a"), "ppt/slides/%2e%2e/a"); + assert_eq!(resolve("ppt/slides", "%2e%2e/%2e%2e/%2e%2e/a"), "a"); + } + #[test] fn resolve_keeps_encoded_hash_and_strips_fragment() { assert_eq!(resolve("ppt/slides", "../media/a%23b.png"), "ppt/media/a#b.png");