From 3bad02d1f1b05fc8494563fcf7444331a98f8ebb Mon Sep 17 00:00:00 2001 From: Mex <44814932+MMexicann@users.noreply.github.com> Date: Sun, 15 Nov 2026 15:51:32 +0100 Subject: [PATCH] fix: skip escaped symbols in RTF Unicode fallback (#2150) Count an escaped RTF control symbol as one Unicode fallback character and keep parser positions at UTF-8 boundaries. Extend the parser regressions for escaped fallback sequences. --- crates/format/src/rtf.rs | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/crates/format/src/rtf.rs b/crates/format/src/rtf.rs index 4e7e29583..5eac5ade9 100644 --- a/crates/format/src/rtf.rs +++ b/crates/format/src/rtf.rs @@ -276,6 +276,9 @@ impl Outline<'_> { while k > 0 && self.i < self.b.len() { if self.b[self.i] == b'\\' && self.b.get(self.i + 1) == Some(&b'\'') { self.i = advance(self.rtf, self.i, 4); + } else if self.b[self.i] == b'\\' && self.b.get(self.i + 1).is_some_and(|b| !b.is_ascii_alphabetic()) { + // An escaped control symbol counts as one Unicode fallback character. + self.i = advance(self.rtf, self.i + 1, 1); } else if matches!(self.b[self.i], b'{' | b'}' | b'\\') { break; } else { @@ -422,6 +425,23 @@ mod tests { assert_eq!(rtf_to_outline(r"{\rtf1 x\u-70000?y\par}"), "x\u{ee90}y\n"); } + #[test] + fn unicode_fallback_control_symbols_are_skipped() { + for (rtf, expected) in [ + (r"{\rtf1\uc1 \u92\\X\par}", "\\X\n"), + (r"{\rtf1\uc1 \u123\{X\par}", "{X\n"), + (r"{\rtf1\uc1 \u125\}X\par}", "}X\n"), + (r"{\rtf1\uc2 \u233\{\}X\par}", "éX\n"), + (r"{\rtf1\uc0 \u92\\X\par}", "\\\\X\n"), + (r"{\rtf1 \\ \{ \}X\par}", "\\ { }X\n"), + (r"{\rtf1\uc1 \u233{X}\par}", "éX\n"), + (r"{\rtf1\uc1 \u233\éX\par}", "éX\n"), + (r"{\rtf1\uc1 \u233\", "é\n"), + ] { + assert_eq!(rtf_to_outline(rtf), expected, "{rtf:?}"); + } + } + #[test] fn multibyte_control_symbol_keeps_character_and_following_text() { assert_eq!(rtf_to_outline("{\\rtf1 A\\éB\\par}"), "AéB\n");