mirror of
https://github.com/storytold/craft-libs.git
synced 2026-10-31 15:49:54 +00:00
aiongg
07047b7221
* media: add craft-media with bitstream and isobmff from FilmCraft Moves filmcraft-bitstream and filmcraft-isobmff (storytold/filmcraft@6c3948a) into one crate with a feature per module. The public API matches FilmCraft's so its crates can become re-exports. Tests, oracle tests and fuzzing come along; the ffmpeg discovery helpers replace filmcraft-testkit. Out-of-contract inputs no longer panic: bit widths above 32, a zero NAL length prefix width, and PCM frame sizes that overflow u32. Adds BitReader::read_ue_plus from DeckCraft's copy. * media: public ISO BMFF box reader (isobmff::boxes) Make the demuxer's box iterator and big-endian reader public as isobmff::boxes::{BoxIter, BoxRef, BoxHeader, Reader}, for walkers of boxes the demuxer does not model (CR3 uuid boxes, HEIF meta items, JPEG 2000). BoxIter::within keeps offsets relative to the outer slice, and allow_truncated yields a cut last box. The fuzz test walks every box of each mutated file. * media: matroska feature from FilmCraft's filmcraft-matroska Port storytold/filmcraft@6c3948a crates/matroska as craft_media::matroska behind the opt-in feature matroska, with the same public API so FilmCraft can make filmcraft-matroska a re-export. Its unit and ffprobe oracle tests come with it, on craft-media's test helpers. From DeckCraft's copy: cluster and block timestamps no longer overflow; they saturate at i64::MAX. MuxingApp and the default WritingApp name craft-media. New tests: block additions and mutation fuzzing. The oracle skips the duration of a track's last packet when ffmpeg 8 shortened it. * media: MOV PCM uses lpcm v2 above 16.16 rates and for unsigned 16-bit; signed 8-bit as twos Version 0 sound descriptions store the rate as 16.16 fixed point, so 88.2 kHz and higher were written as 0 Hz. 8-bit signed PCM was labelled raw (unsigned) and 16-bit unsigned as twos/sowt (signed). The reader also took raw under a sound handler for uncompressed video. * media: stop the top-level box scan at a box that runs past the end of the file A 64-bit box size near u64::MAX saturated the scan offset, and the next offset + 8 overflowed. * media: one sample budget for the whole ISO BMFF file The sample cap and the file-length bound on samples without table entries (constant-size stsz, trun without per-sample fields) applied per track or per trun, so repeating a small trak or trun multiplied the allocation. Both are now shared by all tracks and fragments. * media: set_sample_entry rejects entries that change the track's media type or PCM frame size The handler, stsz constant size and PCM timescale check are fixed at add_track; a replacement that changed them produced a corrupt file. A bad track index returns NoSuchTrack like the other writer methods. * media: saturate the sample end in MkvFile::duration_ns Cluster timestamps saturate at i64::MAX, so pts + duration could overflow for files without Info/Duration. * media: checked add for the Matroska cue cluster position CueClusterPosition comes from the file; an add past u64::MAX panicked in debug builds and wrapped in release. Such a cue now falls back to the index. * media: cap the Matroska TimestampScale at 2^32 and saturate tick conversions A scale near 2^64 overflowed u128/i128 in the per-lace split and in Track::ticks_to_ns. A BlockDuration near u64::MAX also overflowed the tick difference at the default scale. Larger scales are ignored like a zero scale, and tick and nanosecond values outside i64 saturate. * media: Matroska fixture generation no longer truncates the shared subtitle inputs Parallel tests generating subs.mkv or webvtt.webm could read in.srt or in.vtt while another thread rewrote it, and cache a fixture with missing packets. * media: rustfmt parse_moof signature * ci: add craft-media workflow covering feature sets, WASM and ffmpeg oracles The lint job runs fmt, clippy for each feature set (none, bitstream, isobmff, matroska, all) and a wasm32 check. The test job runs the all-features tests with Ubuntu's ffmpeg and CRAFT_MEDIA_REQUIRE_ORACLES=1, installing ffmpeg while the tests compile. * media: Matroska lacing keeps timestamp gaps A laced frame's timestamp is implied by the block's and the track's DefaultDuration, so lacing collapsed gaps in the input. A frame now joins a lace only when that implied tick equals its own, and tracks without a DefaultDuration do not lace. The laced remux oracle compares timestamps. * media: required oracles fail on fixture generator and ffprobe failures Every path that gave up on an oracle check (missing tool, failed fixture generator, failed ffprobe run) goes through one helper that prints SKIPPED, or fails the test with CRAFT_MEDIA_REQUIRE_ORACLES=1. Fixture generators of both containers share run_generator, which takes the required flag explicitly so tests can exercise it without changing the process environment. * media: use US spelling * media: a failed ffprobe probe skips the optional oracle check * media: the Matroska oracle compares the last subtitle cue's duration