mirror of
https://github.com/storytold/craft-libs.git
synced 2026-11-17 07:44:40 +00:00
* craft-audio: Opus decoder FilmCraft's `filmcraft-opus` decoder as `craft_audio::opus` behind `opus-decode`: SILK, hybrid and CELT, every frame size, PLC and FEC, multistream (`Decoder`) and single stream (`StreamDecoder`), 8-48 kHz output. - `TrackDecoder` decodes Opus; mono and stereo without an `OpusHead` (RTP, MPEG-TS) get a default one. Lost packets use Opus's own concealment. - The native read path takes Ogg Opus (pre-skip and end trimming per RFC 7845), and Opus in Matroska/WebM and MP4, where packet starts after a seek come from the packets' own lengths. The RFC 8251 conformance test runs all 36 vectors. `scripts/fetch-opus-vectors.sh` downloads them (SHA-256 checked) and the CI test job caches them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * craft-audio: review fixes, round 1 (#445) - CELT concealment keeps its pitch in its own field. It reused postfilter_period_old, which the next good frame's post-filter cross-fades from. - Matroska Opus seeks: a failed packet read no longer caches a wrong start; a one-byte packet is read as one byte. - A malformed OpusHead in Ogg is reported as malformed instead of falling back. - The libopus oracle tests skip through the testkit, so CRAFT_MEDIA_REQUIRE_ORACLES fails them. - Decoder::reset documents that it re-arms pre-skip trimming. - fetch-opus-vectors.sh retries its size probe. - CI: the vectors are fetched after ffmpeg is installed, and apt's timeout runs as root so a stalled apt-get is killed and frees the dpkg lock. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * craft-audio: review fixes, round 2 (#445) - CELT: the noise-based concealment sets skip_plc, as libopus does, so pitch-based concealment waits for two good frames in a row instead of extending history that holds noise. - SILK: decode_only_middle is per call, as in libopus. A lost or mono frame no longer reuses the mid-only flag from an earlier frame. - A damaged Opus packet is concealed at its own length (from its TOC and framing) rather than the previous packet's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Dylan M. Taylor <dylan@dylanmtaylor.com>
48 lines
1.6 KiB
Rust
48 lines
1.6 KiB
Rust
//! The decoder half of [`crate::opus`]: FilmCraft's `filmcraft-opus` (storytold/filmcraft@8fda2f2).
|
|
|
|
// The fixed-point parts mirror the normative integer arithmetic; keep C-like shift expressions.
|
|
#![allow(clippy::precedence, clippy::int_plus_one)]
|
|
|
|
pub(crate) mod celt;
|
|
mod decoder;
|
|
mod header;
|
|
mod multistream;
|
|
pub mod packet;
|
|
pub(crate) mod range;
|
|
pub(crate) mod silk;
|
|
|
|
pub use decoder::{SAMPLE_RATES, StreamDecoder};
|
|
pub use header::OpusHead;
|
|
pub use multistream::Decoder;
|
|
pub use packet::{Mode, Packet, Toc};
|
|
|
|
/// Errors from header parsing and decoding.
|
|
#[non_exhaustive]
|
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
|
pub enum Error {
|
|
/// An argument is out of range (sampling rate, channel count, concealment length, output size).
|
|
InvalidArgument(&'static str),
|
|
/// A malformed packet (RFC 6716 §3.4).
|
|
InvalidPacket(&'static str),
|
|
/// A malformed `OpusHead` (RFC 7845 §5.1) or MP4 `dOps` box.
|
|
InvalidHeader(&'static str),
|
|
/// A valid stream uses a feature this decoder does not implement.
|
|
Unsupported(&'static str),
|
|
}
|
|
|
|
impl std::fmt::Display for Error {
|
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
|
match self {
|
|
Error::InvalidArgument(s) => write!(f, "invalid argument: {s}"),
|
|
Error::InvalidPacket(s) => write!(f, "invalid packet: {s}"),
|
|
Error::InvalidHeader(s) => write!(f, "invalid header: {s}"),
|
|
Error::Unsupported(s) => write!(f, "unsupported: {s}"),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl std::error::Error for Error {}
|
|
|
|
/// Result with this module's [`Error`].
|
|
pub type Result<T> = std::result::Result<T, Error>;
|