mirror of
https://github.com/storytold/craft-libs.git
synced 2026-10-31 15:49:54 +00:00
skylar taylor-barrick
559992953f
A test is not instant and the address field stays editable while it runs, so its answer can arrive after the address has changed. `set_models` then recorded the models against whatever the field held by the time it returned, filing one endpoint's models under another — the mislabelling `models_fit` exists to prevent, reached the asynchronous way rather than the synchronous ones already closed. `set_models` now takes the address the test was started against and returns whether the models were taken, so an answer that outlived its address is dropped and the caller can say the result is out of date. The parameter replaces the old signature rather than joining it: there was no second legitimate caller, and leaving an address-free version beside it would have left the racy call the shorter, easier one to reach — against this module's rule that the rules live once so two screens cannot disagree. Also fixes a pre-existing mismatch found while testing this: `from_connection` recorded the loaded address untrimmed while `prepare` compares it trimmed, so a stored endpoint with stray whitespace dropped its models on the first save.